Patchwork [U-Boot] uboot.lds issue

login
register
mail settings
Submitter Chander M. Kashyap
Date March 24, 2011, 7:12 a.m.
Message ID <AANLkTinEzYUhEs+vOU6e1qX6VZR=LMFGu4t+hjEJTA=z@mail.gmail.com>
Download mbox | patch
Permalink /patch/88139/
State Changes Requested
Headers show

Comments

Chander M. Kashyap - March 24, 2011, 7:12 a.m.
Hi. I am getting data abort while using original u-boot.lds file.
If i allign bss to 4 bytes rather than using " .bss __rel_dyn_start
(OVERLAY) : {".
With existing code i am getting odd address leading to data abort.
PFA the patch.

Is this a right approach to fix the data abort?

regards,
Chander


 arch/arm/cpu/armv7/u-boot.lds |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

--
Wolfgang Denk - March 24, 2011, 8:23 a.m.
Dear "Chander M. Kashyap",

please submit patches ONLY inline, not as attachments!

In message <AANLkTinEzYUhEs+vOU6e1qX6VZR=LMFGu4t+hjEJTA=z@mail.gmail.com> you wrote:
>
> Hi. I am getting data abort while using original u-boot.lds file.
> If i allign bss to 4 bytes rather than using " .bss __rel_dyn_start
> (OVERLAY) : {".
> With existing code i am getting odd address leading to data abort.
> PFA the patch.
> 
> Is this a right approach to fix the data abort?

No, this is not correct.  You should keep the OVERLAY part.

> @@ -66,7 +66,8 @@ SECTIONS
>                 *(.dynsym)
>         }
> 
> -       .bss __rel_dyn_start (OVERLAY) : {
> +       . = ALIGN(4);
> +       .bss : {

Try instead:

	. = ALIGN(4);
	.bss __rel_dyn_start (OVERLAY) : {


Best regards,

Wolfgang Denk

Patch

diff --git a/arch/arm/cpu/armv7/u-boot.lds b/arch/arm/cpu/armv7/u-boot.lds
index 5725c30..2a1888e 100644
--- a/arch/arm/cpu/armv7/u-boot.lds
+++ b/arch/arm/cpu/armv7/u-boot.lds
@@ -66,7 +66,8 @@  SECTIONS
                *(.dynsym)
        }

-       .bss __rel_dyn_start (OVERLAY) : {
+       . = ALIGN(4);
+       .bss : {
                __bss_start = .;
                *(.bss)
                 . = ALIGN(4);