[1/2] package/freescale-imx: Remove imx6s from has_vpu list

Message ID 20180304150606.32748-1-bernd.kuhls@t-online.de
State Accepted
Headers show
Series
  • [1/2] package/freescale-imx: Remove imx6s from has_vpu list
Related show

Commit Message

Bernd Kuhls March 4, 2018, 3:06 p.m.
According to imx-vpu-5.4.37/Makefile, line 6:

	INCLUDE_LIST:= IMX27ADS IMX51 IMX53 IMX6Q

imx6s is not supported by the imx-vpu package. Its install target,
guarded by

	ifeq ($(PLATFORM), $(findstring $(PLATFORM), $(INCLUDE_LIST)))

does nothing, causing a build error later on in the imx-vpuwrap package

checking for vpu_lib.h... no
configure: error: lib_vpu is required, consider installing imx-lib

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/freescale-imx/Config.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Gary Bisson March 5, 2018, 8:35 a.m. | #1
Hi Bernd,

On Sun, Mar 04, 2018 at 04:06:05PM +0100, Bernd Kuhls wrote:
> According to imx-vpu-5.4.37/Makefile, line 6:
> 
> 	INCLUDE_LIST:= IMX27ADS IMX51 IMX53 IMX6Q
> 
> imx6s is not supported by the imx-vpu package. Its install target,
> guarded by
> 
> 	ifeq ($(PLATFORM), $(findstring $(PLATFORM), $(INCLUDE_LIST)))
> 
> does nothing, causing a build error later on in the imx-vpuwrap package
> 
> checking for vpu_lib.h... no
> configure: error: lib_vpu is required, consider installing imx-lib
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Indeed that was a mistake.
Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>

Thanks,
Gary
Thomas Petazzoni March 31, 2018, 9:08 p.m. | #2
Hello,

On Sun,  4 Mar 2018 16:06:05 +0100, Bernd Kuhls wrote:
> According to imx-vpu-5.4.37/Makefile, line 6:
> 
> 	INCLUDE_LIST:= IMX27ADS IMX51 IMX53 IMX6Q
> 
> imx6s is not supported by the imx-vpu package. Its install target,
> guarded by
> 
> 	ifeq ($(PLATFORM), $(findstring $(PLATFORM), $(INCLUDE_LIST)))
> 
> does nothing, causing a build error later on in the imx-vpuwrap package
> 
> checking for vpu_lib.h... no
> configure: error: lib_vpu is required, consider installing imx-lib
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/freescale-imx/Config.in | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied to master, thanks.

Thomas
Peter Korsgaard April 8, 2018, 3:07 p.m. | #3
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > According to imx-vpu-5.4.37/Makefile, line 6:
 > 	INCLUDE_LIST:= IMX27ADS IMX51 IMX53 IMX6Q

 > imx6s is not supported by the imx-vpu package. Its install target,
 > guarded by

 > 	ifeq ($(PLATFORM), $(findstring $(PLATFORM), $(INCLUDE_LIST)))

 > does nothing, causing a build error later on in the imx-vpuwrap package

 > checking for vpu_lib.h... no
 > configure: error: lib_vpu is required, consider installing imx-lib

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Committed to 2018.02.x, thanks.

Patch

diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
index b5e5ab23dc..e33a90d912 100644
--- a/package/freescale-imx/Config.in
+++ b/package/freescale-imx/Config.in
@@ -60,8 +60,7 @@  config BR2_PACKAGE_FREESCALE_IMX_HAS_VPU
 	default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX27ADS || \
 		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 || \
 		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53 || \
-		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q || \
-		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S
+		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q
 
 config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU
 	bool