[dts/arm/aspeed-g5,v1] ARM: dts: aspeed-g5: Add IPMI KCS node

Message ID 1520139829-10672-1-git-send-email-haiyue.wang@linux.intel.com
State New
Headers show
Series
  • [dts/arm/aspeed-g5,v1] ARM: dts: aspeed-g5: Add IPMI KCS node
Related show

Commit Message

Wang, Haiyue March 4, 2018, 5:03 a.m.
The IPMI KCS device part of the LPC interface and is used for
communication with the host processor.

Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
---
Hi Joel & Andrew,

The kcs-bmc-aspeed module has been in:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/char/ipmi/kcs_bmc_aspeed.c
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt

I updated the device tree node about kcs-bmc, this is passed on my board.

And the patch is generated by rebasing on:
https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
Please help to review.

BR,
Haiyue
---
 arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 42 insertions(+), 1 deletion(-)

Comments

Joel Stanley March 7, 2018, 3:56 a.m. | #1
On Sun, Mar 4, 2018 at 3:33 PM, Haiyue Wang <haiyue.wang@linux.intel.com> wrote:
> The IPMI KCS device part of the LPC interface and is used for
> communication with the host processor.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> ---
> Hi Joel & Andrew,
>
> The kcs-bmc-aspeed module has been in:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/char/ipmi/kcs_bmc_aspeed.c
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
>
> I updated the device tree node about kcs-bmc, this is passed on my board.
>
> And the patch is generated by rebasing on:
> https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
> Please help to review.

Thanks for the patch. I suggest you submit this patch for inclusion in
the upstream kernel. To do this, send it to:

Joel Stanley <joel@jms.id.au>
Andrew Jeffery <andrew@aj.id.au>
linux-arm-kernel@lists.infradead.org
linux-aspeed@lists.ozlabs.org
linux-kernel@vger.kernel.org

And I will consider it for merging.

From there I can backport it into the dev-4.13 tree.

Cheers,

Joel

>
> BR,
> Haiyue
> ---
>  arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 8eac57c..f443169 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -267,8 +267,40 @@
>                                 ranges = <0x0 0x1e789000 0x1000>;
>
>                                 lpc_bmc: lpc-bmc@0 {
> -                                       compatible = "aspeed,ast2500-lpc-bmc";
> +                                       compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
>                                         reg = <0x0 0x80>;
> +                                       reg-io-width = <4>;
> +
> +                                       #address-cells = <1>;
> +                                       #size-cells = <1>;
> +                                       ranges = <0x0 0x0 0x80>;
> +
> +                                       kcs1: kcs1@0 {
> +                                               compatible = "aspeed,ast2500-kcs-bmc";
> +                                               reg = <0x0 0x80>;
> +                                               interrupts = <8>;
> +                                               kcs_chan = <1>;
> +                                               kcs_addr = <0x0>;
> +                                               status = "disabled";
> +                                       };
> +
> +                                       kcs2: kcs2@0 {
> +                                               compatible = "aspeed,ast2500-kcs-bmc";
> +                                               reg = <0x0 0x80>;
> +                                               interrupts = <8>;
> +                                               kcs_chan = <2>;
> +                                               kcs_addr = <0x0>;
> +                                               status = "disabled";
> +                                       };
> +
> +                                       kcs3: kcs3@0 {
> +                                               compatible = "aspeed,ast2500-kcs-bmc";
> +                                               reg = <0x0 0x80>;
> +                                               interrupts = <8>;
> +                                               kcs_chan = <3>;
> +                                               kcs_addr = <0x0>;
> +                                               status = "disabled";
> +                                       };
>                                 };
>
>                                 lpc_host: lpc-host@80 {
> @@ -294,6 +326,15 @@
>                                                 status = "disabled";
>                                         };
>
> +                                       kcs4: kcs4@0 {
> +                                               compatible = "aspeed,ast2500-kcs-bmc";
> +                                               reg = <0x0 0xa0>;
> +                                               interrupts = <8>;
> +                                               kcs_chan = <4>;
> +                                               kcs_addr = <0x0>;
> +                                               status = "disabled";
> +                                       };
> +
>                                         lhc: lhc@20 {
>                                                 compatible = "aspeed,ast2500-lhc";
>                                                 reg = <0x20 0x24 0x48 0x8>;
> --
> 2.7.4
>
Wang, Haiyue March 7, 2018, 4:41 a.m. | #2
On 2018-03-07 11:56, Joel Stanley wrote:
>> And the patch is generated by rebasing on:
>> https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
>> Please help to review.
> Thanks for the patch. I suggest you submit this patch for inclusion in
> the upstream kernel. To do this, send it to:
> Joel Stanley<joel@jms.id.au>
> Andrew Jeffery<andrew@aj.id.au>
> linux-arm-kernel@lists.infradead.org
> linux-aspeed@lists.ozlabs.org
> linux-kernel@vger.kernel.org
Got it.
> And I will consider it for merging.
>
>  From there I can backport it into the dev-4.13 tree.
>
> Cheers,
>
> Joel
>

Patch

diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 8eac57c..f443169 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -267,8 +267,40 @@ 
 				ranges = <0x0 0x1e789000 0x1000>;
 
 				lpc_bmc: lpc-bmc@0 {
-					compatible = "aspeed,ast2500-lpc-bmc";
+					compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
 					reg = <0x0 0x80>;
+					reg-io-width = <4>;
+
+					#address-cells = <1>;
+					#size-cells = <1>;
+					ranges = <0x0 0x0 0x80>;
+
+					kcs1: kcs1@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						reg = <0x0 0x80>;
+						interrupts = <8>;
+						kcs_chan = <1>;
+						kcs_addr = <0x0>;
+						status = "disabled";
+					};
+
+					kcs2: kcs2@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						reg = <0x0 0x80>;
+						interrupts = <8>;
+						kcs_chan = <2>;
+						kcs_addr = <0x0>;
+						status = "disabled";
+					};
+
+					kcs3: kcs3@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						reg = <0x0 0x80>;
+						interrupts = <8>;
+						kcs_chan = <3>;
+						kcs_addr = <0x0>;
+						status = "disabled";
+					};
 				};
 
 				lpc_host: lpc-host@80 {
@@ -294,6 +326,15 @@ 
 						status = "disabled";
 					};
 
+					kcs4: kcs4@0 {
+						compatible = "aspeed,ast2500-kcs-bmc";
+						reg = <0x0 0xa0>;
+						interrupts = <8>;
+						kcs_chan = <4>;
+						kcs_addr = <0x0>;
+						status = "disabled";
+					};
+
 					lhc: lhc@20 {
 						compatible = "aspeed,ast2500-lhc";
 						reg = <0x20 0x24 0x48 0x8>;