| Message ID | 20180303223954.14152-1-niklas.soderlund+renesas@ragnatech.se |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | ravb: remove erroneous comment | expand |
Hello! On 3/4/2018 1:39 AM, Niklas Söderlund wrote: > When addressing a review comment in a early version of the offending > patch a comment where left in which should have been removed. Remove the s/where/was/? > comment to keep it consistent with the code. > > Fixes: 75efa06f457bbed3 ("ravb: add support for changing MTU") > Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> [...] MBR, Sergei
From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Date: Sat, 3 Mar 2018 23:39:54 +0100 > When addressing a review comment in a early version of the offending > patch a comment where left in which should have been removed. Remove the > comment to keep it consistent with the code. > > Fixes: 75efa06f457bbed3 ("ravb: add support for changing MTU") > Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Applied to net-next, thanks.
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 54a6265da7a06460..68f122140966d4de 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -346,7 +346,6 @@ static int ravb_ring_init(struct net_device *ndev, int q) int ring_size; int i; - /* +16 gets room from the status from the card. */ priv->rx_buf_sz = (ndev->mtu <= 1492 ? PKT_BUF_SZ : ndev->mtu) + ETH_HLEN + VLAN_HLEN;
When addressing a review comment in a early version of the offending patch a comment where left in which should have been removed. Remove the comment to keep it consistent with the code. Fixes: 75efa06f457bbed3 ("ravb: add support for changing MTU") Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/net/ethernet/renesas/ravb_main.c | 1 - 1 file changed, 1 deletion(-)