[SRU,Artful,Bionic,linux-oem] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
diff mbox series

Message ID 1520084723-4016-2-git-send-email-hui.wang@canonical.com
State Accepted
Headers show
Series
  • [SRU,Artful,Bionic,linux-oem] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
Related show

Commit Message

Hui Wang March 3, 2018, 1:45 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1748807

With the alc289, the Pin 0x1b is Headphone-Mic, so we should assign
ALC269_FIXUP_DELL4_MIC_NO_PRESENCE rather than
ALC225_FIXUP_DELL1_MIC_NO_PRESENCE to it. And this change is suggested
by Kailang of Realtek and is verified on the machine.

Fixes: 3f2f7c553d07 ("ALSA: hda - Fix headset mic detection problem for two Dell machines")
Cc: Kailang Yang <kailang@realtek.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit d5078193e56bb24f4593f00102a3b5e07bb84ee0
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aaron Ma March 5, 2018, 2:37 a.m. UTC | #1
Acked-by: Aaron Ma <aaron.ma@canonical.com>
Aaron Ma March 5, 2018, 2:38 a.m. UTC | #2
Acked-by: Aaron Ma <aaron.ma@canonical.com>

Patch
diff mbox series

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 37778fa..a8e1b1e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6764,7 +6764,7 @@  static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 		{0x12, 0x90a60120},
 		{0x14, 0x90170110},
 		{0x21, 0x0321101f}),
-	SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
+	SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE,
 		{0x12, 0xb7a60130},
 		{0x14, 0x90170110},
 		{0x21, 0x04211020}),