| Message ID | 20180303122554.20984-1-andre.przywara@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] pinctrl: sunxi: always look for apb block | expand |
On Sat, Mar 03, 2018 at 12:25:54PM +0000, Andre Przywara wrote: > The Allwinner pinctrl device tree binding suggests that a clock named > "apb" would drive the pin controller IP. However (for legacy reasons) we > rely on this clock actually being the first clock defined. > Since named clocks can be in any order, let's explicitly check for a > clock called "apb" if there is more than one clock referenced. > > Kudo to Maxime for suggesting this much more elegant approach. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> Thanks! Maxime
On Sat, Mar 3, 2018 at 1:25 PM, Andre Przywara <andre.przywara@arm.com> wrote: > The Allwinner pinctrl device tree binding suggests that a clock named > "apb" would drive the pin controller IP. However (for legacy reasons) we > rely on this clock actually being the first clock defined. > Since named clocks can be in any order, let's explicitly check for a > clock called "apb" if there is more than one clock referenced. > > Kudo to Maxime for suggesting this much more elegant approach. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Patch applied with Maxime's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index 341312d66512..bc3d59f2173f 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -1363,7 +1363,8 @@ int sunxi_pinctrl_init_with_variant(struct platform_device *pdev, goto gpiochip_error; } - clk = devm_clk_get(&pdev->dev, NULL); + ret = of_count_phandle_with_args(node, "clocks", "#clock-cells"); + clk = devm_clk_get(&pdev->dev, ret == 1 ? NULL : "apb"); if (IS_ERR(clk)) { ret = PTR_ERR(clk); goto gpiochip_error;
The Allwinner pinctrl device tree binding suggests that a clock named "apb" would drive the pin controller IP. However (for legacy reasons) we rely on this clock actually being the first clock defined. Since named clocks can be in any order, let's explicitly check for a clock called "apb" if there is more than one clock referenced. Kudo to Maxime for suggesting this much more elegant approach. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)