From patchwork Fri Mar 2 17:04:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 880673 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ub5g3vvk"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ztGcj65lFz9s3F for ; Sat, 3 Mar 2018 04:33:57 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=vyzV98ABnCd9AhQdQZjlYAN0vXprjXy8Ybn+KT3zQDM=; b=ub5g3vvkvcRFF0XKlJESQ8FEbR jhY7AzJPw8LPp8WimBcYzPs/QaKWjsGLeoh8QUB8ebixoTJYPoj83U3EQ5gu9iTnMvHlsGj5hhKYm U1Y4HhTVCH6UPCymh2PkwE48lyiIOtaElbyeDgL5uSKHevWnlgH9ZaLzrmSJKfG9UxTQBdKon+gWe UB7CuL6YHRM0+pzyNQhu3SxPNkvNB9hdk/Td548vfqOCyUjkPiOe6S78FL0flM3IL3QPLeDcc+uf4 MfXr2RaiCgusWl6VaPrzauy6chGLeoVbfTupTzKyuNaso1AhDv3QncS+2+n+mYgg3xoj4ArCe7NaG LTAy8HUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eroZ5-0003eY-1t; Fri, 02 Mar 2018 17:33:51 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ero7E-0002ak-RH; Fri, 02 Mar 2018 17:05:38 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 274EF207EF; Fri, 2 Mar 2018 18:04:48 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost.localdomain (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 3DE3A2091C; Fri, 2 Mar 2018 18:04:47 +0100 (CET) From: Miquel Raynal To: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Josh Wu , Kamal Dasu , Harvey Hunt , Stefan Agner Subject: [PATCH 52/52] mtd: rawnand: allocate dynamically ONFI parameters during detection Date: Fri, 2 Mar 2018 18:04:00 +0100 Message-Id: <20180302170400.6712-53-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180302170400.6712-1-miquel.raynal@bootlin.com> References: <20180302170400.6712-1-miquel.raynal@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180302_090505_921758_3B785D07 X-CRM114-Status: GOOD ( 17.39 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Miquel Raynal MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Now that it is possible to do dynamic allocations during the identification phase, convert the onfi_params structure (which is only needed with ONFI compliant chips) into a pointer that will be allocated only if needed. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/raw/nand_base.c | 37 +++++++++++++++++++++++++------------ drivers/mtd/nand/raw/nand_micron.c | 4 ++-- drivers/mtd/nand/raw/nand_timings.c | 12 ++++++------ include/linux/mtd/rawnand.h | 6 +++--- 4 files changed, 36 insertions(+), 23 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 82d52112907f..1b9fdf51ed8e 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -5100,6 +5100,7 @@ static int nand_flash_detect_onfi(struct nand_chip *chip) { struct mtd_info *mtd = nand_to_mtd(chip); struct nand_onfi_params *p; + struct onfi_params *op; char *model; char id[4]; int i, ret, val; @@ -5154,8 +5155,6 @@ static int nand_flash_detect_onfi(struct nand_chip *chip) if (!chip->onfi_version) { pr_info("unsupported ONFI version: %d\n", val); goto free_onfi_param_page; - } else { - ret = 1; } sanitize_string(p->manufacturer, sizeof(p->manufacturer)); @@ -5224,19 +5223,31 @@ static int nand_flash_detect_onfi(struct nand_chip *chip) bitmap_set(chip->parameters.set_feature_list, ONFI_FEATURE_ADDR_TIMING_MODE, 1); } - chip->parameters.onfi_params.t_prog = le16_to_cpu(p->t_prog); - chip->parameters.onfi_params.t_bers = le16_to_cpu(p->t_bers); - chip->parameters.onfi_params.t_r = le16_to_cpu(p->t_r); - chip->parameters.onfi_params.t_ccs = le16_to_cpu(p->t_ccs); - chip->parameters.onfi_params.async_timing_mode = - le16_to_cpu(p->async_timing_mode); - chip->parameters.onfi_params.vendor_revision = - le16_to_cpu(p->vendor_revision); - memcpy(chip->parameters.onfi_params.vendor, p->vendor, - sizeof(p->vendor)); + op = kzalloc(sizeof(*op), GFP_KERNEL); + if (!op) { + ret = -ENOMEM; + goto free_model; + } + op->t_prog = le16_to_cpu(p->t_prog); + op->t_bers = le16_to_cpu(p->t_bers); + op->t_r = le16_to_cpu(p->t_r); + op->t_ccs = le16_to_cpu(p->t_ccs); + op->async_timing_mode = le16_to_cpu(p->async_timing_mode); + op->vendor_revision = le16_to_cpu(p->vendor_revision); + memcpy(op->vendor, p->vendor, sizeof(p->vendor)); + chip->parameters.onfi_params = op; + + /* Identification done, free the full ONFI parameter page and exit */ + kfree(p); + + return 1; + +free_model: + kfree(model); free_onfi_param_page: kfree(p); + return ret; } @@ -5966,6 +5977,8 @@ static int nand_scan_ident(struct mtd_info *mtd, int maxchips, static void nand_scan_ident_cleanup(struct nand_chip *chip) { kfree(chip->parameters.model); + kfree(chip->parameters.onfi_params); + } static int nand_set_ecc_soft_ops(struct mtd_info *mtd) diff --git a/drivers/mtd/nand/raw/nand_micron.c b/drivers/mtd/nand/raw/nand_micron.c index 651129023257..0674721acad8 100644 --- a/drivers/mtd/nand/raw/nand_micron.c +++ b/drivers/mtd/nand/raw/nand_micron.c @@ -57,9 +57,9 @@ static int micron_nand_setup_read_retry(struct mtd_info *mtd, int retry_mode) static int micron_nand_onfi_init(struct nand_chip *chip) { struct nand_parameters *p = &chip->parameters; - struct nand_onfi_vendor_micron *micron = (void *)p->onfi_params.vendor; + struct nand_onfi_vendor_micron *micron = (void *)p->onfi_params->vendor; - if (chip->onfi_version && p->onfi_params.vendor_revision) { + if (p->onfi_params && p->onfi_params->vendor_revision) { chip->read_retries = micron->read_retry_options; chip->setup_read_retry = micron_nand_setup_read_retry; } diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c index b97bcf29f75a..58dc524471fa 100644 --- a/drivers/mtd/nand/raw/nand_timings.c +++ b/drivers/mtd/nand/raw/nand_timings.c @@ -292,6 +292,7 @@ int onfi_fill_data_interface(struct nand_chip *chip, int timing_mode) { struct nand_data_interface *iface = &chip->data_interface; + struct onfi_params *onfi_params = chip->parameters.onfi_params; if (type != NAND_SDR_IFACE) return -EINVAL; @@ -306,17 +307,16 @@ int onfi_fill_data_interface(struct nand_chip *chip, * tR, tPROG, tCCS, ... * These information are part of the ONFI parameter page. */ - if (chip->onfi_version) { - struct nand_parameters *params = &chip->parameters; + if (onfi_params) { struct nand_sdr_timings *timings = &iface->timings.sdr; /* microseconds -> picoseconds */ - timings->tPROG_max = 1000000ULL * params->onfi_params.t_prog; - timings->tBERS_max = 1000000ULL * params->onfi_params.t_bers; - timings->tR_max = 1000000ULL * params->onfi_params.t_r; + timings->tPROG_max = 1000000ULL * onfi_params->t_prog; + timings->tBERS_max = 1000000ULL * onfi_params->t_bers; + timings->tR_max = 1000000ULL * onfi_params->t_r; /* nanoseconds -> picoseconds */ - timings->tCCS_min = 1000UL * params->onfi_params.t_ccs; + timings->tCCS_min = 1000UL * onfi_params->t_ccs; } return 0; diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index 9e15256bef2b..7d43fc05d009 100644 --- a/include/linux/mtd/rawnand.h +++ b/include/linux/mtd/rawnand.h @@ -445,7 +445,7 @@ struct nand_parameters { DECLARE_BITMAP(get_feature_list, ONFI_FEATURE_NUMBER); /* ONFI parameters */ - struct onfi_params onfi_params; + struct onfi_params *onfi_params; }; /* The maximum expected count of bytes in the NAND ID sequence */ @@ -1559,10 +1559,10 @@ struct platform_nand_data { /* return the supported asynchronous timing mode. */ static inline int onfi_get_async_timing_mode(struct nand_chip *chip) { - if (!chip->onfi_version) + if (!chip->parameters.onfi_params) return ONFI_TIMING_MODE_UNKNOWN; - return chip->parameters.onfi_params.async_timing_mode; + return chip->parameters.onfi_params->async_timing_mode; } int onfi_fill_data_interface(struct nand_chip *chip,