diff mbox series

libiberty: fix URL for demangler ABI

Message ID 1520009093-3612-1-git-send-email-dmalcolm@redhat.com
State New
Headers show
Series libiberty: fix URL for demangler ABI | expand

Commit Message

David Malcolm March 2, 2018, 4:44 p.m. UTC 
The comment at the top of cp-demangle.c lists:
  http://www.codesourcery.com/cxx-abi/abi.html#mangling
which redirects to:
  https://mentorembedded.github.io/cxx-abi/abi.html#mangling
but this is a 404: the latter site is empty.

I looked on archive.org; the final version before the redirect
seems to be:
  https://web.archive.org/web/20110903075217/http://www.codesourcery.com:80/public/cxx-abi/abi.html

Some searching showed up:
  https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling

I don't know how canonical this page is, but:
  https://itanium-cxx-abi.github.io/cxx-abi/
has "Revised March 14, 2017", which seems relatively up-to-date, so this
patch updates the comment to point to that site.

OK for trunk?

libiberty/ChangeLog:
	* cp-demangle.c: Update URL for g++ V3 ABI.
---
 libiberty/cp-demangle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Law March 2, 2018, 4:41 p.m. UTC | #1 
On 03/02/2018 09:44 AM, David Malcolm wrote:
> The comment at the top of cp-demangle.c lists:
>   http://www.codesourcery.com/cxx-abi/abi.html#mangling
> which redirects to:
>   https://mentorembedded.github.io/cxx-abi/abi.html#mangling
> but this is a 404: the latter site is empty.
> 
> I looked on archive.org; the final version before the redirect
> seems to be:
>   https://web.archive.org/web/20110903075217/http://www.codesourcery.com:80/public/cxx-abi/abi.html
> 
> Some searching showed up:
>   https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling
> 
> I don't know how canonical this page is, but:
>   https://itanium-cxx-abi.github.io/cxx-abi/
> has "Revised March 14, 2017", which seems relatively up-to-date, so this
> patch updates the comment to point to that site.
> 
> OK for trunk?
> 
> libiberty/ChangeLog:
> 	* cp-demangle.c: Update URL for g++ V3 ABI.
OK.
jeff
diff mbox series

Patch

diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c
index 1d5b855..3f2a097 100644
--- a/libiberty/cp-demangle.c
+++ b/libiberty/cp-demangle.c
@@ -30,7 +30,7 @@ 
 
 /* This code implements a demangler for the g++ V3 ABI.  The ABI is
    described on this web page:
-       http://www.codesourcery.com/cxx-abi/abi.html#mangling
+       https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling
 
    This code was written while looking at the demangler written by
    Alex Samuel <samuel@codesourcery.com>.