[v3,04/14] mtd: rawnand: move calls to ->select_chip() in nand_setup_data_interface()

Message ID 20180302142422.2543-5-miquel.raynal@bootlin.com
State Changes Requested
Delegated to: Boris Brezillon
Headers show
  • Improve timings handling in the NAND framework
Related show

Commit Message

Miquel Raynal March 2, 2018, 2:24 p.m.
After a ->set_features(TIMINGS), the chip is supposed to be working at a
new speed. In order for all the transactions to be perperly handled, the
NAND controller should also be configured to this same speed. Calling
->setup_data_interface() is not enough and the chip should be
de-asserted/re-asserted through calls to ->select_chip().

Prepare the next change in nand_setup_data_interface() where timings
will be checked after being applied. Because assertions of the CS pin
will be needed from within this function, move the calls to
->select_chip() inside nand_setup_data_interface() for later

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
 drivers/mtd/nand/raw/nand_base.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)


diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 802cd9ed44a1..8e48f08d8496 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -1231,9 +1231,11 @@  static int nand_setup_data_interface(struct nand_chip *chip, int chipnr)
+		chip->select_chip(mtd, chipnr);
 		ret = chip->set_features(mtd, chip,
+		chip->select_chip(mtd, -1);
 		if (ret)
 			goto err;
@@ -2739,10 +2741,8 @@  int nand_reset(struct nand_chip *chip, int chipnr)
 	if (ret)
 		return ret;
-	chip->select_chip(mtd, chipnr);
 	chip->data_interface = saved_data_intf;
 	ret = nand_setup_data_interface(chip, chipnr);
-	chip->select_chip(mtd, -1);
 	if (ret)
 		return ret;
@@ -6474,10 +6474,7 @@  int nand_scan_tail(struct mtd_info *mtd)
 	/* Enter fastest possible mode on all dies. */
 	for (i = 0; i < chip->numchips; i++) {
-		chip->select_chip(mtd, i);
 		ret = nand_setup_data_interface(chip, i);
-		chip->select_chip(mtd, -1);
 		if (ret)
 			goto err_nand_manuf_cleanup;