diff mbox series

[U-Boot,v2,2/2] mmc: zynq_sdhci: use correct quirk if CONFIG_ZYNQ_HISPD_BROKEN is defined

Message ID 1519984837-17809-2-git-send-email-hannes.schmelzer@br-automation.com
State Superseded
Delegated to: Jaehoon Chung
Headers show
Series [U-Boot,v2,1/2] mmc: sdhci: add SDHCI_QUIRK_BROKEN_HISPD_MODE | expand

Commit Message

Hannes Schmelzer March 2, 2018, 10 a.m. UTC 
The 'SDHCI_QUIRK_NO_HISPD_BIT' is used wrong here. The purpose of this
quirk is to tell the sdhci-driver that the IP-core doesn't have a "high-
speed-enable" bit in its registers.

With this commit we change this to the correct quirk:
SDHCI_QUIRK_BROKEN_HISPD_MODE

Signed-off-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com>
---

Changes in v2: None

 drivers/mmc/zynq_sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michal Simek March 5, 2018, 8:12 a.m. UTC | #1 
Hi Siva,

On 2.3.2018 11:00, Hannes Schmelzer wrote:
> The 'SDHCI_QUIRK_NO_HISPD_BIT' is used wrong here. The purpose of this
> quirk is to tell the sdhci-driver that the IP-core doesn't have a "high-
> speed-enable" bit in its registers.
> 
> With this commit we change this to the correct quirk:
> SDHCI_QUIRK_BROKEN_HISPD_MODE
> 
> Signed-off-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com>
> ---
> 
> Changes in v2: None
> 
>  drivers/mmc/zynq_sdhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c
> index 0fddb42..8899e72 100644
> --- a/drivers/mmc/zynq_sdhci.c
> +++ b/drivers/mmc/zynq_sdhci.c
> @@ -58,7 +58,7 @@ static int arasan_sdhci_probe(struct udevice *dev)
>  		       SDHCI_QUIRK_BROKEN_R1B;
>  
>  #ifdef CONFIG_ZYNQ_HISPD_BROKEN
> -	host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
> +	host->quirks |= SDHCI_QUIRK_BROKEN_HISPD_MODE;
>  #endif
>  
>  	host->max_clk = clock;
> 

Can you please look at it?

Thanks,
Michal
diff mbox series

Patch

diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c
index 0fddb42..8899e72 100644
--- a/drivers/mmc/zynq_sdhci.c
+++ b/drivers/mmc/zynq_sdhci.c
@@ -58,7 +58,7 @@  static int arasan_sdhci_probe(struct udevice *dev)
 		       SDHCI_QUIRK_BROKEN_R1B;
 
 #ifdef CONFIG_ZYNQ_HISPD_BROKEN
-	host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
+	host->quirks |= SDHCI_QUIRK_BROKEN_HISPD_MODE;
 #endif
 
 	host->max_clk = clock;