gpio: raspberrypi-exp: explain Kconfig dependency

Message ID 3c3b8755d186b1f762081ee18efb718886814e51.1519984021.git.baruch@tkos.co.il
State New
Headers show
Series
  • gpio: raspberrypi-exp: explain Kconfig dependency
Related show

Commit Message

Baruch Siach March 2, 2018, 9:47 a.m.
Commit 7ed915059c3001 (gpio: raspberrypi-ext: fix firmware dependency)
fixed the Kconfig dependency to ensure that gpio-raspberrypi-exp is not
built-in when the firmware is a module. But the Kconfig syntax for doing
so is cryptic. Add a comment to make it a little easier.

Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/gpio/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Linus Walleij March 2, 2018, noon | #1
On Fri, Mar 2, 2018 at 10:47 AM, Baruch Siach <baruch@tkos.co.il> wrote:

> Commit 7ed915059c3001 (gpio: raspberrypi-ext: fix firmware dependency)
> fixed the Kconfig dependency to ensure that gpio-raspberrypi-exp is not
> built-in when the firmware is a module. But the Kconfig syntax for doing
> so is cryptic. Add a comment to make it a little easier.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 52a8b0a6f4e1..1bb25c1ff2d8 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -126,6 +126,8 @@  config GPIO_RASPBERRYPI_EXP
 	tristate "Raspberry Pi 3 GPIO Expander"
 	default RASPBERRYPI_FIRMWARE
 	depends on OF_GPIO
+	# Make sure not 'y' when RASPBERRYPI_FIRMWARE is 'm'. This can only
+	# happen when COMPILE_TEST=y, hence the added !RASPBERRYPI_FIRMWARE.
 	depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)
 	help
 	  Turn on GPIO support for the expander on Raspberry Pi 3 boards, using