Message ID | 20180301140032.20822-5-phil@nwl.cc |
---|---|
State | Accepted |
Delegated to: | Pablo Neira |
Headers | show |
Series | None | expand |
diff --git a/src/hash.c b/src/hash.c index 3355cadd1df2f..e6999637566c3 100644 --- a/src/hash.c +++ b/src/hash.c @@ -36,7 +36,7 @@ static void hash_expr_print(const struct expr *expr, struct output_ctx *octx) static bool hash_expr_cmp(const struct expr *e1, const struct expr *e2) { - return (e1->hash.expr || + return (!e1->hash.expr || expr_cmp(e1->hash.expr, e2->hash.expr)) && e1->hash.mod == e2->hash.mod && e1->hash.seed_set == e2->hash.seed_set &&
The first part of the conditional: | (e1->hash.expr || expr_cmp(e1->hash.expr, e2->hash.expr)) will call expr_cmp() in case e1->hash.expr is NULL, causing null-pointer dereference. This is probably a typo, the intention when introducing this was to avoid the call to expr_cmp() for symmetric hash expressions which don't use expr->hash.expr. Inverting the existence check should fix this. Fixes: 3a86406729782 ("src: hash: support of symmetric hash") Cc: Laura Garcia Liebana <nevola@gmail.com> Signed-off-by: Phil Sutter <phil@nwl.cc> --- src/hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)