Patchwork [U-Boot,3/4] I2C: add driver of st-ericsson u8500 i2c

login
register
mail settings
Submitter John Rigby
Date March 22, 2011, 8:40 p.m.
Message ID <1300826419-18632-4-git-send-email-john.rigby@linaro.org>
Download mbox | patch
Permalink /patch/87957/
State Changes Requested
Headers show

Comments

John Rigby - March 22, 2011, 8:40 p.m.
From: Michael Brandt <michael.brandt@stericsson.com>

Signed-off-by: John Rigby <john.rigby@linaro.org>
---
 drivers/i2c/Makefile    |    1 +
 drivers/i2c/u8500_i2c.c |  603 +++++++++++++++++++++++++++++++++++++++++++++++
 drivers/i2c/u8500_i2c.h |  220 +++++++++++++++++
 3 files changed, 824 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/u8500_i2c.c
 create mode 100644 drivers/i2c/u8500_i2c.h
Heiko Schocher - March 23, 2011, 7 a.m.
Hello John,

John Rigby wrote:
> From: Michael Brandt <michael.brandt@stericsson.com>
> 
> Signed-off-by: John Rigby <john.rigby@linaro.org>
> ---
>  drivers/i2c/Makefile    |    1 +
>  drivers/i2c/u8500_i2c.c |  603 +++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/i2c/u8500_i2c.h |  220 +++++++++++++++++
>  3 files changed, 824 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/i2c/u8500_i2c.c
>  create mode 100644 drivers/i2c/u8500_i2c.h
> 
> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
> index 052fe36..ac9c00f 100644
> --- a/drivers/i2c/Makefile
> +++ b/drivers/i2c/Makefile
> @@ -40,6 +40,7 @@ COBJS-$(CONFIG_S3C44B0_I2C) += s3c44b0_i2c.o
>  COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o
>  COBJS-$(CONFIG_SPEAR_I2C) += spr_i2c.o
>  COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.o
> +COBJS-$(CONFIG_DRIVER_U8500_I2C) += u8500_i2c.o

please without "_DRIVER". (you also need to sort lists
alphabetically)

>  COBJS	:= $(COBJS-y)
>  SRCS	:= $(COBJS:.o=.c)
> diff --git a/drivers/i2c/u8500_i2c.c b/drivers/i2c/u8500_i2c.c
> new file mode 100644
> index 0000000..8965100
> --- /dev/null
> +++ b/drivers/i2c/u8500_i2c.c
> @@ -0,0 +1,603 @@
> +/*
> + * Copyright (C) ST-Ericsson SA 2010
> + *
> + * Basic U-Boot I2C interface for STn8500/DB8500
> + * Author: Michael Brandt <Michael.Brandt@stericsson.com> for ST-Ericsson
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> + */
> +
> +/*
> + * Only 7-bit I2C device addresses are supported.
> + */
> +
> +#include <common.h>
> +#include <i2c.h>
> +
> +#include "u8500_i2c.h"
> +#include <asm/io.h>
> +#include <asm/arch/common.h>
> +#include <asm/arch/clock.h>
> +
> +#define I2C_ENDAD_COUNTER	(CONFIG_SYS_HZ/100)	/* I2C bus timeout */
> +#define I2C_FIFO_FLUSH_COUNTER	500000		/* flush "timeout" */
> +#define I2C_SCL_FREQ		100000		/* I2C bus clock frequency.*/
> +#define I2C_INPUT_FREQ		48000000	/* Input clock frequency.*/
> +#define TX_FIFO_THRESHOLD	0x4
> +#define RX_FIFO_THRESHOLD	0x4
> +#define SLAVE_SETUP_TIME 14 /* Slave data setup time, 250ns for 48MHz i2c_clk */
> +
> +#define WRITE_FIELD(var, mask, shift, value) \
> +			(var = ((var & ~(mask)) | ((value) << (shift))))
> +
> +static unsigned int bus_initialized[CONFIG_SYS_I2C_BUS_MAX];
> +static unsigned int i2c_bus_num;
> +static unsigned int i2c_bus_speed[] = {
> +	CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SPEED,
> +	CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SPEED
> +};

All busses with the same speed? Also please use something
like "CONFIG_SYS_I2C_U8500_SPEED"

> +static struct u8500_i2c_regs *i2c_dev[] = {
> +	(struct u8500_i2c_regs *)CONFIG_SYS_I2C0_BASE,
> +	(struct u8500_i2c_regs *)CONFIG_SYS_I2C1_BASE,
> +	(struct u8500_i2c_regs *)CONFIG_SYS_I2C2_BASE,
> +	(struct u8500_i2c_regs *)CONFIG_SYS_I2C3_BASE,

Could we use for example "CONFIG_SYS_I2C_U8500_BASEx"?

> +};
> +
> +static struct {
> +	int periph;
> +	int pcken;
> +	int kcken;
> +} i2c_clock_bits[] = {
> +	{3, 3, 3}, /* I2C0 */
> +	{1, 2, 2}, /* I2C1 */
> +	{1, 6, 6}, /* I2C2 */
> +	{2, 0, 0}, /* I2C3 */
> +};
[...]
> diff --git a/drivers/i2c/u8500_i2c.h b/drivers/i2c/u8500_i2c.h
> new file mode 100644
> index 0000000..8ef6667
> --- /dev/null
> +++ b/drivers/i2c/u8500_i2c.h
> @@ -0,0 +1,220 @@
> +/*
> + * Copyright (C) ST-Ericsson SA 2009
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef _U8500_I2C_H_
> +#define _U8500_I2C_H_
> +
> +#include <asm/types.h>
> +#include <asm/io.h>
> +#include <asm/errno.h>
> +
> +//#include "common.h"

No C99 comments please. If it is dead code, please remove.

> +#include <asm/arch/u8500.h>
> +
> +/* Generic macros */
> +
> +#define I2C_WRITE_FIELD(reg_name, mask, shift, value) \
> +		(reg_name = ((reg_name & ~mask) | (value << shift)))
> +#define I2C_READ_FIELD(reg_name, mask, shift)    ((reg_name & mask) >> shift)
> +
> +struct u8500_i2c_regs {
> +	u32 cr;			/* Control Register                      0x00 */
> +	u32 scr;		/* Slave Address Register                0x04 */
> +	u32 hsmcr;		/* HS Master code Register               0x08 */
> +	u32 mcr;		/* Master Control Register               0x0C */
> +	u32 tfr;		/* Transmit Fifo Register                0x10 */
> +	u32 sr;			/* Status Register                       0x14 */
> +	u32 rfr;		/* Receiver Fifo Register                0x18 */
> +	u32 tftr;		/* Transmit Fifo Threshold Register      0x1C */
> +	u32 rftr;		/* Receiver Fifo Threshold Register      0x20 */
> +	u32 dmar;		/* DMA register                          0x24 */
> +	u32 brcr;		/* Baud Rate Counter Register            0x28 */
> +	u32 imscr;		/* Interrupt Mask Set and Clear Register 0x2C */
> +	u32 risr;		/* Raw interrupt status register         0x30 */
> +	u32 misr;		/* Masked interrupt status register      0x34 */
> +	u32 icr;		/* Interrupt Set and Clear Register      0x38 */
> +	u32 reserved_1[(0xFE0 - 0x3c) >> 2];	/* Reserved 0x03C to 0xFE0 */
> +	u32 periph_id_0;	/* peripheral ID 0	0xFE0 */
> +	u32 periph_id_1;	/* peripheral ID 1	0xFE4 */
> +	u32 periph_id_2;	/* peripheral ID 2	0xFE8 */
> +	u32 periph_id_3;	/* peripheral ID 3	0xFEC */
> +	u32 cell_id_0;		/* I2C cell   ID 0	0xFF0 */
> +	u32 cell_id_1;		/* I2C cell   ID 1	0xFF4 */
> +	u32 cell_id_2;		/* I2C cell   ID 2	0xFF8 */
> +	u32 cell_id_3;		/* I2C cell   ID 3	0xFFC */
> +};
> +
> +
> +/* Control Register */
> +
> +/* Mask values for control register mask */
> +#define I2C_CR_PE          MASK_BIT0	/* Peripheral enable */
> +#define I2C_CR_OM          0x6		/* Operation mode */
> +#define I2C_CR_SAM         MASK_BIT3	/* Slave Addressing mode */
> +#define I2C_CR_SM          0x30		/* Speed mode */
> +#define I2C_CR_SGCM        MASK_BIT6	/* Slave General call mode */
> +#define I2C_CR_FTX         MASK_BIT7	/* Flush Transmit */
> +#define I2C_CR_FRX         MASK_BIT8	/* Flush Receive */
> +#define I2C_CR_DMA_TX_EN   MASK_BIT9	/* DMA TX Enable */
> +#define I2C_CR_DMA_RX_EN   MASK_BIT10	/* DMA Rx Enable */
> +#define I2C_CR_DMA_SLE     MASK_BIT11	/* DMA Synchronization Logic enable */
> +#define I2C_CR_LM          MASK_BIT12	/* Loop back mode */
> +#define I2C_CR_FON         0x6000	/* Filtering On */
> +
> +/* shift valus for control register bit fields */
> +#define I2C_CR_SHIFT_PE		0	/* Peripheral enable */
> +#define I2C_CR_SHIFT_OM		1	/* Operation mode */
> +#define I2C_CR_SHIFT_SAM	3	/* Slave Addressing mode */
> +#define I2C_CR_SHIFT_SM		4	/* Speed mode */
> +#define I2C_CR_SHIFT_SGCM	6	/* Slave General call mode */
> +#define I2C_CR_SHIFT_FTX	7	/* Flush Transmit */
> +#define I2C_CR_SHIFT_FRX	8	/* Flush Receive */
> +#define I2C_CR_SHIFT_DMA_TX_EN	9	/* DMA TX Enable */
> +#define I2C_CR_SHIFT_DMA_RX_EN	10	/* DMA Rx Enable */
> +#define I2C_CR_SHIFT_DMA_SLE	11	/* DMA Synch Logic enable */
> +#define I2C_CR_SHIFT_LM		12	/* Loop back mode */
> +#define I2C_CR_SHIFT_FON	13	/* Filtering On */
> +
> +/* bus operation modes */
> +#define I2C_BUS_SLAVE_MODE		0
> +#define I2C_BUS_MASTER_MODE		1
> +#define I2C_BUS_MASTER_SLAVE_MODE	2
> +
> +
> +/* Slave control register*/
> +
> +/* Mask values slave control register */
> +#define I2C_SCR_ADDR                   0x3FF
> +#define I2C_SCR_DATA_SETUP_TIME        0xFFFF0000
> +
> +/* Shift values for Slave control register */
> +#define I2C_SCR_SHIFT_ADDR               0
> +#define I2C_SCR_SHIFT_DATA_SETUP_TIME    16
> +
> +
> +/* Master Control Register */
> +
> +/* Mask values for Master control register */
> +#define I2C_MCR_OP	MASK_BIT0	/* Operation */
> +#define I2C_MCR_A7	0xFE		/* LSB bits of the Address(7-bit ) */
> +#define I2C_MCR_EA10	0x700		/* Extended Address */
> +#define I2C_MCR_SB	MASK_BIT11	/* Start byte procedure */
> +#define I2C_MCR_AM	0x3000		/* Address type */
> +#define I2C_MCR_STOP	MASK_BIT14	/* stop condition */
> +#define I2C_MCR_LENGTH	0x3FF8000	/* Frame length */
> +#define I2C_MCR_A10	0x7FE		/* Define to set the 10 bit address */
> +/* mask for length field,stop and operation  */
> +#define I2C_MCR_LENGTH_STOP_OP	0x3FFC001
> +
> +/* Shift values for Master control values */
> +#define I2C_MCR_SHIFT_OP	0	/* Operation */
> +#define I2C_MCR_SHIFT_A7	1	/* LSB bits of the Address(7-bit ) */
> +#define I2C_MCR_SHIFT_EA10	8	/* Extended Address */
> +#define I2C_MCR_SHIFT_SB	11	/* Start byte procedure */
> +#define I2C_MCR_SHIFT_AM	12	/* Address type */
> +#define I2C_MCR_SHIFT_STOP	14	/* stop condition */
> +#define I2C_MCR_SHIFT_LENGTH	15	/* Frame length */
> +#define I2C_MCR_SHIFT_A10	1	/* define to set the 10 bit addres */
> +
> +#define I2C_MCR_SHIFT_LENGTH_STOP_OP	0
> +
> +
> +/* Status Register */
> +
> +/* Mask values for Status register */
> +#define I2C_SR_OP		0x3	/* Operation */
> +#define I2C_SR_STATUS		0xC	/* Controller Status */
> +#define I2C_SR_CAUSE		0x70	/* Abort Cause */
> +#define I2C_SR_TYPE		0x180	/* Receive Type */
> +#define I2C_SR_LENGTH		0xFF700	/* Transfer length */
> +
> +/* Shift values for Status register */
> +#define I2C_SR_SHIFT_OP		0	/* Operation */
> +#define I2C_SR_SHIFT_STATUS	2	/* Controller Status */
> +#define I2C_SR_SHIFT_CAUSE	4	/* Abort Cause */
> +#define I2C_SR_SHIFT_TYPE	7	/* Receive Type */
> +#define I2C_SR_SHIFT_LENGTH	9	/* Transfer length */
> +
> +/* abort cause */
> +#define	I2C_NACK_ADDR	0
> +#define	I2C_NACK_DATA	1
> +#define	I2C_ACK_MCODE	2
> +#define	I2C_ARB_LOST	3
> +#define	I2C_BERR_START	4
> +#define	I2C_BERR_STOP	5
> +#define	I2C_OVFL	6
> +
> +
> +/* Baud rate counter registers */
> +
> +/* Mask values for Baud rate counter register */
> +#define I2C_BRCR_BRCNT2	0xFFFF		/* Baud Rate Counter for HS mode */
> +#define I2C_BRCR_BRCNT1	0xFFFF0000	/* counter for Standard and Fast mode */
> +
> +/* Shift values for the Baud rate counter register */
> +#define I2C_BRCR_SHIFT_BRCNT2	0
> +#define I2C_BRCR_SHIFT_BRCNT1	16
> +
> +
> +/* Interrupt Register  */
> +
> +/* Mask values for Interrupt registers */
> +#define I2C_INT_TXFE	MASK_BIT0	/* Tx fifo empty */
> +#define I2C_INT_TXFNE	MASK_BIT1	/* Tx Fifo nearly empty */
> +#define I2C_INT_TXFF	MASK_BIT2	/* Tx Fifo Full */
> +#define I2C_INT_TXFOVR	MASK_BIT3	/* Tx Fifo over run */
> +#define I2C_INT_RXFE	MASK_BIT4	/* Rx Fifo Empty */
> +#define I2C_INT_RXFNF	MASK_BIT5	/* Rx Fifo nearly empty */
> +#define I2C_INT_RXFF	MASK_BIT6	/* Rx Fifo Full  */
> +#define I2C_INT_RFSR	MASK_BIT16	/* Read From slave request */
> +#define I2C_INT_RFSE	MASK_BIT17	/* Read from slave empty */
> +#define I2C_INT_WTSR	MASK_BIT18	/* Write to Slave request */
> +#define I2C_INT_MTD	MASK_BIT19	/* Master Transcation Done*/
> +#define I2C_INT_STD	MASK_BIT20	/* Slave Transaction Done */
> +#define I2C_INT_MAL	MASK_BIT24	/* Master Arbitation Lost */
> +#define I2C_INT_BERR	MASK_BIT25	/* Bus Error */
> +#define I2C_INT_MTDWS	MASK_BIT28	/* Master Transaction Done wo/ Stop */
> +
> +/* Shift values for Interrupt registers */
> +#define I2C_INT_SHIFT_TXFE	0	/* Tx fifo empty */
> +#define I2C_INT_SHIFT_TXFNE	1	/* Tx Fifo nearly empty */
> +#define I2C_INT_SHIFT_TXFF	2	/* Tx Fifo Full */
> +#define I2C_INT_SHIFT_TXFOVR	3	/* Tx Fifo over run */
> +#define I2C_INT_SHIFT_RXFE	4	/* Rx Fifo Empty */
> +#define I2C_INT_SHIFT_RXFNF	5	/* Rx Fifo nearly empty */
> +#define I2C_INT_SHIFT_RXFF	6	/* Rx Fifo Full  */
> +#define I2C_INT_SHIFT_RFSR	16	/* Read From slave request */
> +#define I2C_INT_SHIFT_RFSE	17	/* Read from slave empty */
> +#define I2C_INT_SHIFT_WTSR	18	/* Write to Slave request */
> +#define I2C_INT_SHIFT_MTD	19	/* Master Transcation Done */
> +#define I2C_INT_SHIFT_STD	20	/* Slave Transaction Done */
> +#define I2C_INT_SHIFT_MAL	24	/* Master Arbitation Lost */
> +#define I2C_INT_SHIFT_BERR	25	/* Bus Error */
> +#define I2C_INT_SHIFT_MTDWS	28	/* Master Transcation Done wo/ Stop */
> +
> +
> +/* Misc defines */
> +#define I2C_MAX_STANDARD_SCL	100000	/* Max clock (Hz) for Standard Mode */
> +#define I2C_MAX_FAST_SCL	400000	/* Max clock (Hz) for Fast Mode */
> +#define I2C_MAX_HIGH_SPEED_SCL	3400000	/* Max clock (Hz) for HS Mode */
> +
> +#endif	/* _U8500_I2C_H_ */

Hmm... all your defines use "general" names, there is no "U8500" or
"ST" or something in it. How about prefixing the macros in this file
as U8500_I2C or ST_I2C instead of I2C?

bye,
Heiko

Patch

diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
index 052fe36..ac9c00f 100644
--- a/drivers/i2c/Makefile
+++ b/drivers/i2c/Makefile
@@ -40,6 +40,7 @@  COBJS-$(CONFIG_S3C44B0_I2C) += s3c44b0_i2c.o
 COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o
 COBJS-$(CONFIG_SPEAR_I2C) += spr_i2c.o
 COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.o
+COBJS-$(CONFIG_DRIVER_U8500_I2C) += u8500_i2c.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
diff --git a/drivers/i2c/u8500_i2c.c b/drivers/i2c/u8500_i2c.c
new file mode 100644
index 0000000..8965100
--- /dev/null
+++ b/drivers/i2c/u8500_i2c.c
@@ -0,0 +1,603 @@ 
+/*
+ * Copyright (C) ST-Ericsson SA 2010
+ *
+ * Basic U-Boot I2C interface for STn8500/DB8500
+ * Author: Michael Brandt <Michael.Brandt@stericsson.com> for ST-Ericsson
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+/*
+ * Only 7-bit I2C device addresses are supported.
+ */
+
+#include <common.h>
+#include <i2c.h>
+
+#include "u8500_i2c.h"
+#include <asm/io.h>
+#include <asm/arch/common.h>
+#include <asm/arch/clock.h>
+
+#define I2C_ENDAD_COUNTER	(CONFIG_SYS_HZ/100)	/* I2C bus timeout */
+#define I2C_FIFO_FLUSH_COUNTER	500000		/* flush "timeout" */
+#define I2C_SCL_FREQ		100000		/* I2C bus clock frequency.*/
+#define I2C_INPUT_FREQ		48000000	/* Input clock frequency.*/
+#define TX_FIFO_THRESHOLD	0x4
+#define RX_FIFO_THRESHOLD	0x4
+#define SLAVE_SETUP_TIME 14 /* Slave data setup time, 250ns for 48MHz i2c_clk */
+
+#define WRITE_FIELD(var, mask, shift, value) \
+			(var = ((var & ~(mask)) | ((value) << (shift))))
+
+static unsigned int bus_initialized[CONFIG_SYS_I2C_BUS_MAX];
+static unsigned int i2c_bus_num;
+static unsigned int i2c_bus_speed[] = {
+	CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SPEED,
+	CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SPEED
+};
+static struct u8500_i2c_regs *i2c_dev[] = {
+	(struct u8500_i2c_regs *)CONFIG_SYS_I2C0_BASE,
+	(struct u8500_i2c_regs *)CONFIG_SYS_I2C1_BASE,
+	(struct u8500_i2c_regs *)CONFIG_SYS_I2C2_BASE,
+	(struct u8500_i2c_regs *)CONFIG_SYS_I2C3_BASE,
+};
+
+static struct {
+	int periph;
+	int pcken;
+	int kcken;
+} i2c_clock_bits[] = {
+	{3, 3, 3}, /* I2C0 */
+	{1, 2, 2}, /* I2C1 */
+	{1, 6, 6}, /* I2C2 */
+	{2, 0, 0}, /* I2C3 */
+};
+
+static void i2c_set_bit(void *reg, u32 mask)
+{
+	writel(readl(reg) | mask, reg);
+}
+
+static void i2c_clr_bit(void *reg, u32 mask)
+{
+	writel(readl(reg) & ~mask, reg);
+}
+
+static void i2c_write_field(void *reg, u32 mask, uint shift, u32 value)
+{
+	writel((readl(reg) & ~mask) | (value << shift), reg);
+}
+
+static int __i2c_set_bus_speed(unsigned int speed)
+{
+	u32 value;
+	struct u8500_i2c_regs *i2c_regs;
+
+	i2c_regs = i2c_dev[i2c_bus_num];
+
+	/* Select standard (100 kbps) speed mode */
+	i2c_write_field(&i2c_regs->cr, I2C_CR_SM, I2C_CR_SHIFT_SM, 0x0);
+
+	/*
+	 * Set the Baud Rate Counter 2 value
+	 * Baud rate (standard) = fi2cclk / ( (BRCNT2 x 2) + Foncycle )
+	 * Foncycle = 0 (no digital filtering)
+	 */
+	value = (u32) (I2C_INPUT_FREQ / (speed * 2));
+	i2c_write_field(&i2c_regs->brcr, I2C_BRCR_BRCNT2,
+			I2C_BRCR_SHIFT_BRCNT2, value);
+
+	/* ensure that BRCNT value is zero */
+	i2c_write_field(&i2c_regs->brcr, I2C_BRCR_BRCNT1,
+			I2C_BRCR_SHIFT_BRCNT1, 0);
+
+	return I2C_INPUT_FREQ/(value * 2);
+}
+
+/*
+ * i2c_init - initialize the i2c bus
+ *
+ *	speed: bus speed (in HZ)
+ *	slaveaddr: address of device in slave mode
+ *
+ *	Slave mode is not implemented.
+ */
+void i2c_init(int speed, int slaveaddr)
+{
+	struct u8500_i2c_regs *i2c_regs;
+
+	debug("i2c_init bus %d, speed %d\n", i2c_bus_num, speed);
+
+	u8500_clock_enable(i2c_clock_bits[i2c_bus_num].periph,
+			   i2c_clock_bits[i2c_bus_num].pcken,
+			   i2c_clock_bits[i2c_bus_num].kcken);
+
+	i2c_regs = i2c_dev[i2c_bus_num];
+
+	/* Disable the controller */
+	i2c_clr_bit(&i2c_regs->cr, I2C_CR_PE);
+
+	/* Clear registers */
+	writel(0, &i2c_regs->cr);
+	writel(0, &i2c_regs->scr);
+	writel(0, &i2c_regs->hsmcr);
+	writel(0, &i2c_regs->tftr);
+	writel(0, &i2c_regs->rftr);
+	writel(0, &i2c_regs->dmar);
+
+	i2c_bus_speed[i2c_bus_num] = __i2c_set_bus_speed(speed);
+
+	/*
+	 * Set our own address.
+	 * Set slave address mode to 7 bit addressing mode
+	 */
+	i2c_clr_bit(&i2c_regs->cr, I2C_CR_SAM);
+	i2c_write_field(&i2c_regs->scr, I2C_SCR_ADDR, I2C_SCR_SHIFT_ADDR,
+			slaveaddr);
+	/* Slave Data Set up Time */
+	i2c_write_field(&i2c_regs->scr, I2C_SCR_DATA_SETUP_TIME,
+			I2C_SCR_SHIFT_DATA_SETUP_TIME, SLAVE_SETUP_TIME);
+
+	/* Disable the DMA sync logic */
+	i2c_write_field(&i2c_regs->cr, I2C_CR_DMA_SLE,
+			I2C_CR_SHIFT_DMA_SLE, 0);
+
+	/* Disable interrupts */
+	writel(0, &i2c_regs->imscr);
+
+	/* Configure bus master mode */
+	i2c_write_field(&i2c_regs->cr, I2C_CR_OM, I2C_CR_SHIFT_OM,
+							I2C_BUS_MASTER_MODE);
+	/* Set FIFO threshold values */
+	writel(TX_FIFO_THRESHOLD, &i2c_regs->tftr);
+	writel(RX_FIFO_THRESHOLD, &i2c_regs->rftr);
+
+	/* Enable the I2C Controller */
+	i2c_set_bit(&i2c_regs->cr, I2C_CR_PE);
+
+	bus_initialized[i2c_bus_num] = 1;
+}
+
+
+/*
+ * loop_till_bit_clear - polls on a bit till it clears
+ * ioreg: register where you want to check status
+ * mask: bit mask for the bit you wish to check
+ * timeout: timeout in ticks/s
+ */
+static int loop_till_bit_clear(void *io_reg, u32 mask, unsigned long timeout)
+{
+	unsigned long timebase = get_timer(0);
+
+	do {
+		if ((readl(io_reg) & mask) == 0x0UL)
+			return 0;
+	} while (get_timer(timebase) < timeout);
+
+	debug("loop_till_bit_clear timed out\n");
+	return -1;
+}
+
+/*
+ * loop_till_bit_set - polls on a bit till it is set.
+ * ioreg: register where you want to check status
+ * mask: bit mask for the bit you wish to check
+ * timeout: timeout in ticks/s
+ */
+static int loop_till_bit_set(void *io_reg, u32 mask, unsigned long timeout)
+{
+	unsigned long timebase = get_timer(0);
+
+	do {
+		if ((readl(io_reg) & mask) != 0x0UL)
+			return 0;
+	} while (get_timer(timebase) < timeout);
+
+	debug("loop_till_bit_set timed out\n");
+	return -1;
+}
+
+/*
+ * flush_fifo - flush the I2C TX and RX FIFOs
+ */
+static void flush_fifo(struct u8500_i2c_regs *i2c_regs)
+{
+	int counter = I2C_FIFO_FLUSH_COUNTER;
+
+	/* Flush Tx FIFO */
+	i2c_set_bit(&i2c_regs->cr, I2C_CR_FTX);
+	/* Flush Rx FIFO */
+	i2c_set_bit(&i2c_regs->cr, I2C_CR_FRX);
+	while (counter--) {
+		if (!(readl(&i2c_regs->cr) & (I2C_CR_FTX | I2C_CR_FRX)))
+			break;
+	}
+	return;
+}
+
+#ifdef DEBUG
+static void print_abort_reason(struct u8500_i2c_regs *i2c_regs)
+{
+	int cause;
+
+	printf("abort: risr %08x, sr %08x\n", i2c_regs->risr, i2c_regs->sr);
+	cause = (readl(&i2c_regs->sr) & I2C_SR_CAUSE) >> I2C_SR_SHIFT_CAUSE;
+	switch (cause) {
+	case I2C_NACK_ADDR:
+		printf("No Ack received after Slave Address xmission\n");
+		break;
+	case I2C_NACK_DATA:
+		printf("Valid for MASTER_WRITE: No Ack received "
+				"during data phase\n");
+		break;
+	case I2C_ACK_MCODE:
+		printf("Master recv ack after xmission of master code"
+				"in hs mode\n");
+		break;
+	case I2C_ARB_LOST:
+		printf("Master Lost arbitration\n");
+		break;
+	case I2C_BERR_START:
+		printf("Slave restarts\n");
+		break;
+	case I2C_BERR_STOP:
+		printf("Slave reset\n");
+		break;
+	case I2C_OVFL:
+		printf("Overflow\n");
+		break;
+	default:
+		printf("Unknown error type\n");
+	}
+}
+#endif
+
+/*
+ * i2c_abort - called when a I2C transaction failed
+ */
+static void i2c_abort(struct u8500_i2c_regs *i2c_regs)
+{
+#ifdef DEBUG
+	print_abort_reason(i2c_regs);
+#endif
+	/* flush RX and TX fifos */
+	flush_fifo(i2c_regs);
+
+	/* Acknowledge the Master Transaction Done */
+	i2c_set_bit(&i2c_regs->icr, I2C_INT_MTD);
+
+	/* Acknowledge the Master Transaction Done Without Stop */
+	i2c_set_bit(&i2c_regs->icr, I2C_INT_MTDWS);
+
+	i2c_init(i2c_bus_speed[i2c_bus_num], CONFIG_SYS_I2C_SLAVE);
+}
+
+/*
+ * write addr, alias index, to I2C bus.
+ */
+static int i2c_write_addr(struct u8500_i2c_regs *i2c_regs, uint addr, int alen)
+{
+	while (alen--) {
+		/* Wait until the Tx Fifo is not full */
+		if (loop_till_bit_clear((void *)&i2c_regs->risr,
+					I2C_INT_TXFF, I2C_ENDAD_COUNTER)) {
+			i2c_abort(i2c_regs);
+			return -1;
+		}
+
+		/* MSB first */
+		writeb((addr >> (alen * 8)) & 0xff, &i2c_regs->tfr);
+	}
+
+	return 0;
+}
+
+/*
+ * Internal simplified read function:
+ *   i2c_regs:	Pointer to I2C registers for current bus
+ *   chip:	I2C chip address, range 0..127
+ *   addr:	Memory (register) address within the chip
+ *   alen:	Number of bytes to use for addr (typically 1, 2 for larger
+ *		memories, 0 for register type devices with only one register)
+ *   value:	Where to put the data
+ *
+ *   Returns:	0 on success, not 0 on failure
+ */
+static int i2c_read_byte(struct u8500_i2c_regs *i2c_regs, uchar chip,
+		uint addr, int alen, uchar *value)
+{
+	u32   mcr = 0;
+
+	/* Set the address mode to 7 bit */
+	WRITE_FIELD(mcr, I2C_MCR_AM, I2C_MCR_SHIFT_AM, 1);
+
+	/* Store the slave address in the master control register */
+	WRITE_FIELD(mcr, I2C_MCR_A7, I2C_MCR_SHIFT_A7, chip);
+
+	if (alen != 0) {
+		/* Master write operation */
+		mcr &= ~(I2C_MCR_OP);
+
+		/* Configure the Frame length to one byte */
+		WRITE_FIELD(mcr, I2C_MCR_LENGTH, I2C_MCR_SHIFT_LENGTH, 1);
+
+		/* Repeated start, no stop */
+		mcr &= ~(I2C_MCR_STOP);
+
+		/* Write Master Control Register */
+		writel(mcr, &i2c_regs->mcr);
+
+		/* send addr/index */
+		if (i2c_write_addr(i2c_regs, addr, alen) != 0)
+			return -1;
+
+		/* Check for the Master Transaction Done Without Stop */
+		if (loop_till_bit_set((void *)&i2c_regs->risr,
+					I2C_INT_MTDWS, I2C_ENDAD_COUNTER)) {
+			return -1;
+		}
+
+		/* Acknowledge the Master Transaction Done Without Stop */
+		i2c_set_bit(&i2c_regs->icr, I2C_INT_MTDWS);
+	}
+
+	/* Master control configuration for read operation  */
+	mcr |= I2C_MCR_OP;
+
+	/* Configure the STOP condition, we read only one byte */
+	mcr |= I2C_MCR_STOP;
+
+	/* Set the frame length to one byte, we support only 1 byte reads */
+	WRITE_FIELD(mcr, I2C_MCR_LENGTH, I2C_MCR_SHIFT_LENGTH, 1);
+
+	i2c_write_field(&i2c_regs->mcr, I2C_MCR_LENGTH_STOP_OP,
+			I2C_MCR_SHIFT_LENGTH_STOP_OP, mcr);
+
+	/*
+	 * receive_data_polling
+	 */
+
+	/* Wait until the Rx FIFO is not empty */
+	if (loop_till_bit_clear((void *)&i2c_regs->risr, I2C_INT_RXFE,
+			I2C_ENDAD_COUNTER))
+		return -1;
+
+	/* Read the data byte from Rx FIFO */
+	*value = readb(&i2c_regs->rfr);
+
+	/* Wait until the work is done */
+	if (loop_till_bit_set((void *)&i2c_regs->risr, I2C_INT_MTD,
+				I2C_ENDAD_COUNTER))
+		return -1;
+
+	/* Acknowledge the Master Transaction Done */
+	i2c_set_bit(&i2c_regs->icr, I2C_INT_MTD);
+
+	/* If MTD is set, Master Transaction Done Without Stop is set too */
+	i2c_set_bit(&i2c_regs->icr, I2C_INT_MTDWS);
+
+	return 0;
+}
+
+/*
+ * Internal simplified write function:
+ *   i2c_regs:	Pointer to I2C registers for current bus
+ *   chip:	I2C chip address, range 0..127
+ *   addr:	Memory (register) address within the chip
+ *   alen:	Number of bytes to use for addr (typically 1, 2 for larger
+ *		memories, 0 for register type devices with only one register)
+ *   data:	Where to read the data
+ *   len:	How many bytes to write
+ *
+ *   Returns:	0 on success, not 0 on failure
+ */
+static int __i2c_write(struct u8500_i2c_regs *i2c_regs, u8 chip, uint addr,
+		int alen, u8 *data, int len)
+{
+	int i;
+	u32 mcr = 0;
+
+	/* Set the address mode to 7 bit */
+	WRITE_FIELD(mcr, I2C_MCR_AM, I2C_MCR_SHIFT_AM, 1);
+
+	/* Store the slave address in the master control register */
+	WRITE_FIELD(mcr, I2C_MCR_A7, I2C_MCR_SHIFT_A7, chip);
+
+	/* Write operation */
+	mcr &= ~(I2C_MCR_OP);
+
+	/* Current transaction is terminated by STOP condition */
+	mcr |= I2C_MCR_STOP;
+
+	/* Frame length: addr byte + len */
+	WRITE_FIELD(mcr, I2C_MCR_LENGTH, I2C_MCR_SHIFT_LENGTH, (alen + len));
+
+	/* Write MCR register */
+	writel(mcr, &i2c_regs->mcr);
+
+	if (i2c_write_addr(i2c_regs, addr, alen) != 0)
+		return -1;
+
+	for (i = 0; i < len; i++) {
+		/* Wait until the Tx FIFO is not full */
+		if (loop_till_bit_clear((void *)&i2c_regs->risr,
+					I2C_INT_TXFF, I2C_ENDAD_COUNTER))
+			return -1;
+
+		/* it is a 32 bit register with upper 24 reserved R/O */
+		writeb(data[i], &i2c_regs->tfr);
+	}
+
+	/* Check for Master Transaction Done */
+	if (loop_till_bit_set((void *)&i2c_regs->risr, I2C_INT_MTD,
+				I2C_ENDAD_COUNTER)) {
+		printf("i2c_write_byte error2: risr %08x\n",
+				i2c_regs->risr);
+		return -1;
+	}
+
+	/* Acknowledge Master Transaction Done */
+	i2c_set_bit(&i2c_regs->icr, I2C_INT_MTD);
+
+	/* Acknowledge Master Transaction Done Without Stop */
+	i2c_set_bit(&i2c_regs->icr, I2C_INT_MTDWS);
+
+	return 0;
+}
+
+/*
+ * Probe the given I2C chip address. Returns 0 if a chip responded,
+ * not 0 on failure.
+ */
+int i2c_probe(uchar chip)
+{
+	u32 mcr = 0;
+	struct u8500_i2c_regs *i2c_regs;
+
+	if (chip == CONFIG_SYS_I2C_SLAVE)
+		return 1;
+
+	i2c_regs = i2c_dev[i2c_bus_num];
+
+	/* Set the address mode to 7 bit */
+	WRITE_FIELD(mcr, I2C_MCR_AM, I2C_MCR_SHIFT_AM, 1);
+
+	/* Store the slave address in the master control register */
+	WRITE_FIELD(mcr, I2C_MCR_A10, I2C_MCR_SHIFT_A7, chip);
+
+	/* Read operation */
+	mcr |= I2C_MCR_OP;
+
+	/* Set the frame length to one byte */
+	WRITE_FIELD(mcr, I2C_MCR_LENGTH, I2C_MCR_SHIFT_LENGTH, 1);
+
+	/* Current transaction is terminated by STOP condition */
+	mcr |= I2C_MCR_STOP;
+
+	/* Write MCR register */
+	writel(mcr, &i2c_regs->mcr);
+
+	/* Wait until the Rx Fifo is not empty */
+	if (loop_till_bit_clear((void *)&i2c_regs->risr, I2C_INT_RXFE,
+			I2C_ENDAD_COUNTER)) {
+		i2c_abort(i2c_regs);
+		return -1;
+	}
+
+	flush_fifo(i2c_regs);
+
+	/* Acknowledge the Master Transaction Done */
+	i2c_set_bit(&i2c_regs->icr, I2C_INT_MTD);
+
+	/* Acknowledge the Master Transaction Done Without Stop */
+	i2c_set_bit(&i2c_regs->icr, I2C_INT_MTDWS);
+
+	return 0;
+}
+
+/*
+ * Read/Write interface:
+ *   chip:    I2C chip address, range 0..127
+ *   addr:    Memory (register) address within the chip
+ *   alen:    Number of bytes to use for addr (typically 1, 2 for larger
+ *              memories, 0 for register type devices with only one
+ *              register)
+ *   buffer:  Where to read/write the data
+ *   len:     How many bytes to read/write
+ *
+ *   Returns: 0 on success, not 0 on failure
+ */
+int i2c_read(uchar chip, uint addr, int alen, uchar *buffer, int len)
+{
+	int i;
+	int rc;
+	struct u8500_i2c_regs *i2c_regs;
+
+	if (alen > 2) {
+		debug("I2C read: addr len %d not supported\n", alen);
+		return 1;
+	}
+
+	i2c_regs = i2c_dev[i2c_bus_num];
+
+	for (i = 0; i < len; i++) {
+		rc = i2c_read_byte(i2c_regs, chip, addr + i, alen, &buffer[i]);
+		if (rc != 0) {
+			debug("I2C read: I/O error: %d\n", rc);
+			i2c_abort(i2c_regs);
+			return rc;
+		}
+	}
+
+	return 0;
+}
+
+int i2c_write(uchar chip, uint addr, int alen, uchar *buffer, int len)
+{
+	int rc;
+	struct u8500_i2c_regs *i2c_regs;
+	i2c_regs = i2c_dev[i2c_bus_num];
+
+	rc = __i2c_write(i2c_regs, chip, addr, alen, buffer,
+			len);
+	if (rc != 0) {
+		debug("I2C write: I/O error\n");
+		i2c_abort(i2c_regs);
+		return rc;
+	}
+	return 0;
+}
+
+int i2c_set_bus_num(unsigned int bus)
+{
+	if (bus > ARRAY_SIZE(i2c_dev) - 1) {
+		debug("i2c_set_bus_num: only up to bus %d supported\n",
+				ARRAY_SIZE(i2c_dev)-1);
+		return -1;
+	}
+
+	i2c_bus_num = bus;
+
+	if (!bus_initialized[i2c_bus_num])
+		i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
+
+	return 0;
+}
+
+int i2c_set_bus_speed(unsigned int speed)
+{
+
+	if (speed > I2C_MAX_STANDARD_SCL) {
+		debug("i2c_set_bus_speed: only up to %d supported\n",
+				I2C_MAX_STANDARD_SCL);
+		return -1;
+	}
+
+	/* sets as side effect i2c_bus_speed[i2c_bus_num] */
+	i2c_init(speed, CONFIG_SYS_I2C_SLAVE);
+
+	return 0;
+}
+
+unsigned int i2c_get_bus_num(void)
+{
+	return i2c_bus_num;
+}
+
+unsigned int i2c_get_bus_speed(void)
+{
+	return i2c_bus_speed[i2c_bus_num];
+}
diff --git a/drivers/i2c/u8500_i2c.h b/drivers/i2c/u8500_i2c.h
new file mode 100644
index 0000000..8ef6667
--- /dev/null
+++ b/drivers/i2c/u8500_i2c.h
@@ -0,0 +1,220 @@ 
+/*
+ * Copyright (C) ST-Ericsson SA 2009
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef _U8500_I2C_H_
+#define _U8500_I2C_H_
+
+#include <asm/types.h>
+#include <asm/io.h>
+#include <asm/errno.h>
+
+//#include "common.h"
+#include <asm/arch/u8500.h>
+
+/* Generic macros */
+
+#define I2C_WRITE_FIELD(reg_name, mask, shift, value) \
+		(reg_name = ((reg_name & ~mask) | (value << shift)))
+#define I2C_READ_FIELD(reg_name, mask, shift)    ((reg_name & mask) >> shift)
+
+struct u8500_i2c_regs {
+	u32 cr;			/* Control Register                      0x00 */
+	u32 scr;		/* Slave Address Register                0x04 */
+	u32 hsmcr;		/* HS Master code Register               0x08 */
+	u32 mcr;		/* Master Control Register               0x0C */
+	u32 tfr;		/* Transmit Fifo Register                0x10 */
+	u32 sr;			/* Status Register                       0x14 */
+	u32 rfr;		/* Receiver Fifo Register                0x18 */
+	u32 tftr;		/* Transmit Fifo Threshold Register      0x1C */
+	u32 rftr;		/* Receiver Fifo Threshold Register      0x20 */
+	u32 dmar;		/* DMA register                          0x24 */
+	u32 brcr;		/* Baud Rate Counter Register            0x28 */
+	u32 imscr;		/* Interrupt Mask Set and Clear Register 0x2C */
+	u32 risr;		/* Raw interrupt status register         0x30 */
+	u32 misr;		/* Masked interrupt status register      0x34 */
+	u32 icr;		/* Interrupt Set and Clear Register      0x38 */
+	u32 reserved_1[(0xFE0 - 0x3c) >> 2];	/* Reserved 0x03C to 0xFE0 */
+	u32 periph_id_0;	/* peripheral ID 0	0xFE0 */
+	u32 periph_id_1;	/* peripheral ID 1	0xFE4 */
+	u32 periph_id_2;	/* peripheral ID 2	0xFE8 */
+	u32 periph_id_3;	/* peripheral ID 3	0xFEC */
+	u32 cell_id_0;		/* I2C cell   ID 0	0xFF0 */
+	u32 cell_id_1;		/* I2C cell   ID 1	0xFF4 */
+	u32 cell_id_2;		/* I2C cell   ID 2	0xFF8 */
+	u32 cell_id_3;		/* I2C cell   ID 3	0xFFC */
+};
+
+
+/* Control Register */
+
+/* Mask values for control register mask */
+#define I2C_CR_PE          MASK_BIT0	/* Peripheral enable */
+#define I2C_CR_OM          0x6		/* Operation mode */
+#define I2C_CR_SAM         MASK_BIT3	/* Slave Addressing mode */
+#define I2C_CR_SM          0x30		/* Speed mode */
+#define I2C_CR_SGCM        MASK_BIT6	/* Slave General call mode */
+#define I2C_CR_FTX         MASK_BIT7	/* Flush Transmit */
+#define I2C_CR_FRX         MASK_BIT8	/* Flush Receive */
+#define I2C_CR_DMA_TX_EN   MASK_BIT9	/* DMA TX Enable */
+#define I2C_CR_DMA_RX_EN   MASK_BIT10	/* DMA Rx Enable */
+#define I2C_CR_DMA_SLE     MASK_BIT11	/* DMA Synchronization Logic enable */
+#define I2C_CR_LM          MASK_BIT12	/* Loop back mode */
+#define I2C_CR_FON         0x6000	/* Filtering On */
+
+/* shift valus for control register bit fields */
+#define I2C_CR_SHIFT_PE		0	/* Peripheral enable */
+#define I2C_CR_SHIFT_OM		1	/* Operation mode */
+#define I2C_CR_SHIFT_SAM	3	/* Slave Addressing mode */
+#define I2C_CR_SHIFT_SM		4	/* Speed mode */
+#define I2C_CR_SHIFT_SGCM	6	/* Slave General call mode */
+#define I2C_CR_SHIFT_FTX	7	/* Flush Transmit */
+#define I2C_CR_SHIFT_FRX	8	/* Flush Receive */
+#define I2C_CR_SHIFT_DMA_TX_EN	9	/* DMA TX Enable */
+#define I2C_CR_SHIFT_DMA_RX_EN	10	/* DMA Rx Enable */
+#define I2C_CR_SHIFT_DMA_SLE	11	/* DMA Synch Logic enable */
+#define I2C_CR_SHIFT_LM		12	/* Loop back mode */
+#define I2C_CR_SHIFT_FON	13	/* Filtering On */
+
+/* bus operation modes */
+#define I2C_BUS_SLAVE_MODE		0
+#define I2C_BUS_MASTER_MODE		1
+#define I2C_BUS_MASTER_SLAVE_MODE	2
+
+
+/* Slave control register*/
+
+/* Mask values slave control register */
+#define I2C_SCR_ADDR                   0x3FF
+#define I2C_SCR_DATA_SETUP_TIME        0xFFFF0000
+
+/* Shift values for Slave control register */
+#define I2C_SCR_SHIFT_ADDR               0
+#define I2C_SCR_SHIFT_DATA_SETUP_TIME    16
+
+
+/* Master Control Register */
+
+/* Mask values for Master control register */
+#define I2C_MCR_OP	MASK_BIT0	/* Operation */
+#define I2C_MCR_A7	0xFE		/* LSB bits of the Address(7-bit ) */
+#define I2C_MCR_EA10	0x700		/* Extended Address */
+#define I2C_MCR_SB	MASK_BIT11	/* Start byte procedure */
+#define I2C_MCR_AM	0x3000		/* Address type */
+#define I2C_MCR_STOP	MASK_BIT14	/* stop condition */
+#define I2C_MCR_LENGTH	0x3FF8000	/* Frame length */
+#define I2C_MCR_A10	0x7FE		/* Define to set the 10 bit address */
+/* mask for length field,stop and operation  */
+#define I2C_MCR_LENGTH_STOP_OP	0x3FFC001
+
+/* Shift values for Master control values */
+#define I2C_MCR_SHIFT_OP	0	/* Operation */
+#define I2C_MCR_SHIFT_A7	1	/* LSB bits of the Address(7-bit ) */
+#define I2C_MCR_SHIFT_EA10	8	/* Extended Address */
+#define I2C_MCR_SHIFT_SB	11	/* Start byte procedure */
+#define I2C_MCR_SHIFT_AM	12	/* Address type */
+#define I2C_MCR_SHIFT_STOP	14	/* stop condition */
+#define I2C_MCR_SHIFT_LENGTH	15	/* Frame length */
+#define I2C_MCR_SHIFT_A10	1	/* define to set the 10 bit addres */
+
+#define I2C_MCR_SHIFT_LENGTH_STOP_OP	0
+
+
+/* Status Register */
+
+/* Mask values for Status register */
+#define I2C_SR_OP		0x3	/* Operation */
+#define I2C_SR_STATUS		0xC	/* Controller Status */
+#define I2C_SR_CAUSE		0x70	/* Abort Cause */
+#define I2C_SR_TYPE		0x180	/* Receive Type */
+#define I2C_SR_LENGTH		0xFF700	/* Transfer length */
+
+/* Shift values for Status register */
+#define I2C_SR_SHIFT_OP		0	/* Operation */
+#define I2C_SR_SHIFT_STATUS	2	/* Controller Status */
+#define I2C_SR_SHIFT_CAUSE	4	/* Abort Cause */
+#define I2C_SR_SHIFT_TYPE	7	/* Receive Type */
+#define I2C_SR_SHIFT_LENGTH	9	/* Transfer length */
+
+/* abort cause */
+#define	I2C_NACK_ADDR	0
+#define	I2C_NACK_DATA	1
+#define	I2C_ACK_MCODE	2
+#define	I2C_ARB_LOST	3
+#define	I2C_BERR_START	4
+#define	I2C_BERR_STOP	5
+#define	I2C_OVFL	6
+
+
+/* Baud rate counter registers */
+
+/* Mask values for Baud rate counter register */
+#define I2C_BRCR_BRCNT2	0xFFFF		/* Baud Rate Counter for HS mode */
+#define I2C_BRCR_BRCNT1	0xFFFF0000	/* counter for Standard and Fast mode */
+
+/* Shift values for the Baud rate counter register */
+#define I2C_BRCR_SHIFT_BRCNT2	0
+#define I2C_BRCR_SHIFT_BRCNT1	16
+
+
+/* Interrupt Register  */
+
+/* Mask values for Interrupt registers */
+#define I2C_INT_TXFE	MASK_BIT0	/* Tx fifo empty */
+#define I2C_INT_TXFNE	MASK_BIT1	/* Tx Fifo nearly empty */
+#define I2C_INT_TXFF	MASK_BIT2	/* Tx Fifo Full */
+#define I2C_INT_TXFOVR	MASK_BIT3	/* Tx Fifo over run */
+#define I2C_INT_RXFE	MASK_BIT4	/* Rx Fifo Empty */
+#define I2C_INT_RXFNF	MASK_BIT5	/* Rx Fifo nearly empty */
+#define I2C_INT_RXFF	MASK_BIT6	/* Rx Fifo Full  */
+#define I2C_INT_RFSR	MASK_BIT16	/* Read From slave request */
+#define I2C_INT_RFSE	MASK_BIT17	/* Read from slave empty */
+#define I2C_INT_WTSR	MASK_BIT18	/* Write to Slave request */
+#define I2C_INT_MTD	MASK_BIT19	/* Master Transcation Done*/
+#define I2C_INT_STD	MASK_BIT20	/* Slave Transaction Done */
+#define I2C_INT_MAL	MASK_BIT24	/* Master Arbitation Lost */
+#define I2C_INT_BERR	MASK_BIT25	/* Bus Error */
+#define I2C_INT_MTDWS	MASK_BIT28	/* Master Transaction Done wo/ Stop */
+
+/* Shift values for Interrupt registers */
+#define I2C_INT_SHIFT_TXFE	0	/* Tx fifo empty */
+#define I2C_INT_SHIFT_TXFNE	1	/* Tx Fifo nearly empty */
+#define I2C_INT_SHIFT_TXFF	2	/* Tx Fifo Full */
+#define I2C_INT_SHIFT_TXFOVR	3	/* Tx Fifo over run */
+#define I2C_INT_SHIFT_RXFE	4	/* Rx Fifo Empty */
+#define I2C_INT_SHIFT_RXFNF	5	/* Rx Fifo nearly empty */
+#define I2C_INT_SHIFT_RXFF	6	/* Rx Fifo Full  */
+#define I2C_INT_SHIFT_RFSR	16	/* Read From slave request */
+#define I2C_INT_SHIFT_RFSE	17	/* Read from slave empty */
+#define I2C_INT_SHIFT_WTSR	18	/* Write to Slave request */
+#define I2C_INT_SHIFT_MTD	19	/* Master Transcation Done */
+#define I2C_INT_SHIFT_STD	20	/* Slave Transaction Done */
+#define I2C_INT_SHIFT_MAL	24	/* Master Arbitation Lost */
+#define I2C_INT_SHIFT_BERR	25	/* Bus Error */
+#define I2C_INT_SHIFT_MTDWS	28	/* Master Transcation Done wo/ Stop */
+
+
+/* Misc defines */
+#define I2C_MAX_STANDARD_SCL	100000	/* Max clock (Hz) for Standard Mode */
+#define I2C_MAX_FAST_SCL	400000	/* Max clock (Hz) for Fast Mode */
+#define I2C_MAX_HIGH_SPEED_SCL	3400000	/* Max clock (Hz) for HS Mode */
+
+#endif	/* _U8500_I2C_H_ */