diff mbox series

[iproute2] bpf: Print section name when hitting non ld64 issue

Message ID 20180228221642.8524-1-joe@wand.net.nz
State Accepted, archived
Delegated to: stephen hemminger
Headers show
Series [iproute2] bpf: Print section name when hitting non ld64 issue | expand

Commit Message

Joe Stringer Feb. 28, 2018, 10:16 p.m. UTC
It's useful to be able to tell which section is being processed in the
ELF when this error is triggered, so print that detail.

Signed-off-by: Joe Stringer <joe@wand.net.nz>
---
 lib/bpf.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel Borkmann Feb. 28, 2018, 10:19 p.m. UTC | #1
On 02/28/2018 11:16 PM, Joe Stringer wrote:
> It's useful to be able to tell which section is being processed in the
> ELF when this error is triggered, so print that detail.
> 
> Signed-off-by: Joe Stringer <joe@wand.net.nz>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Stephen Hemminger March 2, 2018, 9:32 p.m. UTC | #2
On Wed, 28 Feb 2018 14:16:42 -0800
Joe Stringer <joe@wand.net.nz> wrote:

> It's useful to be able to tell which section is being processed in the
> ELF when this error is triggered, so print that detail.
> 
> Signed-off-by: Joe Stringer <joe@wand.net.nz>

Applied
diff mbox series

Patch

diff --git a/lib/bpf.c b/lib/bpf.c
index 2db151e4dd3c..c38d92d87759 100644
--- a/lib/bpf.c
+++ b/lib/bpf.c
@@ -2039,6 +2039,7 @@  static int bpf_apply_relo_data(struct bpf_elf_ctx *ctx,
 		    insns[ioff].code != (BPF_LD | BPF_IMM | BPF_DW)) {
 			fprintf(stderr, "ELF contains relo data for non ld64 instruction at offset %u! Compiler bug?!\n",
 				ioff);
+			fprintf(stderr, " - Current section: %s\n", data_relo->sec_name);
 			if (ioff < num_insns &&
 			    insns[ioff].code == (BPF_JMP | BPF_CALL))
 				fprintf(stderr, " - Try to annotate functions with always_inline attribute!\n");