diff mbox series

[iproute2] devlink: Fix error reporting

Message ID 1519809862-61464-1-git-send-email-arkadis@mellanox.com
State Accepted, archived
Delegated to: stephen hemminger
Headers show
Series [iproute2] devlink: Fix error reporting | expand

Commit Message

Arkadi Sharshevsky Feb. 28, 2018, 9:24 a.m. UTC 
The current code doesn't set errno in case of extended ack.

Fixes: 049c58539f5d ("devlink: mnlg: Add support for extended ack")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
---
 devlink/mnlg.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Stephen Hemminger March 1, 2018, 12:11 a.m. UTC | #1 
On Wed, 28 Feb 2018 11:24:22 +0200
Arkadi Sharshevsky <arkadis@mellanox.com> wrote:

> The current code doesn't set errno in case of extended ack.
> 
> Fixes: 049c58539f5d ("devlink: mnlg: Add support for extended ack")
> Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/devlink/mnlg.c b/devlink/mnlg.c
index 37c5687..3d28453 100644
--- a/devlink/mnlg.c
+++ b/devlink/mnlg.c
@@ -71,15 +71,15 @@  static int mnlg_cb_error(const struct nlmsghdr *nlh, void *data)
 {
 	const struct nlmsgerr *err = mnl_nlmsg_get_payload(nlh);
 
-	if (nl_dump_ext_ack(nlh, NULL))
-		return MNL_CB_STOP;
-
 	/* Netlink subsystems returns the errno value with different signess */
 	if (err->error < 0)
 		errno = -err->error;
 	else
 		errno = err->error;
 
+	if (nl_dump_ext_ack(nlh, NULL))
+		return MNL_CB_ERROR;
+
 	return err->error == 0 ? MNL_CB_STOP : MNL_CB_ERROR;
 }