fs/ubifs: remove useless parameter of lpt_heap_replace

Message ID 1519784557-105528-1-git-send-email-jiang.biao2@zte.com.cn
State Accepted
Delegated to: Richard Weinberger
Headers show
Series
  • fs/ubifs: remove useless parameter of lpt_heap_replace
Related show

Commit Message

Jiang Biao Feb. 28, 2018, 2:22 a.m.
The parameter *old_lprops* is never used in lpt_heap_replace(),
remove it to avoid compile warning.

Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn>
---
 fs/ubifs/lprops.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Richard Weinberger March 1, 2018, 4:23 p.m. | #1
Am Mittwoch, 28. Februar 2018, 03:22:37 CET schrieb Jiang Biao:
> The parameter *old_lprops* is never used in lpt_heap_replace(),
> remove it to avoid compile warning.

Makes sense. But what compiler warning do you get?

Thanks,
//richard

Patch

diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c
index 6c3a1ab..f5a4684 100644
--- a/fs/ubifs/lprops.c
+++ b/fs/ubifs/lprops.c
@@ -244,7 +244,6 @@  static void remove_from_lpt_heap(struct ubifs_info *c,
 /**
  * lpt_heap_replace - replace lprops in a category heap.
  * @c: UBIFS file-system description object
- * @old_lprops: LEB properties to replace
  * @new_lprops: LEB properties with which to replace
  * @cat: LEB category
  *
@@ -254,7 +253,6 @@  static void remove_from_lpt_heap(struct ubifs_info *c,
  * lprops.  This function does that.
  */
 static void lpt_heap_replace(struct ubifs_info *c,
-			     struct ubifs_lprops *old_lprops,
 			     struct ubifs_lprops *new_lprops, int cat)
 {
 	struct ubifs_lpt_heap *heap;
@@ -362,7 +360,7 @@  void ubifs_replace_cat(struct ubifs_info *c, struct ubifs_lprops *old_lprops,
 	case LPROPS_DIRTY:
 	case LPROPS_DIRTY_IDX:
 	case LPROPS_FREE:
-		lpt_heap_replace(c, old_lprops, new_lprops, cat);
+		lpt_heap_replace(c, new_lprops, cat);
 		break;
 	case LPROPS_UNCAT:
 	case LPROPS_EMPTY: