Message ID | 1519778024-3113-1-git-send-email-tushar.n.dave@oracle.com |
---|---|
State | Changes Requested, archived |
Delegated to: | BPF Maintainers |
Headers | show |
Series | selftests/bpf: Add bpf_probe_read_str to bpf_helpers.h | expand |
Hi Tushar, On 02/28/2018 01:33 AM, Tushar Dave wrote: > Using bpf_probe_read_str() from samples/bpf causes compiler warning. > e.g. > warning: implicit declaration of function 'bpf_probe_read_str' is invalid in C99 > [-Wimplicit-function-declaration] > num = bpf_probe_read_str(buf, sizeof(buf), ctx->di); > ^ > 1 warning generated. > > Add bpf_probe_read_str() to bpf_helpers.h so it can be used by > samples/bpf programs. > > Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com> In general no objections to it, but it would need an in-tree user first: $ git grep -n bpf_probe_read_str tools/ tools/include/uapi/linux/bpf.h:596: * int bpf_probe_read_str(void *dst, int size, const void *unsafe_ptr) $ Why not adding this along with a sample? Thanks, Daniel
On 02/28/2018 08:57 AM, Daniel Borkmann wrote: > Hi Tushar, > > On 02/28/2018 01:33 AM, Tushar Dave wrote: >> Using bpf_probe_read_str() from samples/bpf causes compiler warning. >> e.g. >> warning: implicit declaration of function 'bpf_probe_read_str' is invalid in C99 >> [-Wimplicit-function-declaration] >> num = bpf_probe_read_str(buf, sizeof(buf), ctx->di); >> ^ >> 1 warning generated. >> >> Add bpf_probe_read_str() to bpf_helpers.h so it can be used by >> samples/bpf programs. >> >> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com> > > In general no objections to it, but it would need an in-tree > user first: > > $ git grep -n bpf_probe_read_str tools/ > tools/include/uapi/linux/bpf.h:596: * int bpf_probe_read_str(void *dst, int size, const void *unsafe_ptr) > $ > > Why not adding this along with a sample? Okay, I will send new patch along with new sample or add usage of bpf_probe_read_str() in one of our exiting sample :) Thanks. -Tushar PS: adding correct mail-list this time linux-kselftest@vger.kernel.org > > Thanks, > Daniel >
On 02/28/2018 10:28 PM, Tushar Dave wrote: > On 02/28/2018 08:57 AM, Daniel Borkmann wrote: >> Hi Tushar, >> >> On 02/28/2018 01:33 AM, Tushar Dave wrote: >>> Using bpf_probe_read_str() from samples/bpf causes compiler warning. >>> e.g. >>> warning: implicit declaration of function 'bpf_probe_read_str' is invalid in C99 >>> [-Wimplicit-function-declaration] >>> num = bpf_probe_read_str(buf, sizeof(buf), ctx->di); >>> ^ >>> 1 warning generated. >>> >>> Add bpf_probe_read_str() to bpf_helpers.h so it can be used by >>> samples/bpf programs. >>> >>> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com> >> >> In general no objections to it, but it would need an in-tree >> user first: >> >> $ git grep -n bpf_probe_read_str tools/ >> tools/include/uapi/linux/bpf.h:596: * int bpf_probe_read_str(void *dst, int size, const void *unsafe_ptr) >> $ >> >> Why not adding this along with a sample? > Okay, I will send new patch along with new sample or add usage of > bpf_probe_read_str() in one of our exiting sample :) Sounds great, the latter is totally fine as well. :-) Thanks, Daniel
diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h index dde2c11..65a266d 100644 --- a/tools/testing/selftests/bpf/bpf_helpers.h +++ b/tools/testing/selftests/bpf/bpf_helpers.h @@ -65,6 +65,8 @@ static int (*bpf_xdp_adjust_head)(void *ctx, int offset) = (void *) BPF_FUNC_xdp_adjust_head; static int (*bpf_xdp_adjust_meta)(void *ctx, int offset) = (void *) BPF_FUNC_xdp_adjust_meta; +static int (*bpf_probe_read_str)(void *dst, int size, void *unsafe_ptr) = + (void *) BPF_FUNC_probe_read_str; static int (*bpf_setsockopt)(void *ctx, int level, int optname, void *optval, int optlen) = (void *) BPF_FUNC_setsockopt;
Using bpf_probe_read_str() from samples/bpf causes compiler warning. e.g. warning: implicit declaration of function 'bpf_probe_read_str' is invalid in C99 [-Wimplicit-function-declaration] num = bpf_probe_read_str(buf, sizeof(buf), ctx->di); ^ 1 warning generated. Add bpf_probe_read_str() to bpf_helpers.h so it can be used by samples/bpf programs. Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com> --- tools/testing/selftests/bpf/bpf_helpers.h | 2 ++ 1 file changed, 2 insertions(+)