| Message ID | 20180227205125.8121-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Commit | 17a6404faf50f2886f0cace4cd91f921f118430e |
| Headers | show |
| Series | [1/1] azmq: bump to version 1.0.2 | expand |
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > Add license hash > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Does this fix any big / security issues so it needs to go to master or is this for next?
Dear Peter, 2018-02-27 22:03 GMT+01:00 Peter Korsgaard <peter@korsgaard.com>: > >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > > > Add license hash > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > Does this fix any big / security issues so it needs to go to master or > is this for next? > There is no big / security issues, this is for next. > > -- > Bye, Peter Korsgaard > Best Regards, Fabrice <div dir="ltr">Dear Peter,<br><div class="gmail_extra"><br><div class="gmail_quote">2018-02-27 22:03 GMT+01:00 Peter Korsgaard <span dir="ltr"><<a href="mailto:peter@korsgaard.com" target="_blank">peter@korsgaard.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>>>>>> "Fabrice" == Fabrice Fontaine <<a href="mailto:fontaine.fabrice@gmail.com" target="_blank">fontaine.fabrice@gmail.com</a>> writes:<br> <br> > Add license hash<br> > Signed-off-by: Fabrice Fontaine <<a href="mailto:fontaine.fabrice@gmail.com" target="_blank">fontaine.fabrice@gmail.com</a>><br> <br> </span>Does this fix any big / security issues so it needs to go to master or<br> is this for next?<br></blockquote><div>There is no big / security issues, this is for next. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <span class="m_-6994265867838388694HOEnZb"><font color="#888888"><br> --<br> Bye, Peter Korsgaard<br> </font></span></blockquote></div>Best Regards,</div><div class="gmail_extra"><br></div><div class="gmail_extra">Fabrice<br></div></div>
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > Dear Peter, > 2018-02-27 22:03 GMT+01:00 Peter Korsgaard <peter@korsgaard.com>: >> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: >> >> > Add license hash >> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> >> >> Does this fix any big / security issues so it needs to go to master or >> is this for next? >> > There is no big / security issues, this is for next. Ok - Committed to next, thanks.
> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: >Does this fix any big / security issues so it needs to go to master or > s this for next? The previous version of azmq will not build with the boost version in 2018.02-rc2. It does work with buildroot 2017.11.2. Not sure exactly where the breakage point was between those releases.
>>>>> "Trent" == Trent Piepho <tpiepho@impinj.com> writes: >> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: >> Does this fix any big / security issues so it needs to go to master or >> s this for next? > The previous version of azmq will not build with the boost version in 2018.02-rc2. > It does work with buildroot 2017.11.2. > Not sure exactly where the breakage point was between those releases. Ahh, so azmq-1.0 doesn't build in 2018.02-rc3? Odd, I don't see it in the autobuilders.
Dear Peter and Trent, 2018-02-28 7:33 GMT+01:00 Peter Korsgaard <peter@korsgaard.com>: > >>>>> "Trent" == Trent Piepho <tpiepho@impinj.com> writes: > > >> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> > writes: > >> Does this fix any big / security issues so it needs to go to master or > >> s this for next? > > > The previous version of azmq will not build with the boost version in > 2018.02-rc2. > > > It does work with buildroot 2017.11.2. > > > Not sure exactly where the breakage point was between those releases. > > Ahh, so azmq-1.0 doesn't build in 2018.02-rc3? Odd, I don't see it in > the autobuilders. > From my knowledge, azmq didn't build on targets without NPTL support but the error was tagged as a boost error: http://autobuild.buildroot.net/?reason=boost-1.66.0. The patch https://patchwork.ozlabs.org/patch/877238 fixed this issue. The issue was that NPTL was wrongly selected by azmq. I'm not aware of any other issues. > > -- > Bye, Peter Korsgaard > Best Regards, Fabrice <div dir="ltr">Dear Peter and Trent,<div class="gmail_extra"><br><div class="gmail_quote">2018-02-28 7:33 GMT+01:00 Peter Korsgaard <span dir="ltr"><<a href="mailto:peter@korsgaard.com" target="_blank">peter@korsgaard.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">>>>>> "Trent" == Trent Piepho <<a href="mailto:tpiepho@impinj.com">tpiepho@impinj.com</a>> writes:<br> <br> >> >>>>> "Fabrice" == Fabrice Fontaine <<a href="mailto:fontaine.fabrice@gmail.com">fontaine.fabrice@gmail.com</a>> writes:<br> >> Does this fix any big / security issues so it needs to go to master or<br> >> s this for next?<br> <br> > The previous version of azmq will not build with the boost version in 2018.02-rc2.<br> <br> > It does work with buildroot 2017.11.2.<br> <br> > Not sure exactly where the breakage point was between those releases.<br> <br> </div></div>Ahh, so azmq-1.0 doesn't build in 2018.02-rc3? Odd, I don't see it in<br> the autobuilders.<br></blockquote><div>From my knowledge, azmq didn't build on targets without NPTL support but the error was tagged as a boost error: <a href="http://autobuild.buildroot.net/?reason=boost-1.66.0">http://autobuild.buildroot.net/?reason=boost-1.66.0</a>.</div><div>The patch <a href="https://patchwork.ozlabs.org/patch/877238">https://patchwork.ozlabs.org/patch/877238</a> fixed this issue.</div><div>The issue was that NPTL was wrongly selected by azmq.</div><div><br></div><div>I'm not aware of any other issues.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <span class="gmail-HOEnZb"><font color="#888888"><br> --<br> Bye, Peter Korsgaard<br></font></span></blockquote><div><br></div><div>Best Regards,</div><div><br></div><div>Fabrice </div></div><br></div></div>
On Wed, 2018-02-28 at 07:33 +0100, Peter Korsgaard wrote: > > > > > > "Trent" == Trent Piepho <tpiepho@impinj.com> writes: > > >> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > >> Does this fix any big / security issues so it needs to go to master or > >> s this for next? > > > The previous version of azmq will not build with the boost version in 2018.02-rc2. > > > It does work with buildroot 2017.11.2. > > > Not sure exactly where the breakage point was between those releases. > > Ahh, so azmq-1.0 doesn't build in 2018.02-rc3? Odd, I don't see it in > the autobuilder azmq is a header only library and buildroot disables the library's unit tests, so there is nothing to fail when buildroot "builds" the library. But if you use it, it doesn't work with some asio changes that went into boost. It would be interesting if buildroot could build and run a package's unit tests. I wonder if autobuilders would be able to find many bugs that way?
On 28-02-18 19:23, Trent Piepho wrote: > On Wed, 2018-02-28 at 07:33 +0100, Peter Korsgaard wrote: >>>>>>> "Trent" == Trent Piepho <tpiepho@impinj.com> writes: >> >> >> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: >> >> Does this fix any big / security issues so it needs to go to master or >> >> s this for next? >> >> > The previous version of azmq will not build with the boost version in 2018.02-rc2. >> >> > It does work with buildroot 2017.11.2. >> >> > Not sure exactly where the breakage point was between those releases. >> >> Ahh, so azmq-1.0 doesn't build in 2018.02-rc3? Odd, I don't see it in >> the autobuilder > > azmq is a header only library and buildroot disables the library's unit > tests, so there is nothing to fail when buildroot "builds" the library. > But if you use it, it doesn't work with some asio changes that went > into boost. > > It would be interesting if buildroot could build and run a package's > unit tests. I wonder if autobuilders would be able to find many bugs > that way? The runtime testing infrastructure is meant for exactly that. Well, it would need to be extended with some way to build the unit tests and copy them to the target - possibly in a post-build script. Regards, Arnout
diff --git a/package/azmq/azmq.hash b/package/azmq/azmq.hash index d3993f4988..35139cfaeb 100644 --- a/package/azmq/azmq.hash +++ b/package/azmq/azmq.hash @@ -1,3 +1,4 @@ # Locally calculated -# https://github.com/zeromq/azmq/archive/v1.0.tar.gz -sha256 c204c731bcb7810ca3a2c5515e88974ef2ff8d0589e60a897dc238b369180e7b azmq-v1.0.tar.gz +# https://github.com/zeromq/azmq/archive/v1.0.2.tar.gz +sha256 25fa8b07756cffae95e25a55c7ea42efe02e8cd797552201aa771dd69cfc8fbf azmq-v1.0.2.tar.gz +sha256 c9bff75738922193e67fa726fa225535870d2aa1059f91452c411736284ad566 LICENSE-BOOST_1_0 diff --git a/package/azmq/azmq.mk b/package/azmq/azmq.mk index 427ad0f5b4..9ccb407a65 100644 --- a/package/azmq/azmq.mk +++ b/package/azmq/azmq.mk @@ -4,7 +4,7 @@ # ################################################################################ -AZMQ_VERSION = v1.0 +AZMQ_VERSION = v1.0.2 AZMQ_SITE = $(call github,zeromq,azmq,$(AZMQ_VERSION)) AZMQ_DEPENDENCIES = boost zeromq AZMQ_LICENSE = BSL-1.0
Add license hash Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/azmq/azmq.hash | 5 +++-- package/azmq/azmq.mk | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)