diff mbox

RFA: Add MN10300 to list of targets not supporting profiling

Message ID m3r59zlduf.fsf@redhat.com
State New
Headers show

Commit Message

Nick Clifton March 22, 2011, 9:11 a.m. UTC
Hi Rainer, Hi Mike,

  Please may I apply the patch below to add the MN10300 target, and its
  AM33/AM34 variation, to the list of targets which do not currently
  support profiling ?

  With this patch applied I get several fewer unexpected failures from
  the gcc testsuite for my mn10300 toolchains.

Cheers
  Nick

gcc/testsuite/ChangeLog
2011-03-22  Nick Clifton  <nickc@redhat.com>

	* lib/target-supports.exp (check_profiling_available): Add MN10300
	to the list of targets not supporting profiling.

Comments

Rainer Orth March 22, 2011, 9:36 a.m. UTC | #1
Hi Nick,

>   Please may I apply the patch below to add the MN10300 target, and its
>   AM33/AM34 variation, to the list of targets which do not currently
>   support profiling ?

sure, such a change is ok for a target maintainer to apply without
approval.

> Index: gcc/testsuite/lib/target-supports.exp
> ===================================================================
> --- gcc/testsuite/lib/target-supports.exp	(revision 171279)
> +++ gcc/testsuite/lib/target-supports.exp	(working copy)
> @@ -561,6 +561,8 @@
>  	     || [istarget m68k-*-uclinux*]
>  	     || [istarget mep-*-elf]
>  	     || [istarget mips*-*-elf*]
> +	     || [istarget mn10300-*-elf*]
> +	     || [istarget am3*-*-linux*]
>  	     || [istarget moxie-*-elf*]
>  	     || [istarget rx-*-*]	
>  	     || [istarget xstormy16-*]

I'd like the targets to be kept sorted alphabetically (though this is
rarely done consistently so far).

Thanks.
	Rainer
Nick Clifton March 22, 2011, 4:19 p.m. UTC | #2
Hi Rainer,

> sure, such a change is ok for a target maintainer to apply without
> approval.

OK - thanks.  (I was not sure if this was the rule, so I thought that it 
was best to ask).

> I'd like the targets to be kept sorted alphabetically (though this is
> rarely done consistently so far).

I have restored alpha sorting to this particular list.

Cheers
   Nick
Mike Stump March 22, 2011, 6:53 p.m. UTC | #3
On Mar 22, 2011, at 2:11 AM, Nick Clifton wrote:
>  Please may I apply the patch below to add the MN10300 target, and its
>  AM33/AM34 variation, to the list of targets which do not currently
>  support profiling ?

I think the target maintainers make for a better reviewer in this case, if not obvious.
diff mbox

Patch

Index: gcc/testsuite/lib/target-supports.exp
===================================================================
--- gcc/testsuite/lib/target-supports.exp	(revision 171279)
+++ gcc/testsuite/lib/target-supports.exp	(working copy)
@@ -561,6 +561,8 @@ 
 	     || [istarget m68k-*-uclinux*]
 	     || [istarget mep-*-elf]
 	     || [istarget mips*-*-elf*]
+	     || [istarget mn10300-*-elf*]
+	     || [istarget am3*-*-linux*]
 	     || [istarget moxie-*-elf*]
 	     || [istarget rx-*-*]	
 	     || [istarget xstormy16-*]