Patchwork powerpc: pseries/smp: query-cpu-stopped-state support won't change

login
register
mail settings
Submitter Milton Miller
Date March 21, 2011, 6:12 p.m.
Message ID <quieten-query-cpu-stopped-state@mdm.bga.com>
Download mbox | patch
Permalink /patch/87811/
State Accepted, archived
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Milton Miller - March 21, 2011, 6:12 p.m.
If a given firmware doesn't have a token to support query-cpu-stopped-state,
its not likely to change during the lifetime of the kernel.   

Only print this information once, not once per secondary thread.

While here, make the line wrap grep friendly.

Signed-off-by: Milton Miller <miltonm@bga.com>

Patch

Index: work.git/arch/powerpc/platforms/pseries/smp.c
===================================================================
--- work.git.orig/arch/powerpc/platforms/pseries/smp.c	2011-03-21 11:27:54.000000000 -0500
+++ work.git/arch/powerpc/platforms/pseries/smp.c	2011-03-21 11:29:51.000000000 -0500
@@ -64,8 +64,8 @@  int smp_query_cpu_stopped(unsigned int p
 	int qcss_tok = rtas_token("query-cpu-stopped-state");
 
 	if (qcss_tok == RTAS_UNKNOWN_SERVICE) {
-		printk(KERN_INFO "Firmware doesn't support "
-				"query-cpu-stopped-state\n");
+		printk_once(KERN_INFO
+			"Firmware doesn't support query-cpu-stopped-state\n");
 		return QCSS_HARDWARE_ERROR;
 	}