Patchwork UBI: make the control character device non-seekable

login
register
mail settings
Submitter Artem Bityutskiy
Date March 21, 2011, 2:58 p.m.
Message ID <1300719491-15157-1-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/87788/
State Accepted
Commit e10b376e98332edcc2530aaed384a7e248477052
Headers show

Comments

Artem Bityutskiy - March 21, 2011, 2:58 p.m.
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

This patch makes the UBI control device (/dev/ubi_ctrl) non-seekable.
The seek operation does is not applicable to this file, so it is
cleaner to explicitly return error (which the added 'no_llseek()')
does than trying to change the position (which the removed
'default_llseek()' does).

This is an API break, but the only known user of this interface is
mtd-utils which does not need the seeking functionality. And any app
which relies on this is broken, but I'm not aware of such apps.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 drivers/mtd/ubi/cdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index af9fb0f..9a17032 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -1100,5 +1100,5 @@  const struct file_operations ubi_ctrl_cdev_operations = {
 	.owner          = THIS_MODULE,
 	.unlocked_ioctl = ctrl_cdev_ioctl,
 	.compat_ioctl   = ctrl_cdev_compat_ioctl,
-	.llseek		= noop_llseek,
+	.llseek		= no_llseek,
 };