Patchwork [2/2] UBIFS: make debugfs files non-seekable

login
register
mail settings
Submitter Artem Bityutskiy
Date March 21, 2011, 2:55 p.m.
Message ID <1300719315-32168-1-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/87786/
State Accepted
Commit 1bbfc848a915081237660d898bbcf50e4a8fc59f
Headers show

Comments

Artem Bityutskiy - March 21, 2011, 2:55 p.m.
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Turn the debufs files UBIFS maintains into non-seekable. Indeed, none
of them is supposed to be seek'ed.

Do this by making the '.lseek()' handler to be 'no_llseek()' and by
using 'nonseekable_open()' in the '.open()' operation.

This does mean an API break but this debugging API is only used by a couple
of test scripts which do not rely in the 'llseek()' operation.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 fs/ubifs/debug.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 01c2b02..32b93f3 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2753,7 +2753,7 @@  void dbg_debugfs_exit(void)
 static int open_debugfs_file(struct inode *inode, struct file *file)
 {
 	file->private_data = inode->i_private;
-	return 0;
+	return nonseekable_open(inode, file);
 }
 
 static ssize_t write_debugfs_file(struct file *file, const char __user *buf,
@@ -2783,7 +2783,7 @@  static const struct file_operations dfs_fops = {
 	.open = open_debugfs_file,
 	.write = write_debugfs_file,
 	.owner = THIS_MODULE,
-	.llseek = default_llseek,
+	.llseek = no_llseek,
 };
 
 /**