Message ID | 20180226095953.7214-1-jiri@resnulli.us |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series | [net] devlink: Compare to size_new in case of resource child validation | expand |
From: Jiri Pirko <jiri@resnulli.us> Date: Mon, 26 Feb 2018 10:59:53 +0100 > From: Arkadi Sharshevsky <arkadis@mellanox.com> > > The current implementation checks the combined size of the children with > the 'size' of the parent. The correct behavior is to check the combined > size vs the pending change and to compare vs the 'size_new'. > > Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction") > Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com> > Tested-by: Yuval Mintz <yuvalm@mellanox.com> > Signed-off-by: Jiri Pirko <jiri@mellanox.com> Applied, thank you.
diff --git a/net/core/devlink.c b/net/core/devlink.c index 18d385ed8237..92aad7c46383 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -2332,7 +2332,7 @@ devlink_resource_validate_children(struct devlink_resource *resource) list_for_each_entry(child_resource, &resource->resource_list, list) parts_size += child_resource->size_new; - if (parts_size > resource->size) + if (parts_size > resource->size_new) size_valid = false; out: resource->size_valid = size_valid;