Patchwork [v21,00/11] usb-ccid

login
register
mail settings
Submitter Alon Levy
Date March 21, 2011, 12:24 p.m.
Message ID <20110321122458.GC9610@playa.tlv.redhat.com>
Download mbox | patch
Permalink /patch/87761/
State New
Headers show

Comments

Alon Levy - March 21, 2011, 12:24 p.m.
On Mon, Mar 21, 2011 at 11:33:57AM +0000, Stefan Hajnoczi wrote:
> On Thu, Mar 17, 2011 at 2:49 PM, Alon Levy <alevy@redhat.com> wrote:
> > This patchset adds three new devices, usb-ccid, ccid-card-passthru and
> > ccid-card-emulated, providing a CCID bus, a simple passthru protocol
> > implementing card requiring a client, and a standalone emulated card.
> >
> > It also introduces a new directory libcaccard with CAC card emulation,
> > CAC is a type of ISO 7816 smart card.
> 
> I just build tested this patchset and got:
> $ make distclean
> $ ./configure --prefix=/usr --target-list=x86_64-softmmu
> --enable-io-thread  --disable-strip
> $ make
>   CC    x86_64-softmmu/../libcacard/vcard_emul_nss.o
> ../libcacard/vcard_emul_nss.c:23:21: fatal error: pk11pub.h: No such
> file or directory
> compilation terminated.
> make[1]: *** [../libcacard/vcard_emul_nss.o] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
> 
> It seems the smartcard ./configure check needs to be stricter in
> checking for the presence of build dependencies.
> 
> Stefan
> 

Thanks, this should fix it:
Stefan Hajnoczi - March 21, 2011, 1:24 p.m.
On Mon, Mar 21, 2011 at 12:24 PM, Alon Levy <alevy@redhat.com> wrote:
> Thanks, this should fix it:
>
> diff --git a/Makefile.target b/Makefile.target
> index baa5c3f..fef56b4 100644
> --- a/Makefile.target
> +++ b/Makefile.target

Thanks it fixes it.  I didn't have libnss3-dev installed.

Stefan

Patch

diff --git a/Makefile.target b/Makefile.target
index baa5c3f..fef56b4 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -350,7 +350,7 @@  obj-y += $(addprefix $(HWDIR)/, $(hw-obj-y))
 
 endif # CONFIG_SOFTMMU
 
-obj-y += $(addprefix ../libcacard/, $(libcacard-$(CONFIG_SMARTCARD)))
+obj-y += $(addprefix ../libcacard/, $(libcacard-$(CONFIG_SMARTCARD_NSS)))
 
 obj-y += $(addprefix ../, $(trace-obj-y))
 obj-$(CONFIG_GDBSTUB_XML) += gdbstub-xml.o