| Message ID | 20180225172236.29650-20-malat@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b0d876da1d1cd33a1c28049512a136e61d0ff371 |
| Headers | show |
| Series | powerpc/gamecube: make W=1 compilation errors free | expand |
On Sun, 2018-02-25 at 17:22:34 UTC, Mathieu Malaterre wrote: > In commit 5aae8a537080 ("powerpc, hw_breakpoints: Implement hw_breakpoints > for 64-bit server processors") function hw_breakpoint_handler and > arch_unregister_hw_breakpoint were added without function prototypes in > hw_breakpoint.h header. > > Fix the following warning(s) (treated as error in W=1): > > AR init/built-in.o > arch/powerpc/kernel/hw_breakpoint.c:106:6: error: no previous prototype for ‘arch_unregister_hw_breakpoint’ [-Werror=missing-prototypes] > void arch_unregister_hw_breakpoint(struct perf_event *bp) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/kernel/hw_breakpoint.c:209:5: error: no previous prototype for ‘hw_breakpoint_handler’ [-Werror=missing-prototypes] > int hw_breakpoint_handler(struct die_args *args) > ^~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Signed-off-by: Mathieu Malaterre <malat@debian.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/b0d876da1d1cd33a1c28049512a136 cheers
diff --git a/arch/powerpc/include/asm/hw_breakpoint.h b/arch/powerpc/include/asm/hw_breakpoint.h index ac6432d9be46..90c708e5e7c4 100644 --- a/arch/powerpc/include/asm/hw_breakpoint.h +++ b/arch/powerpc/include/asm/hw_breakpoint.h @@ -66,6 +66,7 @@ extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused, unsigned long val, void *data); int arch_install_hw_breakpoint(struct perf_event *bp); void arch_uninstall_hw_breakpoint(struct perf_event *bp); +void arch_unregister_hw_breakpoint(struct perf_event *bp); void hw_breakpoint_pmu_read(struct perf_event *bp); extern void flush_ptrace_hw_breakpoint(struct task_struct *tsk); @@ -82,6 +83,7 @@ static inline void hw_breakpoint_disable(void) __set_breakpoint(&brk); } extern void thread_change_pc(struct task_struct *tsk, struct pt_regs *regs); +int hw_breakpoint_handler(struct die_args *args); #else /* CONFIG_HAVE_HW_BREAKPOINT */ static inline void hw_breakpoint_disable(void) { }
In commit 5aae8a537080 ("powerpc, hw_breakpoints: Implement hw_breakpoints for 64-bit server processors") function hw_breakpoint_handler and arch_unregister_hw_breakpoint were added without function prototypes in hw_breakpoint.h header. Fix the following warning(s) (treated as error in W=1): AR init/built-in.o arch/powerpc/kernel/hw_breakpoint.c:106:6: error: no previous prototype for ‘arch_unregister_hw_breakpoint’ [-Werror=missing-prototypes] void arch_unregister_hw_breakpoint(struct perf_event *bp) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/kernel/hw_breakpoint.c:209:5: error: no previous prototype for ‘hw_breakpoint_handler’ [-Werror=missing-prototypes] int hw_breakpoint_handler(struct die_args *args) ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Signed-off-by: Mathieu Malaterre <malat@debian.org> --- arch/powerpc/include/asm/hw_breakpoint.h | 2 ++ 1 file changed, 2 insertions(+)