Patchwork [libgo] Support GOTESTFLAGS

login
register
mail settings
Submitter Rainer Orth
Date March 21, 2011, 11:57 a.m.
Message ID <yddk4fsfzy0.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/87759/
State New
Headers show

Comments

Rainer Orth - March 21, 2011, 11:57 a.m.
The following patch came in handy when I need to repeat an individual
libgo test and investigate the resulting binary:

$ make GOTESTFLAGS=--keep <test>/check

does the trick and is far neater than modifying the generated Makefile.

	Rainer


2011-03-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* Makefile.am (CHECK): Use $(GOTESTFLAGS).
	* Makefile.in: Regenerate.
Ian Taylor - March 21, 2011, 10:02 p.m.
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

> 2011-03-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
> 	* Makefile.am (CHECK): Use $(GOTESTFLAGS).
> 	* Makefile.in: Regenerate.

Thanks.

Committed.

Ian

Patch

diff -r ee84762ea4b7 libgo/Makefile.am
--- a/libgo/Makefile.am	Sat Mar 19 22:05:32 2011 +0100
+++ b/libgo/Makefile.am	Sun Mar 20 00:01:03 2011 +0100
@@ -1503,9 +1503,9 @@ 
 	prefix=`if test "$(@D)" = "regexp"; then echo regexp-test; else dirname $(@D); fi`; \
 	test "$${prefix}" != "." || prefix="$(@D)"; \
 	if test "$(use_dejagnu)" = "yes"; then \
-	  $(SHELL) $(srcdir)/testsuite/gotest --dejagnu=yes --basedir=$(srcdir) --srcdir=$(srcdir)/go/$(@D) --prefix="libgo_$${prefix}" --pkgfiles="$(go_$(subst /,_,$(@D))_files)"; \
+	  $(SHELL) $(srcdir)/testsuite/gotest --dejagnu=yes --basedir=$(srcdir) --srcdir=$(srcdir)/go/$(@D) --prefix="libgo_$${prefix}" --pkgfiles="$(go_$(subst /,_,$(@D))_files)" $(GOTESTFLAGS); \
 	else \
-	  if $(SHELL) $(srcdir)/testsuite/gotest --basedir=$(srcdir) --srcdir=$(srcdir)/go/$(@D) --prefix="libgo_$${prefix}" --pkgfiles="$(go_$(subst /,_,$(@D))_files)" >>$@-log 2>&1; then \
+	  if $(SHELL) $(srcdir)/testsuite/gotest --basedir=$(srcdir) --srcdir=$(srcdir)/go/$(@D) --prefix="libgo_$${prefix}" --pkgfiles="$(go_$(subst /,_,$(@D))_files)" $(GOTESTFLAGS) >>$@-log 2>&1; then \
 	    echo "PASS: $(@D)"; \
 	  else \
 	    echo "FAIL: $(@D)"; \