| Message ID | Pine.LNX.4.64.1103211023510.11088@digraph.polyomino.org.uk |
|---|---|
| State | New |
| Headers | show |
On 03/21/2011 11:41 AM, Joseph S. Myers wrote: > This patch, relative to a tree with my deprecated targets removal patch > <http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01088.html> applied, further > cleans up the toplevel configure.ac by removing empty cases from a case > statement. The original patch still needs review by someone able to > approve the patch as a whole, but as the only apparent controversy so far > concerned empty cases I hope this patch can resolve the concerns over that > bit of the original patch. > > The effect of removing empty cases in this particular case statement is > that any subsequent case matching the target, generally > > *-*-*) > noconfigdirs="$noconfigdirs ${libgcj}" > ;; > > comes into effect. That particular case is of no effect for targets with > no GCC support since they can't be trying to build libgcj or other GCC > target libraries anyway. All targets removed from the case statement by > this patch have no GCC support (after the deprecation patch). In > addition, some empty cases were left behind, either because the targets > did have GCC support or because a case other than *-*-* would trigger if > they were removed. > > OK to commit? Yes, after the deprecation patch is in. paolo
* Joseph S. Myers wrote on Mon, Mar 21, 2011 at 11:41:23AM CET: > This patch, relative to a tree with my deprecated targets removal patch > <http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01088.html> applied, further > cleans up the toplevel configure.ac by removing empty cases from a case > statement. The original patch still needs review by someone able to > approve the patch as a whole, but as the only apparent controversy so far > concerned empty cases I hope this patch can resolve the concerns over that > bit of the original patch. This patch is OK, and I retract any further controversy bits of mine regarding the build parts of above cited patch: you cleared up any remaining doubts. Thanks, Ralf > 2011-03-21 Joseph Myers <joseph@codesourcery.com> > > * configure.ac (arm-semi-aof, crx-*-*, parisc*-*-linux*, > i370-*-opened*, i[[3456789]]86-moss-msdos | i[[3456789]]86-*-moss* > | i[[3456789]]86-*-uwin*, mcore-*-pe*): Remove empty cases. > * configure: Regenerate.
On 03/21/2011 06:41 AM, Joseph S. Myers wrote: > This patch, relative to a tree with my deprecated targets removal patch > <http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01088.html> applied, further > cleans up the toplevel configure.ac by removing empty cases from a case > statement. The original patch still needs review by someone able to > approve the patch as a whole, but as the only apparent controversy so far > concerned empty cases I hope this patch can resolve the concerns over that > bit of the original patch. I'd just like to say thanks for doing this (removing dead and empty cases). I wanted to do a lot more of this when I cleaned up the toplevel several years back, but people were extremely uncertain at that time as to what other projects were using the top level and how they would react to the change. I'm glad this can be done now, as I guess it's clear now that the top level is only being used by a short, known list of projects. Nathanael Nerode
--- configure.ac 2011-03-17 20:36:23.000000000 +0000 +++ configure.ac.new 2011-03-21 10:23:01.000000000 +0000 @@ -672,8 +672,6 @@ arc-*-*) noconfigdirs="$noconfigdirs target-libgloss" ;; - arm-semi-aof ) - ;; arm-*-coff | strongarm-*-coff | xscale-*-coff) noconfigdirs="$noconfigdirs ${libgcj}" libgloss_dir=arm @@ -743,8 +741,6 @@ esac libgloss_dir=cris ;; - crx-*-*) - ;; d10v-*-*) noconfigdirs="$noconfigdirs target-libstdc++-v3 target-libgloss ${libgcj}" ;; @@ -778,7 +774,7 @@ # headers, crt*.o, etc., all of which are needed by these. noconfigdirs="$noconfigdirs target-zlib" ;; - parisc*-*-linux* | hppa*-*-linux*) + hppa*-*-linux*) ;; hppa*-*-*elf* | \ hppa*-*-lites* | \ @@ -812,8 +808,6 @@ # No gdb or ld support yet. noconfigdirs="$noconfigdirs ${libgcj} tix readline mmalloc libgui itcl gdb ld" ;; - i370-*-opened*) - ;; i[[3456789]]86-*-coff | i[[3456789]]86-*-elf) noconfigdirs="$noconfigdirs ${libgcj}" libgloss_dir=i386 @@ -857,8 +851,7 @@ echo "Warning: winsup/cygwin is missing so newlib can't be built." fi ;; - i[[3456789]]86-moss-msdos | i[[3456789]]86-*-moss* | \ - i[[3456789]]86-*-uwin* | i[[3456789]]86-*-interix* ) + i[[3456789]]86-*-interix* ) ;; i[[3456789]]86-*-pe) noconfigdirs="$noconfigdirs target-libgloss" @@ -899,8 +892,6 @@ m68*-*-* | fido-*-*) libgloss_dir=m68k ;; - mcore-*-pe*) - ;; mmix-*-*) noconfigdirs="$noconfigdirs target-libffi target-boehm-gc gdb libgloss" unsupported_languages="$unsupported_languages fortran java"
This patch, relative to a tree with my deprecated targets removal patch <http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01088.html> applied, further cleans up the toplevel configure.ac by removing empty cases from a case statement. The original patch still needs review by someone able to approve the patch as a whole, but as the only apparent controversy so far concerned empty cases I hope this patch can resolve the concerns over that bit of the original patch. The effect of removing empty cases in this particular case statement is that any subsequent case matching the target, generally *-*-*) noconfigdirs="$noconfigdirs ${libgcj}" ;; comes into effect. That particular case is of no effect for targets with no GCC support since they can't be trying to build libgcj or other GCC target libraries anyway. All targets removed from the case statement by this patch have no GCC support (after the deprecation patch). In addition, some empty cases were left behind, either because the targets did have GCC support or because a case other than *-*-* would trigger if they were removed. OK to commit? 2011-03-21 Joseph Myers <joseph@codesourcery.com> * configure.ac (arm-semi-aof, crx-*-*, parisc*-*-linux*, i370-*-opened*, i[[3456789]]86-moss-msdos | i[[3456789]]86-*-moss* | i[[3456789]]86-*-uwin*, mcore-*-pe*): Remove empty cases. * configure: Regenerate.