Patchwork fix applesmc REV key

login
register
mail settings
Submitter René Rebe
Date March 21, 2011, 10:33 a.m.
Message ID <64695A7D-BF52-4B87-AD93-FFCF649275EF@exactcode.de>
Download mbox | patch
Permalink /patch/87738/
State New
Headers show

Comments

René Rebe - March 21, 2011, 10:33 a.m.
Fix applesmc REV key string literal hex encoding.

Signed-off-by: René Rebe <rene@exactcode.de>
Alexander Graf - March 21, 2011, 10:45 a.m.
On 21.03.2011, at 11:33, René Rebe wrote:

> Fix applesmc REV key string literal hex encoding.
> 
> Signed-off-by: René Rebe <rene@exactcode.de>

Acked-by: Alexander Graf <agraf@suse.de>

Alex

> 
> --- qemu-kvm-0.14.0/hw/applesmc.c.vanilla	2011-02-22 18:55:03.732000025 +0000
> +++ qemu-kvm-0.14.0/hw/applesmc.c	2011-02-22 18:56:08.892000025 +0000
> @@ -188,7 +188,7 @@
>         QLIST_REMOVE(d, node);
>     }
> 
> -    applesmc_add_key(s, "REV ", 6, "\0x01\0x13\0x0f\0x00\0x00\0x03");
> +    applesmc_add_key(s, "REV ", 6, "\x01\x13\x0f\x00\x00\x03");
>     applesmc_add_key(s, "OSK0", 32, s->osk);
>     applesmc_add_key(s, "OSK1", 32, s->osk + 32);
>     applesmc_add_key(s, "NATJ", 1, "\0");
> 
> -- 
> René Rebe, ExactCODE GmbH, Jaegerstr. 67, DE-10117 Berlin
> DE Legal: Amtsgericht Charlottenburg HRB 105123B, Tax-ID#: DE251602478
> Managing Directors: Susanne Klaus, René Rebe
> http://exactcode.com | http://t2-project.org | http://rene.rebe.de
>
Aurelien Jarno - March 22, 2011, 6:42 a.m.
On Mon, Mar 21, 2011 at 11:33:21AM +0100, René Rebe wrote:
> Fix applesmc REV key string literal hex encoding.
> 
> Signed-off-by: René Rebe <rene@exactcode.de>
> 
> --- qemu-kvm-0.14.0/hw/applesmc.c.vanilla	2011-02-22 18:55:03.732000025 +0000
> +++ qemu-kvm-0.14.0/hw/applesmc.c	2011-02-22 18:56:08.892000025 +0000
> @@ -188,7 +188,7 @@
>          QLIST_REMOVE(d, node);
>      }
>  
> -    applesmc_add_key(s, "REV ", 6, "\0x01\0x13\0x0f\0x00\0x00\0x03");
> +    applesmc_add_key(s, "REV ", 6, "\x01\x13\x0f\x00\x00\x03");
>      applesmc_add_key(s, "OSK0", 32, s->osk);
>      applesmc_add_key(s, "OSK1", 32, s->osk + 32);
>      applesmc_add_key(s, "NATJ", 1, "\0");
> 

Thanks, applied.

Patch

--- qemu-kvm-0.14.0/hw/applesmc.c.vanilla	2011-02-22 18:55:03.732000025 +0000
+++ qemu-kvm-0.14.0/hw/applesmc.c	2011-02-22 18:56:08.892000025 +0000
@@ -188,7 +188,7 @@ 
         QLIST_REMOVE(d, node);
     }
 
-    applesmc_add_key(s, "REV ", 6, "\0x01\0x13\0x0f\0x00\0x00\0x03");
+    applesmc_add_key(s, "REV ", 6, "\x01\x13\x0f\x00\x00\x03");
     applesmc_add_key(s, "OSK0", 32, s->osk);
     applesmc_add_key(s, "OSK1", 32, s->osk + 32);
     applesmc_add_key(s, "NATJ", 1, "\0");