| Message ID | 1519419359-19163-1-git-send-email-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 64c3f648c25d108f346fdc96c15180c6b7d250e9 |
| Headers | show |
| Series | powerpc/boot: Fix random build errors | expand |
On Fri, 2018-02-23 at 20:55:59 UTC, Guenter Roeck wrote: > Once in a while I see build errors similar to the following > when building images from a clean tree. > > Building powerpc:virtex-ml507:44x/virtex5_defconfig ... failed > ------------ > Error log: > arch/powerpc/boot/treeboot-akebono.c:37:20: fatal error: > libfdt.h: No such file or directory > > Building powerpc:bamboo:smpdev:44x/bamboo_defconfig ... failed > ------------ > Error log: > arch/powerpc/boot/treeboot-akebono.c:37:20: fatal error: > libfdt.h: No such file or directory > > arch/powerpc/boot/treeboot-currituck.c:35:20: fatal error: > libfdt.h: No such file or directory > > Rebuilds will succeed. > > Turns out that several source files in arch/powerpc/boot/ include > libfdt.h, but Makefile dependencies are incomplete. Let's fix that. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/64c3f648c25d108f346fdc96c15180 cheers
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index ef6549e57157..26d5d2a5b8e9 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -101,7 +101,8 @@ $(addprefix $(obj)/,$(zlib-y)): \ libfdt := fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c libfdtheader := fdt.h libfdt.h libfdt_internal.h -$(addprefix $(obj)/,$(libfdt) libfdt-wrapper.o simpleboot.o epapr.o opal.o): \ +$(addprefix $(obj)/,$(libfdt) libfdt-wrapper.o simpleboot.o epapr.o opal.o \ + treeboot-akebono.o treeboot-currituck.o treeboot-iss4xx.o): \ $(addprefix $(obj)/,$(libfdtheader)) src-wlib-y := string.S crt0.S stdio.c decompress.c main.c \
Once in a while I see build errors similar to the following when building images from a clean tree. Building powerpc:virtex-ml507:44x/virtex5_defconfig ... failed ------------ Error log: arch/powerpc/boot/treeboot-akebono.c:37:20: fatal error: libfdt.h: No such file or directory Building powerpc:bamboo:smpdev:44x/bamboo_defconfig ... failed ------------ Error log: arch/powerpc/boot/treeboot-akebono.c:37:20: fatal error: libfdt.h: No such file or directory arch/powerpc/boot/treeboot-currituck.c:35:20: fatal error: libfdt.h: No such file or directory Rebuilds will succeed. Turns out that several source files in arch/powerpc/boot/ include libfdt.h, but Makefile dependencies are incomplete. Let's fix that. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- arch/powerpc/boot/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)