Patchwork vmmouse: Fix initialization

login
register
mail settings
Submitter Jan Kiszka
Date March 21, 2011, 9:52 a.m.
Message ID <4D871FD8.2010400@siemens.com>
Download mbox | patch
Permalink /patch/87727/
State New
Headers show

Comments

Jan Kiszka - March 21, 2011, 9:52 a.m.
Latest refactorings left vmmouse nonfunctional behind. Fix it by adding
the required device initialization.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/pc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Aurelien Jarno - March 22, 2011, 6:45 a.m.
On Mon, Mar 21, 2011 at 10:52:24AM +0100, Jan Kiszka wrote:
> Latest refactorings left vmmouse nonfunctional behind. Fix it by adding
> the required device initialization.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/pc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/hw/pc.c b/hw/pc.c
> index 4d67d9f..6939c04 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1142,6 +1142,7 @@ void pc_basic_device_init(qemu_irq *isa_irq,
>      vmmouse = isa_try_create("vmmouse");
>      if (vmmouse) {
>          qdev_prop_set_ptr(&vmmouse->qdev, "ps2_mouse", i8042);
> +        qdev_init_nofail(&vmmouse->qdev);
>      }
>      port92 = isa_create_simple("port92");
>      port92_init(port92, &a20_line[1]);
> -- 
> 1.7.1
> 
>

Patch

diff --git a/hw/pc.c b/hw/pc.c
index 4d67d9f..6939c04 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1142,6 +1142,7 @@  void pc_basic_device_init(qemu_irq *isa_irq,
     vmmouse = isa_try_create("vmmouse");
     if (vmmouse) {
         qdev_prop_set_ptr(&vmmouse->qdev, "ps2_mouse", i8042);
+        qdev_init_nofail(&vmmouse->qdev);
     }
     port92 = isa_create_simple("port92");
     port92_init(port92, &a20_line[1]);