diff mbox series

sfc: falcon: remove duplicated bit-wise or of LOOPBACK_SGMII

Message ID 20180223140056.27219-1-colin.king@canonical.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series sfc: falcon: remove duplicated bit-wise or of LOOPBACK_SGMII | expand

Commit Message

Colin Ian King Feb. 23, 2018, 2 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Bit pattern LOOPBACK_SGMII is being bit-wise or'd twice; remove the
redundant 2nd LOOPBACK_SGMII

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/sfc/falcon/enum.h | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller Feb. 26, 2018, 4:34 p.m. UTC | #1 
From: Colin King <colin.king@canonical.com>
Date: Fri, 23 Feb 2018 14:00:56 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> Bit pattern LOOPBACK_SGMII is being bit-wise or'd twice; remove the
> redundant 2nd LOOPBACK_SGMII
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to net-next, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/sfc/falcon/enum.h b/drivers/net/ethernet/sfc/falcon/enum.h
index 30a1136fc909..4824fcf5c3d4 100644
--- a/drivers/net/ethernet/sfc/falcon/enum.h
+++ b/drivers/net/ethernet/sfc/falcon/enum.h
@@ -81,7 +81,6 @@  enum ef4_loopback_mode {
 			    (1 << LOOPBACK_XAUI) |		\
 			    (1 << LOOPBACK_GMII) |		\
 			    (1 << LOOPBACK_SGMII) |		\
-			    (1 << LOOPBACK_SGMII) |		\
 			    (1 << LOOPBACK_XGBR) |		\
 			    (1 << LOOPBACK_XFI) |		\
 			    (1 << LOOPBACK_XAUI_FAR) |		\