| Message ID | 20180223133742.26044-3-mylene.josserand@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | Sunxi: Add SMP support on A83T | expand |
On Fri, Feb 23, 2018 at 02:37:34PM +0100, Mylène Josserand wrote: > To prepare the support for sun8i-a83t, rename the variable name > that handles the power-off of clusters because it is different from > sun9i-a80 to sun8i-a83t. > > The power off register for clusters are different from SUN9I and SUN8I This is just a nitpick, and I see you use them everywhere, but sun8i and sun9i are the family of SoCs, and A80 and A83t the name of SoCs within their respective families. So in your commit log, you want to support the A83t because it's different than the A80, and the sun9i and sun8i mentionned in your last sentence is not really meaningful. > Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> Maxime
Hi, On Fri, 23 Feb 2018 15:56:50 +0100 Maxime Ripard <maxime.ripard@bootlin.com> wrote: > On Fri, Feb 23, 2018 at 02:37:34PM +0100, Mylène Josserand wrote: > > To prepare the support for sun8i-a83t, rename the variable name > > that handles the power-off of clusters because it is different from > > sun9i-a80 to sun8i-a83t. > > > > The power off register for clusters are different from SUN9I and SUN8I > > This is just a nitpick, and I see you use them everywhere, but sun8i > and sun9i are the family of SoCs, and A80 and A83t the name of SoCs > within their respective families. > > So in your commit log, you want to support the A83t because it's > different than the A80, and the sun9i and sun8i mentionned in your > last sentence is not really meaningful. True, I will pay attention next time. > > > Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com> > > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> > > Maxime > Thanks, Mylène
diff --git a/arch/arm/mach-sunxi/mc_smp.c b/arch/arm/mach-sunxi/mc_smp.c index 650a2ad4398f..de02e5662557 100644 --- a/arch/arm/mach-sunxi/mc_smp.c +++ b/arch/arm/mach-sunxi/mc_smp.c @@ -60,7 +60,7 @@ #define PRCM_CPU_PO_RST_CTRL_CORE(n) BIT(n) #define PRCM_CPU_PO_RST_CTRL_CORE_ALL 0xf #define PRCM_PWROFF_GATING_REG(c) (0x100 + 0x4 * (c)) -#define PRCM_PWROFF_GATING_REG_CLUSTER BIT(4) +#define PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I BIT(4) #define PRCM_PWROFF_GATING_REG_CORE(n) BIT(n) #define PRCM_PWR_SWITCH_REG(c, cpu) (0x140 + 0x10 * (c) + 0x4 * (cpu)) #define PRCM_CPU_SOFT_ENTRY_REG 0x164 @@ -252,7 +252,7 @@ static int sunxi_cluster_powerup(unsigned int cluster) /* clear cluster power gate */ reg = readl(prcm_base + PRCM_PWROFF_GATING_REG(cluster)); - reg &= ~PRCM_PWROFF_GATING_REG_CLUSTER; + reg &= ~PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I; writel(reg, prcm_base + PRCM_PWROFF_GATING_REG(cluster)); udelay(20); @@ -516,7 +516,7 @@ static int sunxi_cluster_powerdown(unsigned int cluster) /* gate cluster power */ pr_debug("%s: gate cluster power\n", __func__); reg = readl(prcm_base + PRCM_PWROFF_GATING_REG(cluster)); - reg |= PRCM_PWROFF_GATING_REG_CLUSTER; + reg |= PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I; writel(reg, prcm_base + PRCM_PWROFF_GATING_REG(cluster)); udelay(20);
To prepare the support for sun8i-a83t, rename the variable name that handles the power-off of clusters because it is different from sun9i-a80 to sun8i-a83t. The power off register for clusters are different from SUN9I and SUN8I Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com> --- arch/arm/mach-sunxi/mc_smp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)