MAINTAINERS: Update ASPEED entry with details

Message ID 20180222050324.21531-1-joel@jms.id.au
State Not Applicable, archived
Headers show
Series
  • MAINTAINERS: Update ASPEED entry with details
Related show

Commit Message

Joel Stanley Feb. 22, 2018, 5:03 a.m.
I am interested in all ASPEED drivers, and the previous match wasn't
grabbing files in nested directories. Use N instead.

Add the arm kernel mailing list so that patches get reviewed there, and
the linux-aspeed list which exists only so I can use patchwork to track
patches.

Add Andrew as a reviewer, because he is involved in reviewing ASPEED
stuff.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 MAINTAINERS | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Andrew Jeffery Feb. 22, 2018, 8:39 a.m. | #1
On Thu, 22 Feb 2018, at 15:33, Joel Stanley wrote:
> I am interested in all ASPEED drivers, and the previous match wasn't
> grabbing files in nested directories. Use N instead.
> 
> Add the arm kernel mailing list so that patches get reviewed there, and
> the linux-aspeed list which exists only so I can use patchwork to track
> patches.
> 
> Add Andrew as a reviewer, because he is involved in reviewing ASPEED
> stuff.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Acked-by: Andrew Jeffery <andrew@aj.id.au>
Haiyue Wang Feb. 22, 2018, 8:50 a.m. | #2
Dear Andrew & Joel,

Since you are ASPEED BMC experts, any time and interest in eSPI code 
review ? I've sent

it before, but no more response. Intel recommends eSPI bus than LPC as I 
know. I just kept

the minimal eSPI code which is approved to work well in our real server 
boards for two more

years. Other part of eSPI driver from ASPEED's SDK  has been removed, 
because ePSI is a new

thing, we only use a small feature set like booting host.

We Intel submit this eSPI patch for openbmc upstreaming, hope for your 
response. :-)

https://patchwork.kernel.org/patch/10166577/



On 2018-02-22 16:39, Andrew Jeffery wrote:
>
> On Thu, 22 Feb 2018, at 15:33, Joel Stanley wrote:
>> I am interested in all ASPEED drivers, and the previous match wasn't
>> grabbing files in nested directories. Use N instead.
>>
>> Add the arm kernel mailing list so that patches get reviewed there, and
>> the linux-aspeed list which exists only so I can use patchwork to track
>> patches.
>>
>> Add Andrew as a reviewer, because he is involved in reviewing ASPEED
>> stuff.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Acked-by: Andrew Jeffery <andrew@aj.id.au>
Andrew Jeffery Feb. 23, 2018, 12:11 a.m. | #3
Hi Haiyue,

On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote:
> Dear Andrew & Joel,
> 
> Since you are ASPEED BMC experts, any time and interest in eSPI code 
> review ? I've sent
> 
> it before, but no more response. Intel recommends eSPI bus than LPC as I 
> know. I just kept
> 
> the minimal eSPI code which is approved to work well in our real server 
> boards for two more
> 
> years. Other part of eSPI driver from ASPEED's SDK  has been removed, 
> because ePSI is a new
> 
> thing, we only use a small feature set like booting host.
> 
> We Intel submit this eSPI patch for openbmc upstreaming, hope for your 
> response. :-)
> 
> https://patchwork.kernel.org/patch/10166577/
> 

There are some comments against the v1 that you linked to above, is there a v2 on the lists?

Separately it's better to ping us by replying to the patch itself and putting us in To/Cc, that way we keep discussions focused on the patch at hand here.

Cheers,

Andrew
Haiyue Wang Feb. 23, 2018, 1:44 a.m. | #4
On 2018-02-23 08:11, Andrew Jeffery wrote:
> Hi Haiyue,
>
> On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote:
>> Dear Andrew & Joel,
>>
>> Since you are ASPEED BMC experts, any time and interest in eSPI code
>> review ? I've sent
>>
>> it before, but no more response. Intel recommends eSPI bus than LPC as I
>> know. I just kept
>>
>> the minimal eSPI code which is approved to work well in our real server
>> boards for two more
>>
>> years. Other part of eSPI driver from ASPEED's SDK  has been removed,
>> because ePSI is a new
>>
>> thing, we only use a small feature set like booting host.
>>
>> We Intel submit this eSPI patch for openbmc upstreaming, hope for your
>> response. :-)
>>
>> https://patchwork.kernel.org/patch/10166577/
>>
> There are some comments against the v1 that you linked to above, is there a v2 on the lists?
A long holiday back, will send v2 patch soon.
> Separately it's better to ping us by replying to the patch itself and putting us in To/Cc, that way we keep discussions focused on the patch at hand here.
Got it. Thanks for your reply.
>
> Cheers,
>
> Andrew
Joel Stanley April 11, 2018, 4:06 a.m. | #5
Hey Arnd,

On 22 February 2018 at 15:33, Joel Stanley <joel@jms.id.au> wrote:
> I am interested in all ASPEED drivers, and the previous match wasn't
> grabbing files in nested directories. Use N instead.
>
> Add the arm kernel mailing list so that patches get reviewed there, and
> the linux-aspeed list which exists only so I can use patchwork to track
> patches.
>
> Add Andrew as a reviewer, because he is involved in reviewing ASPEED
> stuff.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>

can you please pick this one up? It would be great to get it into
fixes as Andrew and I have been missing being cc'd on stuff we would
have like to review.

Cheers,

Joel

> ---
>  MAINTAINERS | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9a7f76eadae9..1ebf49797175 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1226,10 +1226,15 @@ F:      Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
>
>  ARM/ASPEED MACHINE SUPPORT
>  M:     Joel Stanley <joel@jms.id.au>
> -S:     Maintained
> +R:     Andrew Jeffery <andrew@aj.id.au>
> +L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> +L:     linux-aspeed@lists.ozlabs.org (moderated for non-subscribers)
> +Q:     https://patchwork.ozlabs.org/project/linux-aspeed/list/
> +S:     Supported
> +T:     git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
>  F:     arch/arm/mach-aspeed/
>  F:     arch/arm/boot/dts/aspeed-*
> -F:     drivers/*/*aspeed*
> +N:     aspeed
>
>  ARM/ATMEL AT91 Clock Support
>  M:     Boris Brezillon <boris.brezillon@free-electrons.com>
> --
> 2.15.1
>
Arnd Bergmann April 11, 2018, 8:51 a.m. | #6
On Wed, Apr 11, 2018 at 6:06 AM, Joel Stanley <joel@jms.id.au> wrote:
> Hey Arnd,
>
> On 22 February 2018 at 15:33, Joel Stanley <joel@jms.id.au> wrote:
>> I am interested in all ASPEED drivers, and the previous match wasn't
>> grabbing files in nested directories. Use N instead.
>>
>> Add the arm kernel mailing list so that patches get reviewed there, and
>> the linux-aspeed list which exists only so I can use patchwork to track
>> patches.
>>
>> Add Andrew as a reviewer, because he is involved in reviewing ASPEED
>> stuff.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> can you please pick this one up? It would be great to get it into
> fixes as Andrew and I have been missing being cc'd on stuff we would
> have like to review.

Sure, applied to the fixes branch now.

In general, when you want a patch to be applied, please send it to
arm@kernel.org so we know it's for us. As a rule, I don't pick up patches
otherwise but assume that you are asking for feedback and/or Acks
but will resend it once everyone is happy with the change.

      Arnd
Joel Stanley April 11, 2018, 9:24 a.m. | #7
On 11 April 2018 at 18:21, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wed, Apr 11, 2018 at 6:06 AM, Joel Stanley <joel@jms.id.au> wrote:
>> Hey Arnd,
>>
>> On 22 February 2018 at 15:33, Joel Stanley <joel@jms.id.au> wrote:
>>> I am interested in all ASPEED drivers, and the previous match wasn't
>>> grabbing files in nested directories. Use N instead.
>>>
>>> Add the arm kernel mailing list so that patches get reviewed there, and
>>> the linux-aspeed list which exists only so I can use patchwork to track
>>> patches.
>>>
>>> Add Andrew as a reviewer, because he is involved in reviewing ASPEED
>>> stuff.
>>>
>>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>>
>> can you please pick this one up? It would be great to get it into
>> fixes as Andrew and I have been missing being cc'd on stuff we would
>> have like to review.
>
> Sure, applied to the fixes branch now.
>
> In general, when you want a patch to be applied, please send it to
> arm@kernel.org so we know it's for us. As a rule, I don't pick up patches
> otherwise but assume that you are asking for feedback and/or Acks
> but will resend it once everyone is happy with the change.

Okay. Do we have these rules written down anywhere?

If not, would you mind if I started a document on your behalf?

Cheers,

Joel
Arnd Bergmann April 11, 2018, 12:05 p.m. | #8
On Wed, Apr 11, 2018 at 11:24 AM, Joel Stanley <joel@jms.id.au> wrote:
> On 11 April 2018 at 18:21, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Wed, Apr 11, 2018 at 6:06 AM, Joel Stanley <joel@jms.id.au> wrote:
>>
>> Sure, applied to the fixes branch now.
>>
>> In general, when you want a patch to be applied, please send it to
>> arm@kernel.org so we know it's for us. As a rule, I don't pick up patches
>> otherwise but assume that you are asking for feedback and/or Acks
>> but will resend it once everyone is happy with the change.
>
> Okay. Do we have these rules written down anywhere?
>
> If not, would you mind if I started a document on your behalf?

Please go ahead, we can definitely use something in Documentation/arm/
that explains our process, we don't really have anything written.

      Arnd

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 9a7f76eadae9..1ebf49797175 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1226,10 +1226,15 @@  F:	Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
 
 ARM/ASPEED MACHINE SUPPORT
 M:	Joel Stanley <joel@jms.id.au>
-S:	Maintained
+R:	Andrew Jeffery <andrew@aj.id.au>
+L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
+L:	linux-aspeed@lists.ozlabs.org (moderated for non-subscribers)
+Q:	https://patchwork.ozlabs.org/project/linux-aspeed/list/
+S:	Supported
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
 F:	arch/arm/mach-aspeed/
 F:	arch/arm/boot/dts/aspeed-*
-F:	drivers/*/*aspeed*
+N:	aspeed
 
 ARM/ATMEL AT91 Clock Support
 M:	Boris Brezillon <boris.brezillon@free-electrons.com>