| Message ID | 20180221214023.1045-1-alexandre.belloni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | parisc: time: stop validating rtc_time in .read_time | expand |
On 21.02.2018 22:40, Alexandre Belloni wrote: > The RTC core is always calling rtc_valid_tm after the read_time callback. > It is not necessary to call it just before returning from the callback. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Helge Deller <deller@gmx.de> Thanks! Helge > --- > arch/parisc/kernel/time.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c > index 4b8fd6dc22da..f2890bd240f8 100644 > --- a/arch/parisc/kernel/time.c > +++ b/arch/parisc/kernel/time.c > @@ -173,7 +173,7 @@ static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm) > > /* we treat tod_sec as unsigned, so this can work until year 2106 */ > rtc_time64_to_tm(tod_data.tod_sec, tm); > - return rtc_valid_tm(tm); > + return 0; > } > > static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm) >
diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c index 4b8fd6dc22da..f2890bd240f8 100644 --- a/arch/parisc/kernel/time.c +++ b/arch/parisc/kernel/time.c @@ -173,7 +173,7 @@ static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm) /* we treat tod_sec as unsigned, so this can work until year 2106 */ rtc_time64_to_tm(tod_data.tod_sec, tm); - return rtc_valid_tm(tm); + return 0; } static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- arch/parisc/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)