| Message ID | 20180221213724.810-1-alexandre.belloni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | m68k: time: stop validating rtc_time in .read_time | expand |
Hi Alexandre, On Wed, Feb 21, 2018 at 10:37 PM, Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > The RTC core is always calling rtc_valid_tm after the read_time callback. > It is not necessary to call it just before returning from the callback. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Thank you, will apply and queue for v4.17. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/m68k/kernel/time.c b/arch/m68k/kernel/time.c index 87160b4415fb..97dd4e26f234 100644 --- a/arch/m68k/kernel/time.c +++ b/arch/m68k/kernel/time.c @@ -91,7 +91,7 @@ void read_persistent_clock(struct timespec *ts) static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm) { mach_hwclk(0, tm); - return rtc_valid_tm(tm); + return 0; } static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- arch/m68k/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)