Hi Alexandre, On 22 February 2018 at 04:56, Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > rtc_time64_to_tm never generates an invalid tm. It is not necessary to > validate it. Also, the RTC core is always calling rtc_valid_tm after the > read_time callback. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Thanks for fixing this, and please add my tag if it helps. Reviewed-by: Baolin Wang <baolin.wang@linaro.org> > --- > drivers/rtc/rtc-sc27xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c > index d544d5268757..00d87d138984 100644 > --- a/drivers/rtc/rtc-sc27xx.c > +++ b/drivers/rtc/rtc-sc27xx.c > @@ -376,7 +376,7 @@ static int sprd_rtc_read_time(struct device *dev, struct rtc_time *tm) > return ret; > > rtc_time64_to_tm(secs, tm); > - return rtc_valid_tm(tm); > + return 0; > } > > static int sprd_rtc_set_time(struct device *dev, struct rtc_time *tm) > -- > 2.16.1 >
diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c index d544d5268757..00d87d138984 100644 --- a/drivers/rtc/rtc-sc27xx.c +++ b/drivers/rtc/rtc-sc27xx.c @@ -376,7 +376,7 @@ static int sprd_rtc_read_time(struct device *dev, struct rtc_time *tm) return ret; rtc_time64_to_tm(secs, tm); - return rtc_valid_tm(tm); + return 0; } static int sprd_rtc_set_time(struct device *dev, struct rtc_time *tm)
rtc_time64_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- drivers/rtc/rtc-sc27xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)