Message ID | 20110319193005.526339455@alvy.suse.cz |
---|---|
State | New |
Headers | show |
> Hi, > > thi is really only based on successful testing and not much analyzis > of the context but it seems that we don't need lazy node construction > here. It would be nice not to have it after the big patch gets in. > > Thanks, > > Martin > > > 2011-03-18 Martin Jambor <mjambor@suse.cz> > > * objc-act.c (mark_referenced_methods): Call cgraph_do_get_node > instead of cgraph_get_create_node. Yes, this seems safe to me. Functions in protocols are finished and thus have cgraph node. Honza
Index: src/gcc/objc/objc-act.c =================================================================== --- src.orig/gcc/objc/objc-act.c 2011-03-18 20:21:00.000000000 +0100 +++ src/gcc/objc/objc-act.c 2011-03-18 20:21:05.000000000 +0100 @@ -4520,7 +4520,7 @@ mark_referenced_methods (void) while (chain) { cgraph_mark_needed_node ( - cgraph_get_create_node (METHOD_DEFINITION (chain))); + cgraph_do_get_node (METHOD_DEFINITION (chain))); chain = DECL_CHAIN (chain); } @@ -4528,7 +4528,7 @@ mark_referenced_methods (void) while (chain) { cgraph_mark_needed_node ( - cgraph_get_create_node (METHOD_DEFINITION (chain))); + cgraph_do_get_node (METHOD_DEFINITION (chain))); chain = DECL_CHAIN (chain); } }