| Message ID | 1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Optimizes, cleans up and enhances stm32-exti irq hierarchy | expand |
Hi Radoslaw, On 02/21/2018 02:50 PM, Radoslaw Pietrzyk wrote: > - removes unneeded irq_chip.irq_eoi callback > - adds irq_chip.irq_set_wake callback for possible > in the future GPIO wakeup > > Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index 617df16..5b1740d 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -268,10 +268,10 @@ static void stm32_gpio_irq_release_resources(struct irq_data *irq_data) > > static struct irq_chip stm32_gpio_irq_chip = { > .name = "stm32gpio", > - .irq_eoi = irq_chip_eoi_parent, > .irq_mask = irq_chip_mask_parent, > .irq_unmask = irq_chip_unmask_parent, > .irq_set_type = irq_chip_set_type_parent, > + .irq_set_wake = irq_chip_set_wake_parent, Thanks, this one was in my backlog. Acked-by: Alexandre TORGUE <alexandre.torgue@st.com> > .irq_request_resources = stm32_gpio_irq_request_resources, > .irq_release_resources = stm32_gpio_irq_release_resources, > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Maybe you could remove ARM from commit header. On 02/21/2018 02:50 PM, Radoslaw Pietrzyk wrote: > - removes unneeded irq_chip.irq_eoi callback > - adds irq_chip.irq_set_wake callback for possible > in the future GPIO wakeup > > Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index 617df16..5b1740d 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -268,10 +268,10 @@ static void stm32_gpio_irq_release_resources(struct irq_data *irq_data) > > static struct irq_chip stm32_gpio_irq_chip = { > .name = "stm32gpio", > - .irq_eoi = irq_chip_eoi_parent, > .irq_mask = irq_chip_mask_parent, > .irq_unmask = irq_chip_unmask_parent, > .irq_set_type = irq_chip_set_type_parent, > + .irq_set_wake = irq_chip_set_wake_parent, > .irq_request_resources = stm32_gpio_irq_request_resources, > .irq_release_resources = stm32_gpio_irq_release_resources, > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 21, 2018 at 2:50 PM, Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> wrote: > - removes unneeded irq_chip.irq_eoi callback > - adds irq_chip.irq_set_wake callback for possible > in the future GPIO wakeup > > Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> Patch applied with Alexandre's ACK, stripping ARM from the commit message, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
I don't know if Alexandre agrees but It might be better to take v2 where irq_ack is added. 2018-03-01 22:04 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>: > On Wed, Feb 21, 2018 at 2:50 PM, Radoslaw Pietrzyk > <radoslaw.pietrzyk@gmail.com> wrote: > >> - removes unneeded irq_chip.irq_eoi callback >> - adds irq_chip.irq_set_wake callback for possible >> in the future GPIO wakeup >> >> Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> > > Patch applied with Alexandre's ACK, stripping ARM from the > commit message, thanks! > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Radoslaw and Linus, On 03/01/2018 10:24 PM, Radosław Pietrzyk wrote: > I don't know if Alexandre agrees but It might be better to take v2 > where irq_ack is added. Sorry Linus, I agree with Rodoslaw, you need to take V2 as stm32-exti patch is linked to pinctrl v2 patch. I gonna add my acked-by. Regards Alex > > 2018-03-01 22:04 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>: >> On Wed, Feb 21, 2018 at 2:50 PM, Radoslaw Pietrzyk >> <radoslaw.pietrzyk@gmail.com> wrote: >> >>> - removes unneeded irq_chip.irq_eoi callback >>> - adds irq_chip.irq_set_wake callback for possible >>> in the future GPIO wakeup >>> >>> Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> >> >> Patch applied with Alexandre's ACK, stripping ARM from the >> commit message, thanks! >> >> Yours, >> Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Linus responded in v2 mail thread that he's gonna take it instead of v1. 2018-03-02 9:14 GMT+01:00 Alexandre Torgue <alexandre.torgue@st.com>: > Hi Radoslaw and Linus, > > > On 03/01/2018 10:24 PM, Radosław Pietrzyk wrote: >> >> I don't know if Alexandre agrees but It might be better to take v2 >> where irq_ack is added. > > > > Sorry Linus, I agree with Rodoslaw, you need to take V2 as stm32-exti patch > is linked to pinctrl v2 patch. I gonna add my acked-by. > > Regards > Alex > > >> >> 2018-03-01 22:04 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>: >>> >>> On Wed, Feb 21, 2018 at 2:50 PM, Radoslaw Pietrzyk >>> <radoslaw.pietrzyk@gmail.com> wrote: >>> >>>> - removes unneeded irq_chip.irq_eoi callback >>>> - adds irq_chip.irq_set_wake callback for possible >>>> in the future GPIO wakeup >>>> >>>> Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> >>> >>> >>> Patch applied with Alexandre's ACK, stripping ARM from the >>> commit message, thanks! >>> >>> Yours, >>> Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/02/2018 09:37 AM, Radosław Pietrzyk wrote: > Linus responded in v2 mail thread that he's gonna take it instead of v1. I saw that too late :). Regards Alex > > 2018-03-02 9:14 GMT+01:00 Alexandre Torgue <alexandre.torgue@st.com>: >> Hi Radoslaw and Linus, >> >> >> On 03/01/2018 10:24 PM, Radosław Pietrzyk wrote: >>> >>> I don't know if Alexandre agrees but It might be better to take v2 >>> where irq_ack is added. >> >> >> >> Sorry Linus, I agree with Rodoslaw, you need to take V2 as stm32-exti patch >> is linked to pinctrl v2 patch. I gonna add my acked-by. >> >> Regards >> Alex >> >> >>> >>> 2018-03-01 22:04 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>: >>>> >>>> On Wed, Feb 21, 2018 at 2:50 PM, Radoslaw Pietrzyk >>>> <radoslaw.pietrzyk@gmail.com> wrote: >>>> >>>>> - removes unneeded irq_chip.irq_eoi callback >>>>> - adds irq_chip.irq_set_wake callback for possible >>>>> in the future GPIO wakeup >>>>> >>>>> Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> >>>> >>>> >>>> Patch applied with Alexandre's ACK, stripping ARM from the >>>> commit message, thanks! >>>> >>>> Yours, >>>> Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 617df16..5b1740d 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -268,10 +268,10 @@ static void stm32_gpio_irq_release_resources(struct irq_data *irq_data) static struct irq_chip stm32_gpio_irq_chip = { .name = "stm32gpio", - .irq_eoi = irq_chip_eoi_parent, .irq_mask = irq_chip_mask_parent, .irq_unmask = irq_chip_unmask_parent, .irq_set_type = irq_chip_set_type_parent, + .irq_set_wake = irq_chip_set_wake_parent, .irq_request_resources = stm32_gpio_irq_request_resources, .irq_release_resources = stm32_gpio_irq_release_resources, };
- removes unneeded irq_chip.irq_eoi callback - adds irq_chip.irq_set_wake callback for possible in the future GPIO wakeup Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> --- drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)