| Message ID | 20180221043311.25840-2-suzuki.katsuhiro@socionext.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | ASoC: add support for ROHM BD28623 codec | expand |
On Wed, Feb 21, 2018 at 01:33:10PM +0900, Katsuhiro Suzuki wrote: > +Optional properties: > +- VCCA-supply : regulator phandle for the VCCA supply > +- VCCP1-supply: regulator phandle for the VCCP1 supply > +- VCCP2-supply: regulator phandle for the VCCP2 supply These should be documented as mandatory unless the device genuinely operates without power which seems unlikely.
Hello Mark, Thank you for your review. > -----Original Message----- > From: Mark Brown [mailto:broonie@kernel.org] > Sent: Wednesday, February 21, 2018 9:14 PM > To: Suzuki, Katsuhiro <suzuki.katsuhiro@socionext.com> > Cc: alsa-devel@alsa-project.org; Rob Herring <robh+dt@kernel.org>; devicetree@vger.kernel.org; Masami Hiramatsu > <masami.hiramatsu@linaro.org>; Jassi Brar <jaswinder.singh@linaro.org>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec > > On Wed, Feb 21, 2018 at 01:33:10PM +0900, Katsuhiro Suzuki wrote: > > > +Optional properties: > > +- VCCA-supply : regulator phandle for the VCCA supply > > +- VCCP1-supply: regulator phandle for the VCCP1 supply > > +- VCCP2-supply: regulator phandle for the VCCP2 supply > > These should be documented as mandatory unless the device genuinely > operates without power which seems unlikely. Indeed, this IC does not work correctly if VCC power supply is lost. It's not optional. I'll fix it and send V2. Regards, -- Katsuhiro Suzuki -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt b/Documentation/devicetree/bindings/sound/rohm,bd28623.txt new file mode 100644 index 000000000000..954c689b5b08 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/rohm,bd28623.txt @@ -0,0 +1,26 @@ +ROHM BD28623MUV Class D speaker amplifier for digital input + +This codec does not have any control buses such as I2C, it detect format and +rate of I2S signal automatically. It has two signals that can be connected +to GPIOs: reset and mute. + +Required properties: +- compatible : should be "rohm,bd28623" +- #sound-dai-cells: should be 0. +- reset-gpios : GPIO specifier for the active low reset line +- mute-gpios : GPIO specifier for the active low mute line + +Optional properties: +- VCCA-supply : regulator phandle for the VCCA supply +- VCCP1-supply: regulator phandle for the VCCP1 supply +- VCCP2-supply: regulator phandle for the VCCP2 supply + +Example: + + codec { + compatible = "rohm,bd28623"; + #sound-dai-cells = <0>; + + reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>; + mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; + };
This patch adds DT bindings documentation for ROHM BD28623MUV class D speaker amplifier. Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com> --- .../devicetree/bindings/sound/rohm,bd28623.txt | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.txt