Patchwork [Natty,linux-firmware,pull-request] UBUNTU: Add symlinks to broadcom firmware files

login
register
mail settings
Submitter Leann Ogasawara
Date March 18, 2011, 7:48 p.m.
Message ID <1300477692.1813.38.camel@emiko>
Download mbox
Permalink /patch/87573/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/ogasawara/linux-firmware.git lp728746v2

Comments

Leann Ogasawara - March 18, 2011, 7:48 p.m.
On Fri, 2011-03-18 at 13:02 -0600, Tim Gardner wrote:
> On 03/18/2011 12:02 PM, Leann Ogasawara wrote:
> > BugLink: http://bugs.launchpad.net/bugs/728746
> >
> > The brcm80211 module tries to load non-existent firmware and thus throws
> > the following type of error:
> >
> > brcm80211: fail to load firmware brcm/bcm43xx-0.fw
> > brcm80211: Failed to find firmware usually in /lib/firmware/brcm
> >
> > The necessary firmware is actually available at:
> >
> > /lib/firmware/brcm/bcm43xx-0-610-809-0.fw
> > /lib/firmware/brcm/bcm43xx_hdr-0-610-809-0.fw
> >
> > Adding symlinks to the proper files resolves the issue and has been
> > confirmed by the bug reporter to allow the driver/device to operate as
> > expected.

> While symlinks will solve this particular problem, its not the way the 
> rest of the firmware files are used. I think we should simply rename the 
> firmware file to what the driver is expecting. That way its clear on the 
> next update that you have to rename your incoming versioned file to 
> something the driver can load (bcm43xx-0.fw for example). Its also 
> consistent with the way the rest of the firmware files are handled. We 
> also keep track of the firmware version number in WHENCE.

Sounds reasonable to me.  The updated pull request below renames the
files rather than creating symlinks.

The following changes since commit bd96ae379112b379396a2c1da83601932236f18e:

  Ubuntu-1.48 (2011-03-03 07:55:43 -0700)

are available in the git repository at:
  git://kernel.ubuntu.com/ogasawara/linux-firmware.git lp728746v2

Leann Ogasawara (1):
      UBUNTU: Rename bcm43xx Broadcom Firmware Files

 brcm/{bcm43xx-0-610-809-0.fw => bcm43xx-0.fw}      |  Bin 97376 -> 97376 bytes
 ...bcm43xx_hdr-0-610-809-0.fw => bcm43xx_hdr-0.fw} |  Bin 180 -> 180 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)
 rename brcm/{bcm43xx-0-610-809-0.fw => bcm43xx-0.fw} (100%)
 rename brcm/{bcm43xx_hdr-0-610-809-0.fw => bcm43xx_hdr-0.fw} (100%)
Tim Gardner - March 18, 2011, 8:38 p.m.
On 03/18/2011 01:48 PM, Leann Ogasawara wrote:
> On Fri, 2011-03-18 at 13:02 -0600, Tim Gardner wrote:
>> On 03/18/2011 12:02 PM, Leann Ogasawara wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/728746
>>>
>>> The brcm80211 module tries to load non-existent firmware and thus throws
>>> the following type of error:
>>>
>>> brcm80211: fail to load firmware brcm/bcm43xx-0.fw
>>> brcm80211: Failed to find firmware usually in /lib/firmware/brcm
>>>
>>> The necessary firmware is actually available at:
>>>
>>> /lib/firmware/brcm/bcm43xx-0-610-809-0.fw
>>> /lib/firmware/brcm/bcm43xx_hdr-0-610-809-0.fw
>>>
>>> Adding symlinks to the proper files resolves the issue and has been
>>> confirmed by the bug reporter to allow the driver/device to operate as
>>> expected.
>
>> While symlinks will solve this particular problem, its not the way the
>> rest of the firmware files are used. I think we should simply rename the
>> firmware file to what the driver is expecting. That way its clear on the
>> next update that you have to rename your incoming versioned file to
>> something the driver can load (bcm43xx-0.fw for example). Its also
>> consistent with the way the rest of the firmware files are handled. We
>> also keep track of the firmware version number in WHENCE.
>
> Sounds reasonable to me.  The updated pull request below renames the
> files rather than creating symlinks.
>
> The following changes since commit bd96ae379112b379396a2c1da83601932236f18e:
>
>    Ubuntu-1.48 (2011-03-03 07:55:43 -0700)
>
> are available in the git repository at:
>    git://kernel.ubuntu.com/ogasawara/linux-firmware.git lp728746v2
>
> Leann Ogasawara (1):
>        UBUNTU: Rename bcm43xx Broadcom Firmware Files
>
>   brcm/{bcm43xx-0-610-809-0.fw =>  bcm43xx-0.fw}      |  Bin 97376 ->  97376 bytes
>   ...bcm43xx_hdr-0-610-809-0.fw =>  bcm43xx_hdr-0.fw} |  Bin 180 ->  180 bytes
>   2 files changed, 0 insertions(+), 0 deletions(-)
>   rename brcm/{bcm43xx-0-610-809-0.fw =>  bcm43xx-0.fw} (100%)
>   rename brcm/{bcm43xx_hdr-0-610-809-0.fw =>  bcm43xx_hdr-0.fw} (100%)
>
>

Applied and uploaded