Patchwork [Natty,linux-firmware,pull-request] UBUNTU: Add symlinks to broadcom firmware files

login
register
mail settings
Submitter Leann Ogasawara
Date March 18, 2011, 6:02 p.m.
Message ID <1300471375.1813.34.camel@emiko>
Download mbox
Permalink /patch/87564/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/ogasawara/linux-firmware.git lp728746

Comments

Leann Ogasawara - March 18, 2011, 6:02 p.m.
BugLink: http://bugs.launchpad.net/bugs/728746

The brcm80211 module tries to load non-existent firmware and thus throws
the following type of error:

brcm80211: fail to load firmware brcm/bcm43xx-0.fw
brcm80211: Failed to find firmware usually in /lib/firmware/brcm

The necessary firmware is actually available at:

/lib/firmware/brcm/bcm43xx-0-610-809-0.fw
/lib/firmware/brcm/bcm43xx_hdr-0-610-809-0.fw

Adding symlinks to the proper files resolves the issue and has been
confirmed by the bug reporter to allow the driver/device to operate as
expected.

Pull request is as follows, please consider applying to the Natty
linux-firmware package.

The following changes since commit bd96ae379112b379396a2c1da83601932236f18e:

  Ubuntu-1.48 (2011-03-03 07:55:43 -0700)

are available in the git repository at:
  git://kernel.ubuntu.com/ogasawara/linux-firmware.git lp728746

Leann Ogasawara (1):
      UBUNTU: Add symlinks to broadcom firmware files

 brcm/bcm43xx-0.fw     |    1 +
 brcm/bcm43xx_hdr-0.fw |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
 create mode 120000 brcm/bcm43xx-0.fw
 create mode 120000 brcm/bcm43xx_hdr-0.fw
Tim Gardner - March 18, 2011, 7:02 p.m.
On 03/18/2011 12:02 PM, Leann Ogasawara wrote:
> BugLink: http://bugs.launchpad.net/bugs/728746
>
> The brcm80211 module tries to load non-existent firmware and thus throws
> the following type of error:
>
> brcm80211: fail to load firmware brcm/bcm43xx-0.fw
> brcm80211: Failed to find firmware usually in /lib/firmware/brcm
>
> The necessary firmware is actually available at:
>
> /lib/firmware/brcm/bcm43xx-0-610-809-0.fw
> /lib/firmware/brcm/bcm43xx_hdr-0-610-809-0.fw
>
> Adding symlinks to the proper files resolves the issue and has been
> confirmed by the bug reporter to allow the driver/device to operate as
> expected.
>
> Pull request is as follows, please consider applying to the Natty
> linux-firmware package.
>
> The following changes since commit bd96ae379112b379396a2c1da83601932236f18e:
>
>    Ubuntu-1.48 (2011-03-03 07:55:43 -0700)
>
> are available in the git repository at:
>    git://kernel.ubuntu.com/ogasawara/linux-firmware.git lp728746
>
> Leann Ogasawara (1):
>        UBUNTU: Add symlinks to broadcom firmware files
>
>   brcm/bcm43xx-0.fw     |    1 +
>   brcm/bcm43xx_hdr-0.fw |    1 +
>   2 files changed, 2 insertions(+), 0 deletions(-)
>   create mode 120000 brcm/bcm43xx-0.fw
>   create mode 120000 brcm/bcm43xx_hdr-0.fw
>
>

While symlinks will solve this particular problem, its not the way the 
rest of the firmware files are used. I think we should simply rename the 
firmware file to what the driver is expecting. That way its clear on the 
next update that you have to rename your incoming versioned file to 
something the driver can load (bcm43xx-0.fw for example). Its also 
consistent with the way the rest of the firmware files are handled. We 
also keep track of the firmware version number in WHENCE.

rtg