From patchwork Fri Mar 18 16:51:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 87552 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 42A6DB6FDD for ; Sat, 19 Mar 2011 03:51:30 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1Q0ctV-0006VE-6p; Fri, 18 Mar 2011 16:51:21 +0000 Received: from smtp.outflux.net ([198.145.64.163]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1Q0ctS-0006UF-AB for kernel-team@lists.ubuntu.com; Fri, 18 Mar 2011 16:51:18 +0000 Received: from www.outflux.net (serenity-end.outflux.net [10.2.0.2]) by vinyl.outflux.net (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id p2IGpGsH014634 for ; Fri, 18 Mar 2011 09:51:17 -0700 Date: Fri, 18 Mar 2011 09:51:16 -0700 From: Kees Cook To: kernel-team@lists.ubuntu.com Subject: [PATCH, natty and maverick] Yama: fix default relationship to check thread group Message-ID: <20110318165116.GH5466@outflux.net> MIME-Version: 1.0 Content-Disposition: inline Organization: Ubuntu X-MIMEDefang-Filter: outflux$Revision: 1.316 $ X-HELO: www.outflux.net X-Scanned-By: MIMEDefang 2.67 on 10.2.0.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com Yet another case of a thread needing to match against the group leader. Signed-off-by: Kees Cook Acked-by: Stefan Bader Acked-by: Brad Figg Acked-by: Brad Figg --- security/yama/yama_lsm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index b05f1dd..c8f3020 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -173,6 +173,8 @@ static int task_is_descendant(struct task_struct *parent, rcu_read_lock(); read_lock(&tasklist_lock); + if (!thread_group_leader(parent)) + parent = parent->group_leader; while (walker->pid > 0) { if (!thread_group_leader(walker)) walker = walker->group_leader;