Patchwork [MAVERICK,SRU,1/2] Bug#737208 PM / Hibernate: Make default image size depend on total RAM size

login
register
mail settings
Submitter Manoj Iyer
Date March 18, 2011, 4:22 p.m.
Message ID <1300465342-4028-1-git-send-email-manoj.iyer@canonical.com>
Download mbox
Permalink /patch/87548/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/manjo/ubuntu-maverick.git lp737208

Comments

Manoj Iyer - March 18, 2011, 4:22 p.m.
Please consider the following SRU to maverick. The patch to hibernate code
helps to solve failure to hibernate issues seen on some lenovo laptops.

I have already proposed this patch to stable@kernel.org.

SRU JUSTIFICATION
---------------------------

CAUSE
-----------
[ 839.784885] PM: Creating hibernation image:
[ 839.788014] PM: Need to copy 120225 pages
[ 839.788014] PM: Normal pages needed: 118714 + 1024, available pages: 118002
[ 839.788014] PM: Not enough free memory
[ 839.788014] PM: Error -12 creating hibernation image

FIX
----
Upstream patch reduces the image size to it equal 2/5 of the total RAM size. 
This combined with shutdown hibernate mode fixes this issue.

TEST
------
This upstream patch was tested on a lenovo x120e by me, 
please see comments above for test results and details.

The following changes since commit 98e5bbf03976d01a116c000ec141ec7b5325f759:

  UBUNTU: Ubuntu-2.6.35-28.50 (2011-03-13 09:54:14 -0700)

are available in the git repository at:
  git://kernel.ubuntu.com/manjo/ubuntu-maverick.git lp737208

Rafael J. Wysocki (2):
      PM / Hibernate: Improve comments in hibernate_preallocate_memory()
      PM / Hibernate: Make default image size depend on total RAM size

 Documentation/power/interface.txt |    2 +-
 kernel/power/main.c               |    1 +
 kernel/power/power.h              |    9 ++++++++-
 kernel/power/snapshot.c           |   13 ++++++++++---
 4 files changed, 20 insertions(+), 5 deletions(-)
Tim Gardner - March 21, 2011, 1:11 p.m.
On 03/18/2011 10:22 AM, Manoj Iyer wrote:
> git://kernel.ubuntu.com/manjo/ubuntu-maverick.git lp737208

applied