From patchwork Fri Mar 18 16:09:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 87545 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 87196B6FE2 for ; Sat, 19 Mar 2011 03:09:39 +1100 (EST) Received: (qmail 6222 invoked by alias); 18 Mar 2011 16:09:35 -0000 Received: (qmail 6206 invoked by uid 22791); 18 Mar 2011 16:09:33 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Mar 2011 16:09:28 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 3E7AEDCE; Fri, 18 Mar 2011 17:09:26 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kwPeIw3KXSlG; Fri, 18 Mar 2011 17:09:24 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 25C9EDCD; Fri, 18 Mar 2011 17:09:24 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id p2IG9Nte014460; Fri, 18 Mar 2011 17:09:23 +0100 (MET) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: Richard Guenther , Eric Botcazou Subject: [testsuite] Properly XFAIL gcc.dg/vect/slp-multitypes-2.c on Solaris 2/SPARC Date: Fri, 18 Mar 2011 17:09:23 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org I noticed that gcc.dg/vect/slp-multitypes-2.c is failing on Solaris 8/x86 with Sun as: FAIL: gcc.dg/vect/slp-multitypes-2.c (test for excess errors) WARNING: gcc.dg/vect/slp-multitypes-2.c compilation failed to produce executable Excess errors: Assembler: slp-multitypes-2.c "/var/tmp//ccmA7WBi.s", line 16 : Illegal mnemonic "/var/tmp//ccmA7WBi.s", line 16 : Syntax error unpcklpd %xmm0,%xmm2 This should be dealt with by the explicit check_vect_support_and_set_flags in vect.exp, which does } elseif { [istarget "i?86-*-*"] || [istarget "x86_64-*-*"] } { lappend DEFAULT_VECTCFLAGS "-msse2" if { [check_effective_target_sse2_runtime] } { set dg-do-what-default run } else { set dg-do-what-default compile } Unfortunately, this gets overridden by the explicit /* { dg-do run { xfail { sparc*-*-* && ilp32 } } } PR rtl-opt /46603 */ To fix this, I've changed the testcase to use dg-xfail-run-if instead. Besides, I see the failure only with gas, not Sun as. The following patch has been tested with the appropriate runtest invocations on both i386-pc-solaris2.8 and sparc-sun-solaris2.10 (both as and gas). I'm about to commit this to mainline. The 4.5 branch is unaffected, but 4.6 is. Ok there, too, after testing? Thanks. Rainer 2011-03-18 Rainer Orth * gcc.dg/vect/slp-multitypes-2.c: Replace dg-do run with dg-xfail-run-if. Only xfail with gas. diff -r eebced2eebe8 gcc/testsuite/gcc.dg/vect/slp-multitypes-2.c --- a/gcc/testsuite/gcc.dg/vect/slp-multitypes-2.c Fri Mar 18 10:52:22 2011 +0100 +++ b/gcc/testsuite/gcc.dg/vect/slp-multitypes-2.c Fri Mar 18 16:58:49 2011 +0100 @@ -1,5 +1,5 @@ /* { dg-require-effective-target vect_int } */ -/* { dg-do run { xfail { sparc*-*-* && ilp32 } } } PR rtl-opt/46603 */ +/* { dg-xfail-run-if "PR rtl-optimization/46603" { sparc*-*-* && { ilp32 && gas } } } */ #include #include "tree-vect.h"