| Message ID | 20180219154827.215990-7-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Alexander Graf |
| Headers | show |
| Series | efi: Enable basic sandbox support for EFI loader | expand |
On 02/19/2018 04:48 PM, Simon Glass wrote: > The headers are not in the correct order. Fix this. Also drop libfdt_env.h > since it is not needed. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v3: None > Changes in v2: > - Update commit message to dropping libfdt_env.h > > lib/efi_loader/efi_memory.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c > index aaf64421a3..c273a7ba30 100644 > --- a/lib/efi_loader/efi_memory.c > +++ b/lib/efi_loader/efi_memory.c > @@ -8,12 +8,11 @@ > > #include <common.h> > #include <efi_loader.h> > +#include <inttypes.h> > #include <malloc.h> > +#include <watchdog.h> > #include <asm/global_data.h> > -#include <libfdt_env.h> The patch has to be rebased due to b08c8c48708 libfdt: move headers to <linux/libfdt.h> and <linux/libfdt_env.h> Otherwise Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > #include <linux/list_sort.h> > -#include <inttypes.h> > -#include <watchdog.h> > > DECLARE_GLOBAL_DATA_PTR; > >
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index aaf64421a3..c273a7ba30 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -8,12 +8,11 @@ #include <common.h> #include <efi_loader.h> +#include <inttypes.h> #include <malloc.h> +#include <watchdog.h> #include <asm/global_data.h> -#include <libfdt_env.h> #include <linux/list_sort.h> -#include <inttypes.h> -#include <watchdog.h> DECLARE_GLOBAL_DATA_PTR;
The headers are not in the correct order. Fix this. Also drop libfdt_env.h since it is not needed. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v3: None Changes in v2: - Update commit message to dropping libfdt_env.h lib/efi_loader/efi_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)