From patchwork Fri Mar 18 08:26:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 87506 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yw0-f56.google.com (mail-yw0-f56.google.com [209.85.213.56]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id AA003B6FDF for ; Fri, 18 Mar 2011 19:26:20 +1100 (EST) Received: by ywc21 with SMTP id 21sf2863391ywc.11 for ; Fri, 18 Mar 2011 01:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:mime-version:x-beenthere:received-spf:from:to :cc:subject:date:message-id:x-mailer:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=3h4y0EVCdF0bvsX8iZHMLLA1PYbGrNNiEN5qKGcJaew=; b=cggOooCUoasRa1dZpNWJ6ylytdGjavGITg/AdNLNUireCcW51zUxnrqs9Ib2g+bymU Q0h1h+F6TYS53QHuBn3CqoAHRYIq4ykx4TfKhPZKY44bQg92kVxFezYVFVgC2ojUR2EH qBop6ueg6XsAO18ErG6G4C9iEisdog7BBot3g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; b=CNJOZTypWDdzUWVXszAW+AZJmFzwdt3sGKvaLbebNu382cvEqLU1hDPkd4C7BgoYk5 Iq1rZFXW8mjeu7WccrtGe+RMYkm1M6Ed/bGCVI4+YWnJTYvlVQoRAFg8sTdsWAqegYjX xEK/njL3gdskJs/TYYlNUEcI8ng0wsZ5747R4= Received: by 10.91.62.6 with SMTP id p6mr137239agk.4.1300436776768; Fri, 18 Mar 2011 01:26:16 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.231.30.135 with SMTP id u7ls1878ibc.2.p; Fri, 18 Mar 2011 01:26:15 -0700 (PDT) Received: by 10.231.17.75 with SMTP id r11mr547889iba.3.1300436772212; Fri, 18 Mar 2011 01:26:12 -0700 (PDT) Received: by 10.231.17.75 with SMTP id r11mr547843iba.3.1300436768894; Fri, 18 Mar 2011 01:26:08 -0700 (PDT) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by gmr-mx.google.com with ESMTPS id c4si736532ict.4.2011.03.18.01.26.07 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 Mar 2011 01:26:07 -0700 (PDT) Received-SPF: pass (google.com: domain of vapier@gentoo.org designates 140.211.166.183 as permitted sender) client-ip=140.211.166.183; Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 6EA291B403E; Fri, 18 Mar 2011 08:26:06 +0000 (UTC) From: Mike Frysinger To: rtc-linux@googlegroups.com, Alessandro Zummo Cc: John Stultz , linux-kernel@vger.kernel.org, stable@kernel.org Subject: [rtc-linux] [PATCH] rtc-bfin: add missing "return 0" in new alarm func Date: Fri, 18 Mar 2011 04:26:24 -0400 Message-Id: <1300436784-26543-1-git-send-email-vapier@gentoo.org> X-Mailer: git-send-email 1.7.4.1 X-Original-Sender: vapier@gentoo.org X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of vapier@gentoo.org designates 140.211.166.183 as permitted sender) smtp.mail=vapier@gentoo.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to the end leading to the build warning: drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable': drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function CC: stable@kernel.org Signed-off-by: Mike Frysinger Acked-by: Harry Wei Acked-by: John Stultz --- drivers/rtc/rtc-bfin.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c index 17971d9..0e61e2d 100644 --- a/drivers/rtc/rtc-bfin.c +++ b/drivers/rtc/rtc-bfin.c @@ -276,6 +276,8 @@ static int bfin_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) bfin_rtc_int_set_alarm(rtc); else bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY)); + + return 0; } static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm)