Patchwork rtc-bfin: add missing "return 0" in new alarm func

login
register
mail settings
Submitter Mike Frysinger
Date March 18, 2011, 8:26 a.m.
Message ID <1300436784-26543-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/87506/
State New
Headers show

Comments

Mike Frysinger - March 18, 2011, 8:26 a.m.
The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
the end leading to the build warning:
	drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
	drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function

CC: stable@kernel.org
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/rtc/rtc-bfin.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Harry Wei - March 18, 2011, 2:26 p.m.
On Fri, Mar 18, 2011 at 04:26:24AM -0400, Mike Frysinger wrote:
> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
> the end leading to the build warning:
> 	drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
> 	drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
Hi Mike,
   I am sure we should give a return-value
but whether it is '0'? Maybe it should return
other value.
   Can you give some explanations for yours.

   Thanks.
   Best Regards.
   Harry Wei.
> 
> CC: stable@kernel.org
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  drivers/rtc/rtc-bfin.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
> index 17971d9..0e61e2d 100644
> --- a/drivers/rtc/rtc-bfin.c
> +++ b/drivers/rtc/rtc-bfin.c
> @@ -276,6 +276,8 @@ static int bfin_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
>  		bfin_rtc_int_set_alarm(rtc);
>  	else
>  		bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY));
> +
> +	return 0;
>  }
>  
>  static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm)
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
Mike Frysinger - March 18, 2011, 5:52 p.m.
On Fri, Mar 18, 2011 at 10:26, Harry Wei wrote:
> On Fri, Mar 18, 2011 at 04:26:24AM -0400, Mike Frysinger wrote:
>> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
>> the end leading to the build warning:
>>       drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
>>       drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
>
>   I am sure we should give a return-value
> but whether it is '0'? Maybe it should return
> other value.
>   Can you give some explanations for yours.

read the interface.c code ... this func returns 0 on "success".  i
dont know what other possible value this could return.
-mike
Harry Wei - March 19, 2011, 1:15 a.m.
On Sat, Mar 19, 2011 at 09:10:14AM +0800, jiaweiwei wrote:
> 
> >> the end leading to the build warning:
> >>        drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
> >>        drivers/rtc/rtc-bfin.c:253: warning: control reaches end of
> >> non-void function
> >>
> >> CC: stable@kernel.org
> >> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Harry Wei <harryxiyou@gmail.com>
> >> ---
> >>  drivers/rtc/rtc-bfin.c |    2 ++
> >>  1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
> >> index 17971d9..0e61e2d 100644
> >> --- a/drivers/rtc/rtc-bfin.c
> >> +++ b/drivers/rtc/rtc-bfin.c
> >> @@ -276,6 +276,8 @@ static int bfin_rtc_alarm_irq_enable(struct device
> >> *dev, unsigned int enabled)
> >>                bfin_rtc_int_set_alarm(rtc);
> >>        else
> >>                bfin_rtc_int_clear(~(RTC_ISTAT_ALARM |
> >> RTC_ISTAT_ALARM_DAY));
> >> +
> >> +       return 0;
> >>  }
> >>
> >>  static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm)
> >> --
> >> 1.7.4.1
> >>
>alarm_irq_enable function forgot to add a "return 0" to
>> the end leading to the build warning:
>>       drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
>>       drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
>
>   I am sure we should give a return-value
> but whether it is '0'? Maybe it should return
> other value.
>   Can you give some explanations for yours.

>read the interface.c code ... this func returns 0 on "success".  i
>dont know what other possible value this could return.
Oh, it is true.

Thanks.
Best Regards.
Harry Wei.
John Stultz - March 19, 2011, 1:18 a.m.
On Fri, 2011-03-18 at 04:26 -0400, Mike Frysinger wrote:
> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
> the end leading to the build warning:
> 	drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
> 	drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
> 
> CC: stable@kernel.org
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Thanks for catching this!

Acked-by: John Stultz <john.stultz@linaro.org>

Patch

diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
index 17971d9..0e61e2d 100644
--- a/drivers/rtc/rtc-bfin.c
+++ b/drivers/rtc/rtc-bfin.c
@@ -276,6 +276,8 @@  static int bfin_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
 		bfin_rtc_int_set_alarm(rtc);
 	else
 		bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY));
+
+	return 0;
 }
 
 static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm)