Patchwork [U-Boot,10/11] Copy the ramdisk from flash for the DNS323

login
register
mail settings
Submitter Rogan Dawes
Date March 18, 2011, 8:04 a.m.
Message ID <1300435500-4909-11-git-send-email-rogan@dawes.za.net>
Download mbox | patch
Permalink /patch/87499/
State Not Applicable
Headers show

Comments

Rogan Dawes - March 18, 2011, 8:04 a.m.
From: rogan@dawes.za.net <rogan@dawes.za.net>

---
 common/image.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Wolfgang Denk - April 25, 2011, 9:44 p.m.
Dear rogan@dawes.za.net,

In message <1300435500-4909-11-git-send-email-rogan@dawes.za.net> you wrote:
> From: rogan@dawes.za.net <rogan@dawes.za.net>
> 
> ---
>  common/image.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

This is the wrong approach.

Rather fix the Linux kernel to accept a ramdisk address in NOR flash.
See the mailing list archives (both u-boot and linux-arm-kernel) for
details.

Best regards,

Wolfgang Denk
Rogan Dawes - April 26, 2011, 7:09 a.m.
On 2011/04/25 11:44 PM, Wolfgang Denk wrote:
> Dear rogan@dawes.za.net,
>
> In message<1300435500-4909-11-git-send-email-rogan@dawes.za.net>  you wrote:
>> From: rogan@dawes.za.net<rogan@dawes.za.net>
>>
>> ---
>>   common/image.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> This is the wrong approach.
>
> Rather fix the Linux kernel to accept a ramdisk address in NOR flash.
> See the mailing list archives (both u-boot and linux-arm-kernel) for
> details.
>
> Best regards,
>
> Wolfgang Denk
>

Hi Wolfgang,

Thanks for your comments on my patches.

Unfortunately, I seem to have toasted my board properly this time, and 
will not likely need them in future. I guess I will end up buying a 
different NAS next time (faster, bigger, cheaper), which will come with 
a different set of problems.

Thanks for all your help while I learned about U-Boot, JTAG, debugging, 
contributing, etc.

Regards,

Rogan

Patch

diff --git a/common/image.c b/common/image.c
index fcb938b..eea93a9 100644
--- a/common/image.c
+++ b/common/image.c
@@ -949,7 +949,7 @@  int boot_get_ramdisk (int argc, char * const argv[], bootm_headers_t *images,
 			return 1;
 		}
 
-#if defined(CONFIG_B2) || defined(CONFIG_EVB4510) || defined(CONFIG_ARMADILLO)
+#if defined(CONFIG_B2) || defined(CONFIG_EVB4510) || defined(CONFIG_ARMADILLO) || defined(CONFIG_MACH_DNS323)
 		/*
 		 * We need to copy the ramdisk to SRAM to let Linux boot
 		 */
@@ -957,7 +957,7 @@  int boot_get_ramdisk (int argc, char * const argv[], bootm_headers_t *images,
 			memmove ((void *)rd_load, (uchar *)rd_data, rd_len);
 			rd_data = rd_load;
 		}
-#endif /* CONFIG_B2 || CONFIG_EVB4510 || CONFIG_ARMADILLO */
+#endif /* CONFIG_B2 || CONFIG_EVB4510 || CONFIG_ARMADILLO || CONFIG_MACH_DNS323 */
 
 	} else if (images->legacy_hdr_valid &&
 			image_check_type (&images->legacy_hdr_os_copy, IH_TYPE_MULTI)) {