diff mbox series

[OpenWrt-Devel,v2,1/7] uclient-fetch: Check for nullpointer returned by uclient_get_url_filename

Message ID 20180218124610.32692-2-tobleminer@gmail.com
State Accepted
Delegated to: John Crispin
Headers show
Series uclient: Handle memory allocation failures | expand

Commit Message

Tobias Schramm Feb. 18, 2018, 12:46 p.m. UTC 
uclient_get_url_filename may return a null ptr resulting in a null
ptr dereference by fprintf and open

Signed-off-by: Tobias Schramm <tobleminer@gmail.com>
---
 uclient-fetch.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff mbox series

Patch

diff --git a/uclient-fetch.c b/uclient-fetch.c
index 6961d94..38c9c53 100644
--- a/uclient-fetch.c
+++ b/uclient-fetch.c
@@ -122,6 +122,11 @@  static int open_output_file(const char *path, uint64_t resume_offset)
 		}
 	} else {
 		filename = uclient_get_url_filename(path, "index.html");
+		if (!filename) {
+			ret = -ENOMEM;
+			goto out;
+		}
+
 		output_file = filename;
 	}
 
@@ -151,6 +156,7 @@  done:
 
 free:
 	free(filename);
+out:
 	return ret;
 }