diff mbox series

[05/10] dt-bindings: gpio: Add gpio nodes for Actions S900 SoC

Message ID 20180217204433.3095-6-manivannan.sadhasivam@linaro.org
State New
Headers show
Series Add Actions Semi S900 pinctrl and gpio support | expand

Commit Message

Manivannan Sadhasivam Feb. 17, 2018, 8:44 p.m. UTC
Add gpio nodes for Actions Semi S900 SoC.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 .../devicetree/bindings/gpio/actions,owl-gpio.txt         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt

Comments

Rob Herring (Arm) Feb. 19, 2018, 8:35 p.m. UTC | #1
On Sun, Feb 18, 2018 at 02:14:28AM +0530, Manivannan Sadhasivam wrote:
> Add gpio nodes for Actions Semi S900 SoC.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  .../devicetree/bindings/gpio/actions,owl-gpio.txt         | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> 
> diff --git a/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> new file mode 100644
> index 000000000000..4cd4cb7bfd1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> @@ -0,0 +1,15 @@
> +* Actions Semi OWL GPIO controller bindings
> +
> +- compatible      : Should be "actions,s900-gpio"
> +- reg             : Address and range of the GPIO controller registers.
> +- gpio-controller : Marks the device node as a GPIO controller.
> +- #gpio-cells     : Should be <2>. The first cell is the gpio number and
> +                    the second cell is used to specify optional parameters.

Doesn't do interrupts?

> +
> +Example:
> +       gpio: gpio@e01b0000 {
> +               compatible = "actions,s900-gpio";
> +               reg = <0x0 0xe01b0000 0x0 0x1000>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +       };
> -- 
> 2.14.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Manivannan Sadhasivam Feb. 21, 2018, 2:58 p.m. UTC | #2
Hi Rob,
On Mon, Feb 19, 2018 at 02:35:23PM -0600, Rob Herring wrote:
> On Sun, Feb 18, 2018 at 02:14:28AM +0530, Manivannan Sadhasivam wrote:
> > Add gpio nodes for Actions Semi S900 SoC.
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  .../devicetree/bindings/gpio/actions,owl-gpio.txt         | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> > new file mode 100644
> > index 000000000000..4cd4cb7bfd1b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
> > @@ -0,0 +1,15 @@
> > +* Actions Semi OWL GPIO controller bindings
> > +
> > +- compatible      : Should be "actions,s900-gpio"
> > +- reg             : Address and range of the GPIO controller registers.
> > +- gpio-controller : Marks the device node as a GPIO controller.
> > +- #gpio-cells     : Should be <2>. The first cell is the gpio number and
> > +                    the second cell is used to specify optional parameters.
> 
> Doesn't do interrupts?
> 
Interrupt support will be added once this base driver gets in.
One step at a time ;-)

Thanks,
Mani
> > +
> > +Example:
> > +       gpio: gpio@e01b0000 {
> > +               compatible = "actions,s900-gpio";
> > +               reg = <0x0 0xe01b0000 0x0 0x1000>;
> > +               gpio-controller;
> > +               #gpio-cells = <2>;
> > +       };
> > -- 
> > 2.14.1
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andreas Färber Feb. 21, 2018, 6:05 p.m. UTC | #3
Am 21.02.2018 um 15:58 schrieb Manivannan Sadhasivam:
> Hi Rob,
> On Mon, Feb 19, 2018 at 02:35:23PM -0600, Rob Herring wrote:
>> On Sun, Feb 18, 2018 at 02:14:28AM +0530, Manivannan Sadhasivam wrote:
>>> Add gpio nodes for Actions Semi S900 SoC.
>>>
>>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>> ---
>>>  .../devicetree/bindings/gpio/actions,owl-gpio.txt         | 15 +++++++++++++++
>>>  1 file changed, 15 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>>> new file mode 100644
>>> index 000000000000..4cd4cb7bfd1b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>>> @@ -0,0 +1,15 @@
>>> +* Actions Semi OWL GPIO controller bindings
>>> +
>>> +- compatible      : Should be "actions,s900-gpio"
>>> +- reg             : Address and range of the GPIO controller registers.
>>> +- gpio-controller : Marks the device node as a GPIO controller.
>>> +- #gpio-cells     : Should be <2>. The first cell is the gpio number and
>>> +                    the second cell is used to specify optional parameters.
>>
>> Doesn't do interrupts?
>>
> Interrupt support will be added once this base driver gets in.
> One step at a time ;-)

Rob rejected that step-by-step approach for my RDA Micro bindings, which
is why it is currently stuck. ;)

Regards,
Andreas
Rob Herring (Arm) Feb. 21, 2018, 11:52 p.m. UTC | #4
On Wed, Feb 21, 2018 at 8:58 AM, Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
> Hi Rob,
> On Mon, Feb 19, 2018 at 02:35:23PM -0600, Rob Herring wrote:
>> On Sun, Feb 18, 2018 at 02:14:28AM +0530, Manivannan Sadhasivam wrote:
>> > Add gpio nodes for Actions Semi S900 SoC.
>> >
>> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> > ---
>> >  .../devicetree/bindings/gpio/actions,owl-gpio.txt         | 15 +++++++++++++++
>> >  1 file changed, 15 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>> > new file mode 100644
>> > index 000000000000..4cd4cb7bfd1b
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>> > @@ -0,0 +1,15 @@
>> > +* Actions Semi OWL GPIO controller bindings
>> > +
>> > +- compatible      : Should be "actions,s900-gpio"
>> > +- reg             : Address and range of the GPIO controller registers.
>> > +- gpio-controller : Marks the device node as a GPIO controller.
>> > +- #gpio-cells     : Should be <2>. The first cell is the gpio number and
>> > +                    the second cell is used to specify optional parameters.
>>
>> Doesn't do interrupts?
>>
> Interrupt support will be added once this base driver gets in.
> One step at a time ;-)

Binding are separate from the driver. Drivers can evolve, but h/w
doesn't (for a given piece of Si). It is not a high bar to list
#interrupt-cells and interrupt-controller.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
new file mode 100644
index 000000000000..4cd4cb7bfd1b
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
@@ -0,0 +1,15 @@ 
+* Actions Semi OWL GPIO controller bindings
+
+- compatible      : Should be "actions,s900-gpio"
+- reg             : Address and range of the GPIO controller registers.
+- gpio-controller : Marks the device node as a GPIO controller.
+- #gpio-cells     : Should be <2>. The first cell is the gpio number and
+                    the second cell is used to specify optional parameters.
+
+Example:
+       gpio: gpio@e01b0000 {
+               compatible = "actions,s900-gpio";
+               reg = <0x0 0xe01b0000 0x0 0x1000>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };